[{"id":16931,"web_url":"https://patchwork.libcamera.org/comment/16931/","msgid":"","date":"2021-05-13T08:42:45","subject":"Re: [libcamera-devel] [PATCH v3 3/3] android: jpeg: post_processor:\n\tUse the new metadata functions","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Paul,\n\nThanks for your work.\n\nOn 2021-05-12 19:25:41 +0900, Paul Elder wrote:\n> Now that CameraMetadata supports more convenient functions, use those\n> instead.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Niklas Söderlund \n\n> \n> ---\n> New in v3\n> ---\n> src/android/jpeg/post_processor_jpeg.cpp | 11 ++++++-----\n> 1 file changed, 6 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\n> index 3bf16996..2ecf5578 100644\n> --- a/src/android/jpeg/post_processor_jpeg.cpp\n> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n> @@ -15,6 +15,7 @@\n> #include \"exif.h\"\n> \n> #include \n> +#include \n> \n> #include \"libcamera/internal/log.h\"\n> \n> @@ -103,7 +104,7 @@ int PostProcessorJpeg::process(const FrameBuffer &source,\n> \tret = requestMetadata.getEntry(ANDROID_JPEG_ORIENTATION, &entry);\n> \n> \tconst uint32_t jpegOrientation = ret ? *entry.data.i32 : 0;\n> -\tresultMetadata->addEntry(ANDROID_JPEG_ORIENTATION, &jpegOrientation, 1);\n> +\tresultMetadata->addEntry(ANDROID_JPEG_ORIENTATION, jpegOrientation);\n> \texif.setOrientation(jpegOrientation);\n> \n> \texif.setSize(streamSize_);\n> @@ -129,7 +130,7 @@ int PostProcessorJpeg::process(const FrameBuffer &source,\n> \tif (ret) {\n> \t\texif.setGPSDateTimestamp(*entry.data.i64);\n> \t\tresultMetadata->addEntry(ANDROID_JPEG_GPS_TIMESTAMP,\n> -\t\t\t\t\t entry.data.i64, 1);\n> +\t\t\t\t\t *entry.data.i64);\n> \t}\n> \n> \tret = requestMetadata.getEntry(ANDROID_JPEG_THUMBNAIL_SIZE, &entry);\n> @@ -140,7 +141,7 @@ int PostProcessorJpeg::process(const FrameBuffer &source,\n> \n> \t\tret = requestMetadata.getEntry(ANDROID_JPEG_THUMBNAIL_QUALITY, &entry);\n> \t\tuint8_t quality = ret ? *entry.data.u8 : 95;\n> -\t\tresultMetadata->addEntry(ANDROID_JPEG_THUMBNAIL_QUALITY, &quality, 1);\n> +\t\tresultMetadata->addEntry(ANDROID_JPEG_THUMBNAIL_QUALITY, quality);\n> \n> \t\tif (thumbnailSize != Size(0, 0)) {\n> \t\t\tstd::vector thumbnail;\n> @@ -172,7 +173,7 @@ int PostProcessorJpeg::process(const FrameBuffer &source,\n> \n> \tret = requestMetadata.getEntry(ANDROID_JPEG_QUALITY, &entry);\n> \tconst uint8_t quality = ret ? *entry.data.u8 : 95;\n> -\tresultMetadata->addEntry(ANDROID_JPEG_QUALITY, &quality, 1);\n> +\tresultMetadata->addEntry(ANDROID_JPEG_QUALITY, quality);\n> \n> \tint jpeg_size = encoder_->encode(source, destination->plane(0),\n> \t\t\t\t\t exif.data(), quality);\n> @@ -190,7 +191,7 @@ int PostProcessorJpeg::process(const FrameBuffer &source,\n> \tblob->jpeg_size = jpeg_size;\n> \n> \t/* Update the JPEG result Metadata. */\n> -\tresultMetadata->addEntry(ANDROID_JPEG_SIZE, &jpeg_size, 1);\n> +\tresultMetadata->addEntry(ANDROID_JPEG_SIZE, jpeg_size);\n> \n> \treturn 0;\n> }\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31C4CC31EB\n\tfor ;\n\tThu, 13 May 2021 08:42:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6DB96891D;\n\tThu, 13 May 2021 10:42:48 +0200 (CEST)","from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com\n\t[IPv6:2a00:1450:4864:20::12b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0899568919\n\tfor ;\n\tThu, 13 May 2021 10:42:47 +0200 (CEST)","by mail-lf1-x12b.google.com with SMTP id x2so37496097lff.10\n\tfor ;\n\tThu, 13 May 2021 01:42:47 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tc9sm362586ljb.22.2021.05.13.01.42.45\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 13 May 2021 01:42:46 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"kjG7a/F+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=+cH0WUTM8OkAU7veJD2b4metRNSvR9xlmB8pHyQUXPQ=;\n\tb=kjG7a/F+rGjECP1xboIJC2Mi/nKaTWO1+S7TYeVh3uFJ816YPaicswRH4j7P6nLDp8\n\tndAxsxoFqv8ThXUBVgVYRE0v/ma0MG78M2BVcElL1vjbDEkwVZted+H7fPk2NUyn/zZ5\n\tUjGTfEpKUwQkJuGKAMYOSx2j0TJ9lgNTpW2ANEGWXEY1ck0Cx7FRvA46+ertmGeq34UA\n\tpTv9Ee3fRzmzdNQPnHv2eo5acC61BlsB33EWanvfa3p4FOV1xyNaMzNX7gIuQB2yaqkp\n\tUqrrjvEIxzjytfnpFShKAM4W3E90SHwgDZ1z5kHvjrc/bMGXNIzIA3Hpm8vI2f4SeUeA\n\tTvMA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=+cH0WUTM8OkAU7veJD2b4metRNSvR9xlmB8pHyQUXPQ=;\n\tb=ghmMvig6AtzeN/8TQEuICKKNW5RTzXtHBfqnO1YmDHS2b15lDnMKuKY2RMwLw0W0e8\n\tsycz6NuJpdugwMmuloQS1fGeKNCJnoyqkuT4cHwPtndlUUk3+ste4MGxcqyHA+rx+gCI\n\tyBjyVtFKMHfynnGyEAj82vke9JBLtG1jbnSp6VnjGDhMcBuXVP3ZF8hU57dpnNchTuvI\n\tYDULxqMRwxTzP633q9/IReLjBI+GCR2Vx1Abji6xjpuftS/ZhdMfcu3sEtUCDFxNEm8n\n\tGEhQ9xM+SXUY92ZVH8dqXn1TbKPQE7bX6KJP6DS+eaN/DYvE+nkUmepzKSZQq2UMwbDp\n\t0g5Q==","X-Gm-Message-State":"AOAM531UtejHhjk+R/L4RSXylr6rq56bTGc415wQbFkJkpycWDvOOeQp\n\tNysAoZfscoo8N7IRP8g/lBBrMA==","X-Google-Smtp-Source":"ABdhPJwChq77NscUV6lKNbYuMofAmLaflkwAYLMpRwcFDB6euXINoS1+Vq02toq9+1GUDV/FzzkGSQ==","X-Received":"by 2002:a05:6512:3b9b:: with SMTP id\n\tg27mr28892892lfv.230.1620895366520; \n\tThu, 13 May 2021 01:42:46 -0700 (PDT)","Date":"Thu, 13 May 2021 10:42:45 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Paul Elder ","Message-ID":"","References":"<20210512102541.722956-1-paul.elder@ideasonboard.com>\n\t<20210512102541.722956-4-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210512102541.722956-4-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 3/3] android: jpeg: post_processor:\n\tUse the new metadata functions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]