[{"id":16875,"web_url":"https://patchwork.libcamera.org/comment/16875/","msgid":"","date":"2021-05-10T23:51:45","subject":"Re: [libcamera-devel] [PATCH v6 5/6] ipa: raspberrypi: Add a Merge\n\tmethod to RPiController::Metadata","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Mon, May 10, 2021 at 10:58:14AM +0100, Naushir Patuck wrote:\n> Add a new Merge method to the Metadata class. This will merge all unique\n> key/value pairs from a source metadata map to the destination map.\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/controller/metadata.hpp | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/src/ipa/raspberrypi/controller/metadata.hpp b/src/ipa/raspberrypi/controller/metadata.hpp\n> index 3a97a5f5c502..fd6aac880bad 100644\n> --- a/src/ipa/raspberrypi/controller/metadata.hpp\n> +++ b/src/ipa/raspberrypi/controller/metadata.hpp\n> @@ -73,6 +73,12 @@ public:\n> \t\treturn *this;\n> \t}\n> \n> +\tvoid Merge(Metadata &other)\n> +\t{\n> +\t\tstd::scoped_lock lock(mutex_, other.mutex_);\n> +\t\tdata_.merge(other.data_);\n> +\t}\n> +\n> \ttemplate\n> \tT *GetLocked(std::string const &tag)\n> \t{","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DAA8BF839\n\tfor ;\n\tMon, 10 May 2021 23:51:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A9CB968911;\n\tTue, 11 May 2021 01:51:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E00E602B8\n\tfor ;\n\tTue, 11 May 2021 01:51:52 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 860676EF;\n\tTue, 11 May 2021 01:51:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZmyncS8e\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1620690711;\n\tbh=wX17d3LKh+QSVULBmUBn9Wp+JvvImdqi8nZ8gq2Q6Qo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZmyncS8eGMk4pK8Qua8k1ExNuGrmzeGQCv0668Iy9/klG8lgGqn0c06a+TEAatNS7\n\tPVqa5QEi271p2eSJiDT6A0wvRBy33gcsYi/37nm6lr4HacGHxUiw7Swdf4RmvJ1X1e\n\tcdYZX3NQhXdj3h3QkLRczUpYcF2mn2lIESc8nkWk=","Date":"Tue, 11 May 2021 02:51:45 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20210510095814.3732400-1-naush@raspberrypi.com>\n\t<20210510095814.3732400-6-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210510095814.3732400-6-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v6 5/6] ipa: raspberrypi: Add a Merge\n\tmethod to RPiController::Metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]