{"id":12232,"url":"https://patchwork.libcamera.org/api/patches/12232/?format=json","web_url":"https://patchwork.libcamera.org/patch/12232/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210510054242.2735473-1-hiroh@chromium.org>","date":"2021-05-10T05:42:41","name":"[libcamera-devel,v2,1/2] libcamera: pipeline: Remove unnecessary v4l2_controls.h includes","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c7f95888c6b35682d3ac1655cdc0743d4979b618","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12232/mbox/","series":[{"id":2014,"url":"https://patchwork.libcamera.org/api/series/2014/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2014","date":"2021-05-10T05:42:41","name":"[libcamera-devel,v2,1/2] libcamera: pipeline: Remove unnecessary v4l2_controls.h includes","version":2,"mbox":"https://patchwork.libcamera.org/series/2014/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12232/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12232/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67BF1BF831\n\tfor ;\n\tMon, 10 May 2021 05:42:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BA6FC6891B;\n\tMon, 10 May 2021 07:42:57 +0200 (CEST)","from mail-pl1-x632.google.com (mail-pl1-x632.google.com\n\t[IPv6:2607:f8b0:4864:20::632])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 64EC06153C\n\tfor ;\n\tMon, 10 May 2021 07:42:51 +0200 (CEST)","by mail-pl1-x632.google.com with SMTP id z18so4979498plg.8\n\tfor ;\n\tSun, 09 May 2021 22:42:51 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:5c5a:ef4c:8b48:6a4a])\n\tby smtp.gmail.com with ESMTPSA id\n\tr32sm10172723pgm.49.2021.05.09.22.42.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 09 May 2021 22:42:48 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"H8G1lJun\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=SOVC04RqmEW8Jt8jENnJcmigrGgeZAEDRA3axwT9+IU=;\n\tb=H8G1lJuncMz5EpSsMkSnl5wLUmxXSxzIT2rgxP22B7tgzT4ngPyBZ02cTh47+ttbiC\n\tJIrty1fI+Fsp5HFSDempmtvKDnzf7EDYHWGwIIZIaCbShKq5IUCRNI26NJKNgeTsjPbC\n\tonqcYZCut1PzDmNNlplfVwvJraEz6Zq0ieVMA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=SOVC04RqmEW8Jt8jENnJcmigrGgeZAEDRA3axwT9+IU=;\n\tb=ZIImh1UP4xh2j5turwfHYk7b5o6GT6sKJEzQa6v/yfIkIV9k2j5QXKOmA8aFB8UVrb\n\tDTQi7XB2H4ETQ2sVESHb75f7AYLootGpxXvu93H4QnkAgk1EvVmRiWoPtKNbLEWvSUnl\n\tB3XIXZhXCqseJ/lP4B4/xA6L3vonRjzZ+h2i7RZ65eOAFHNVLTDVYrXnK+fS9bXt9Pza\n\tR/ULH0587sgKwZl3Fy0uAviTlJ/XKX/cw38gtyF9VT6yyj9qzbjh1x6CzjX3ub15aZwI\n\taM9HE9Og7R1mAvZSGmR8U38qH2hLjL4FfRrRogS7GhYD5pEQa95YQlzFasWD1qQYYe0x\n\trI+Q==","X-Gm-Message-State":"AOAM531W713Sk57H/+UPd6b5mheIpnlWPA54sXOa3txibSGl2r/ipKCQ\n\tSnBkhUVTW5zk1fxXLz6q29IsqLwEy9R4OQ==","X-Google-Smtp-Source":"ABdhPJx+QtPMvuLoHIH0QJQ73w5btiFRvossq+DQUBIlqLvVgt0rzWsAvTjcIYT8nNL7l6brLLf3rg==","X-Received":"by 2002:a17:90a:fb97:: with SMTP id\n\tcp23mr38340669pjb.169.1620625369443; \n\tSun, 09 May 2021 22:42:49 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 10 May 2021 14:42:41 +0900","Message-Id":"<20210510054242.2735473-1-hiroh@chromium.org>","X-Mailer":"git-send-email 2.31.1.607.g51e8a6a459-goog","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 1/2] libcamera: pipeline: Remove\n\tunnecessary v4l2_controls.h includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"v4l2_controls.h is included in some places in pipeline codes.\nBut V4l2Control classes are not used there. This removes the\nredundant v4l2_controls.h includes.\n\nSigned-off-by: Hirokazu Honda \nReviewed-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 1 -\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 1 -\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 1 -\n src/libcamera/pipeline/vimc/vimc.cpp | 1 -\n 4 files changed, 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex ade8ffbd..411e70b7 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -28,7 +28,6 @@\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n #include \"libcamera/internal/utils.h\"\n-#include \"libcamera/internal/v4l2_controls.h\"\n \n #include \"cio2.h\"\n #include \"frames.h\"\ndiff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex b2256493..e485f25f 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -36,7 +36,6 @@\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n #include \"libcamera/internal/utils.h\"\n-#include \"libcamera/internal/v4l2_controls.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n \n #include \"dma_heaps.h\"\ndiff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex faa8d6b0..12a85b24 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -25,7 +25,6 @@\n #include \"libcamera/internal/pipeline_handler.h\"\n #include \"libcamera/internal/sysfs.h\"\n #include \"libcamera/internal/utils.h\"\n-#include \"libcamera/internal/v4l2_controls.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n \n namespace libcamera {\ndiff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex ce83dcaa..d89ab33a 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -30,7 +30,6 @@\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n #include \"libcamera/internal/utils.h\"\n-#include \"libcamera/internal/v4l2_controls.h\"\n #include \"libcamera/internal/v4l2_subdevice.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n \n","prefixes":["libcamera-devel","v2","1/2"]}