[{"id":16821,"web_url":"https://patchwork.libcamera.org/comment/16821/","msgid":"<20210507075650.s5vuvizotomy2feu@uno.localdomain>","date":"2021-05-07T07:56:50","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: Remove\n\tunnecessary v4l2_controls.h includes","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Hiro,\n a shorter subject might be more appropriate :)\n\nOn Fri, May 07, 2021 at 11:17:26AM +0900, Hirokazu Honda wrote:\n> v4l2_controls.h is includes in some places in pipeline codes.\n\nincludes->included\n\n> But V4l2Control classes are not used there. This removes the\n> redundant v4l2_controls.h includes.\n>\n> Signed-off-by: Hirokazu Honda \n\n\\o/\n\nHappy to see leftovers gone. The minors in commit messages can be\nchanged when applying.\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 1 -\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 1 -\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 1 -\n> src/libcamera/pipeline/vimc/vimc.cpp | 1 -\n> 4 files changed, 4 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 73306cea..e9fc41f4 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -28,7 +28,6 @@\n> #include \"libcamera/internal/media_device.h\"\n> #include \"libcamera/internal/pipeline_handler.h\"\n> #include \"libcamera/internal/utils.h\"\n> -#include \"libcamera/internal/v4l2_controls.h\"\n>\n> #include \"cio2.h\"\n> #include \"frames.h\"\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 2a917455..34d6044f 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -36,7 +36,6 @@\n> #include \"libcamera/internal/media_device.h\"\n> #include \"libcamera/internal/pipeline_handler.h\"\n> #include \"libcamera/internal/utils.h\"\n> -#include \"libcamera/internal/v4l2_controls.h\"\n> #include \"libcamera/internal/v4l2_videodevice.h\"\n>\n> #include \"dma_heaps.h\"\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index b6c6ade5..de1c36bf 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -25,7 +25,6 @@\n> #include \"libcamera/internal/pipeline_handler.h\"\n> #include \"libcamera/internal/sysfs.h\"\n> #include \"libcamera/internal/utils.h\"\n> -#include \"libcamera/internal/v4l2_controls.h\"\n> #include \"libcamera/internal/v4l2_videodevice.h\"\n>\n> namespace libcamera {\n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index 8f5f4ba3..c242efa3 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -30,7 +30,6 @@\n> #include \"libcamera/internal/media_device.h\"\n> #include \"libcamera/internal/pipeline_handler.h\"\n> #include \"libcamera/internal/utils.h\"\n> -#include \"libcamera/internal/v4l2_controls.h\"\n> #include \"libcamera/internal/v4l2_subdevice.h\"\n> #include \"libcamera/internal/v4l2_videodevice.h\"\n>\n> --\n> 2.31.1.607.g51e8a6a459-goog\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5BF18BF829\n\tfor ;\n\tFri, 7 May 2021 07:56:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD3906890C;\n\tFri, 7 May 2021 09:56:08 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4E1B602BB\n\tfor ;\n\tFri, 7 May 2021 09:56:07 +0200 (CEST)","from uno.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 63D1BC0009;\n\tFri, 7 May 2021 07:56:06 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","Date":"Fri, 7 May 2021 09:56:50 +0200","From":"Jacopo Mondi ","To":"Hirokazu Honda ","Message-ID":"<20210507075650.s5vuvizotomy2feu@uno.localdomain>","References":"<20210507021727.1848611-1-hiroh@chromium.org>\n\t<20210507021727.1848611-2-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210507021727.1848611-2-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: Remove\n\tunnecessary v4l2_controls.h includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]