[{"id":17007,"web_url":"https://patchwork.libcamera.org/comment/17007/","msgid":"<20210518122727.hiphogi43omjwn6b@uno.localdomain>","date":"2021-05-18T12:27:27","subject":"Re: [libcamera-devel] [PATCH v4 5/6] libcamera: pipeline: ipu3:\n\tReport available sensor test pattern mode","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Hiro,\n\nOn Thu, May 06, 2021 at 04:54:48PM +0900, Hirokazu Honda wrote:\n> PipelineHandlerIPU3 gets available test pattern modes of the\n> sensor device and reports them to a client.\n>\n> Signed-off-by: Hirokazu Honda \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 73306cea..b4d4b97d 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -891,6 +891,16 @@ int PipelineHandlerIPU3::initControls(IPU3CameraData *data)\n> \tControlInfoMap::Map controls = IPU3Controls;\n> \tconst ControlInfoMap &sensorControls = sensor->controls();\n>\n> +\tif (!sensorInfo.testPatternModes.empty()) {\n\nOnce this is retrieved through an ad-hoc method from CameraSensor\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> +\t\tstd::vector values;\n> +\t\tvalues.reserve(sensorInfo.testPatternModes.size());\n> +\n> +\t\tfor (int32_t pattern : sensorInfo.testPatternModes)\n> +\t\t\tvalues.emplace_back(pattern);\n> +\n> +\t\tcontrols[&controls::draft::TestPatternMode] = ControlInfo(values);\n> +\t}\n> +\n> \t/*\n> \t * Compute exposure time limits.\n> \t *\n> --\n> 2.31.1.607.g51e8a6a459-goog\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51E1AC31FB\n\tfor ;\n\tTue, 18 May 2021 12:26:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B0F7F6891C;\n\tTue, 18 May 2021 14:26:43 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 72DB468918\n\tfor ;\n\tTue, 18 May 2021 14:26:42 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id E8564200006;\n\tTue, 18 May 2021 12:26:41 +0000 (UTC)"],"Date":"Tue, 18 May 2021 14:27:27 +0200","From":"Jacopo Mondi ","To":"Hirokazu Honda ","Message-ID":"<20210518122727.hiphogi43omjwn6b@uno.localdomain>","References":"<20210506075449.1761752-1-hiroh@chromium.org>\n\t<20210506075449.1761752-6-hiroh@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210506075449.1761752-6-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v4 5/6] libcamera: pipeline: ipu3:\n\tReport available sensor test pattern mode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]