[{"id":171,"web_url":"https://patchwork.libcamera.org/comment/171/","msgid":"<20190102093152.zinqgrlahxgvgi53@uno.localdomain>","date":"2019-01-02T09:31:52","subject":"Re: [libcamera-devel] [PATCH 1/5] test: media_device: Move test\n\tdefinition","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n   thanks, I was not sure what the policy was,\n\nOn Tue, Jan 01, 2019 at 09:29:43PM +0000, Kieran Bingham wrote:\n> The test definition for the media_device_test executable should be\n> located with the exectuable definition.\n>\n> Move it to the meson.build of that test suite subdir.\n>\n\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> ---\n>  test/media_device/meson.build | 2 ++\n>  test/meson.build              | 1 -\n>  2 files changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/test/media_device/meson.build b/test/media_device/meson.build\n> index a73644a08d6c..a7ebed102e24 100644\n> --- a/test/media_device/meson.build\n> +++ b/test/media_device/meson.build\n> @@ -1,3 +1,5 @@\n>  media_device_test = executable('media_device_test', 'media_device_test.cpp',\n>                                 link_with : test_libraries,\n>                                 include_directories : test_includes_internal)\n> +\n> +test('Media Device Test', media_device_test)\n> diff --git a/test/meson.build b/test/meson.build\n> index aabe79ddc442..3b7591ad9204 100644\n> --- a/test/meson.build\n> +++ b/test/meson.build\n> @@ -24,4 +24,3 @@ subdir('media_device')\n>\n>  test('Initialisation test', test_init)\n>  test('List Camera API tests', list)\n> -test('Media Device Test', media_device_test)\n> --\n> 2.17.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4134360B30\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  2 Jan 2019 10:31:49 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id C94861BF214;\n\tWed,  2 Jan 2019 09:31:48 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 2 Jan 2019 10:31:52 +0100","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190102093152.zinqgrlahxgvgi53@uno.localdomain>","References":"<20190101212947.28098-1-kieran.bingham@ideasonboard.com>\n\t<20190101212947.28098-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"5tq33ep5n6l2upal\"","Content-Disposition":"inline","In-Reply-To":"<20190101212947.28098-2-kieran.bingham@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 1/5] test: media_device: Move test\n\tdefinition","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 02 Jan 2019 09:31:49 -0000"}}]