[{"id":16781,"web_url":"https://patchwork.libcamera.org/comment/16781/","msgid":"","date":"2021-05-06T05:03:15","subject":"Re: [libcamera-devel] [PATCH v5 13/17] libcamera: raspberrypi: Do\n\tnot over-write metadata","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Jacopo, thank you for the patch.\n\nOn Mon, May 3, 2021 at 7:41 PM Jacopo Mondi wrote:\n\n> When a Request is completed upon receiving the IPA produced metadata,\n> the metadata associated with the Request are over-written, deleting\n> the information set at output buffer completion, such as the\n> SensorTimestamp.\n>\n> This commit applies to the RaspberryPi pipeline handler the same change\n> applied to IPU3 in commit 2ee3dd57e2fc (\"libcamera: ipu3: Merge IPA\n> metadata controls\").\n>\n> Reviewed-by: Naushir Patuck \n> Signed-off-by: Jacopo Mondi \n>\n\nReviewed-by: Hirokazu Honda \n\n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 2a917455500f..91f44f6844b3 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1312,9 +1312,9 @@ void RPiCameraData::statsMetadataComplete(uint32_t\n> bufferId, const ControlList &\n>\n> handleStreamBuffer(buffer, &isp_[Isp::Stats]);\n>\n> - /* Fill the Request metadata buffer with what the IPA has provided\n> */\n> + /* Add to the Request metadata buffer what the IPA has provided. */\n> Request *request = requestQueue_.front();\n> - request->metadata() = controls;\n> + request->metadata().merge(controls);\n>\n> /*\n> * Also update the ScalerCrop in the metadata with what we actually\n> --\n> 2.31.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7BF80BDE79\n\tfor ;\n\tThu, 6 May 2021 05:03:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A58968911;\n\tThu, 6 May 2021 07:03:27 +0200 (CEST)","from mail-ed1-x534.google.com (mail-ed1-x534.google.com\n\t[IPv6:2a00:1450:4864:20::534])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0BEEB688E5\n\tfor ;\n\tThu, 6 May 2021 07:03:26 +0200 (CEST)","by mail-ed1-x534.google.com with SMTP id n25so4632855edr.5\n\tfor ;\n\tWed, 05 May 2021 22:03:26 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"oIfciTMm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=MdH3tjFxPFXXKbd8Ena1i2RS6Y3eCtgOFEa/aKV+n8w=;\n\tb=oIfciTMmkHZxRH2eOfYqWL/aTHVtdLPZ3N+817IgLeIKb49Ia0Kwu+bdGDlaKWQUDM\n\tE8DfBiWlckcdKsaeoTs/CN1nLby/TJRMmfQd6fiMbJdF48K0feo5QdhunEOd+hwaYGa5\n\tj5hmwIevFHqetF3sWoFY/N83kj3HxUnz4RteM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=MdH3tjFxPFXXKbd8Ena1i2RS6Y3eCtgOFEa/aKV+n8w=;\n\tb=BR7YjaSN3lEoOHxUK+0CCYinOq9Gj0BIkz7MNUHZUfniyEfoQl7xvfM1/CBLr8Hxsv\n\t9wgtAXqlHEhAjpFyLyXqB9NRBOfA/MpLAAxoWSHwKXmW2cj8UL5IChtZfURCo5NJeY0G\n\tIkm7V2jOHrVLYgFhLCUNuyjh/KJBA0DDsOXkBn8kPgSyaPj5wAR/gA7lW7jA9AeMuib2\n\tXKtufy6LJyyTGDhDBkomtMyJm14ezituemyJTFTuK8TamVvvz4s92/cW3XkwHqlaKtwT\n\tg2cjcHEmEqbhoe0mPCt17hIOH+zYZfSoHUu9nQAErbqKtm88dvVk5pw7UEXPqxY3w5Iq\n\tai8A==","X-Gm-Message-State":"AOAM530t+M1vSrrgV3I0XQEbWKHth85odxv2w5k5rz0qWs3mRs5A5oEv\n\tDzdAnnssyzVoXIrqXwoHckVouskr7WW2m7WG1LD8xSUAloc=","X-Google-Smtp-Source":"ABdhPJzYd0CVwjnVFg8KNzanwl/FCZ2NCnuRUko2zaxDD19wvL0jelyu8YbAYLj5SxZTFYG0pY7uSUITA69D0ZnhQww=","X-Received":"by 2002:aa7:d8cb:: with SMTP id k11mr2815974eds.73.1620277405713;\n\tWed, 05 May 2021 22:03:25 -0700 (PDT)","MIME-Version":"1.0","References":"<20210503104152.34048-1-jacopo@jmondi.org>\n\t<20210503104152.34048-14-jacopo@jmondi.org>","In-Reply-To":"<20210503104152.34048-14-jacopo@jmondi.org>","From":"Hirokazu Honda ","Date":"Thu, 6 May 2021 14:03:15 +0900","Message-ID":"","To":"Jacopo Mondi ","Subject":"Re: [libcamera-devel] [PATCH v5 13/17] libcamera: raspberrypi: Do\n\tnot over-write metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============7243157476301201054==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]