[{"id":1612,"web_url":"https://patchwork.libcamera.org/comment/1612/","msgid":"<20190518153350.GC25081@bigcity.dyn.berto.se>","date":"2019-05-18T15:33:51","subject":"Re: [libcamera-devel] [PATCH/RFC 01/12] libcamera: camera: Fix\n\tstd::ostringstream initialisation","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-05-18 02:06:10 +0300, Laurent Pinchart wrote:\n> We use the std::ostringstream class to generate log messages in the\n> Camera class. The stream is initialised with initial content, but is not\n> opened without seeking to the end, which results in the content being\n> overwritten immediately. Fix it by opening the stream with\n> std::ios_base::ate.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/camera.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index fbc66dedba51..1a21acac9899 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -560,7 +560,7 @@ Camera::streamConfiguration(const std::vector &usages)\n> \n> \tCameraConfiguration config = pipe_->streamConfiguration(this, usages);\n> \n> -\tstd::ostringstream msg(\"streams configuration:\");\n> +\tstd::ostringstream msg(\"streams configuration:\", std::ios_base::ate);\n> \tunsigned int index = 0;\n> \n> \tfor (Stream *stream : config) {\n> @@ -614,7 +614,7 @@ int Camera::configureStreams(const CameraConfiguration &config)\n> \t\treturn -EINVAL;\n> \t}\n> \n> -\tstd::ostringstream msg(\"configuring streams:\");\n> +\tstd::ostringstream msg(\"configuring streams:\", std::ios_base::ate);\n> \tunsigned int index = 0;\n> \n> \tfor (Stream *stream : config) {\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x132.google.com (mail-lf1-x132.google.com\n\t[IPv6:2a00:1450:4864:20::132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E3A360C02\n\tfor ;\n\tSat, 18 May 2019 17:33:53 +0200 (CEST)","by mail-lf1-x132.google.com with SMTP id n22so7327314lfe.12\n\tfor ;\n\tSat, 18 May 2019 08:33:53 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\to7sm2426201ljh.57.2019.05.18.08.33.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSat, 18 May 2019 08:33:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=pcmJbVLokQUWiz+hq8cHgEB2RCEyERN8uOHCmtBoTPw=;\n\tb=HokEP8AdGcgj2WwveXpQCrDT4XZQTJ+5nfyuidEbnn1L0ZPCL1VLP91pzwvsiMjDcd\n\tQbKJRhYppU1Dk030waNjc2yAeY3FR7soFabnUUeRgggKWg+8BYmfnoS8xfB/XY800aE2\n\t9M97aAbRcnJGIt+jjx+djqGEHIb7PDd2b7m/MOPSiAtlN+r1Z5DclKbeKsox2jt+nNmJ\n\t50L3yCMAqGC8xFGtNfI69Udqxwxa70lxtrKaqdFC56Lc8kSAPgTrF79TZHQLTklaW4d4\n\tpkaAj2MOaYdBEmukZ9TE7NF/Sm2bIyZvf0fn/iuRfexXzruqgnUH7ARrx/84++vYG9pU\n\tlW6g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=pcmJbVLokQUWiz+hq8cHgEB2RCEyERN8uOHCmtBoTPw=;\n\tb=kUGxUsQbByHP3MFXCtRoO7QJwSBj6Lcja22cx1ajnjYU6b4Es5qilrPi+VdGZGmreH\n\ttaalsSS3FTXqX2BTNpHKY6ovl9Cwvv02AokOB5fRAT2YUZj31FwSEP9HwQjM4kgbFKq1\n\tu3rEF56jxpqqVrl3dyZh9XjJ+MDrjciyxhjJqGFUnWNBqjKVhvv189dAsssZPKW2VCa6\n\tZjnHTXIBMCVHAC7BsDvzIPTuwbdDptdKGlZKtPZA+j3+DCJQfYpvYnQZ1unaUc+efQjg\n\tiKgrWvv1Sf0fEZgp8iddKfOVjuWJ95WG06GabVi8pY56OMA8IpOarfgID3jLO8lXJ7lw\n\tuAGg==","X-Gm-Message-State":"APjAAAXjO6tQJ4460YtpErprkMtkSmWHFooCdJyXhySjMb28N8TqFeZ5\n\t8EVUogglkusghAoqHkhmAGY41g==","X-Google-Smtp-Source":"APXvYqwaluZe8785M2oZZZcN2XWQ1yUxYRUZXVf2uwhrrMtEbmBgz84xpa6m3O1WVRRPF8723rEVPw==","X-Received":"by 2002:a19:f817:: with SMTP id\n\ta23mr3496204lff.123.1558193632756; \n\tSat, 18 May 2019 08:33:52 -0700 (PDT)","Date":"Sat, 18 May 2019 17:33:51 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190518153350.GC25081@bigcity.dyn.berto.se>","References":"<20190517230621.24668-1-laurent.pinchart@ideasonboard.com>\n\t<20190517230621.24668-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190517230621.24668-2-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH/RFC 01/12] libcamera: camera: Fix\n\tstd::ostringstream initialisation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 18 May 2019 15:33:53 -0000"}},{"id":1627,"web_url":"https://patchwork.libcamera.org/comment/1627/","msgid":"<5cfabdb2-bf20-780f-0ede-4fe1ed3f6196@ideasonboard.com>","date":"2019-05-19T10:39:42","subject":"Re: [libcamera-devel] [PATCH/RFC 01/12] libcamera: camera: Fix\n\tstd::ostringstream initialisation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 18/05/2019 00:06, Laurent Pinchart wrote:\n> We use the std::ostringstream class to generate log messages in the\n> Camera class. The stream is initialised with initial content, but is not\n> opened without seeking to the end, which results in the content being\n> overwritten immediately. Fix it by opening the stream with\n> std::ios_base::ate.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/camera.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index fbc66dedba51..1a21acac9899 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -560,7 +560,7 @@ Camera::streamConfiguration(const std::vector &usages)\n> \n> \tCameraConfiguration config = pipe_->streamConfiguration(this, usages);\n> \n> -\tstd::ostringstream msg(\"streams configuration:\");\n> +\tstd::ostringstream msg(\"streams configuration:\", std::ios_base::ate);\n\n> \tunsigned int index = 0;\n> \n> \tfor (Stream *stream : config) {\n> @@ -614,7 +614,7 @@ int Camera::configureStreams(const CameraConfiguration &config)\n> \t\treturn -EINVAL;\n> \t}\n> \n> -\tstd::ostringstream msg(\"configuring streams:\");\n> +\tstd::ostringstream msg(\"configuring streams:\", std::ios_base::ate);\n> \tunsigned int index = 0;\n> \n> \tfor (Stream *stream : config) {\n\nShould all of this be moved to the CameraConfiguration class as a\ntoString() or such? or will this be the only place we print a\nCameraConfiguration...\n\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 848D160103\n\tfor ;\n\tSun, 19 May 2019 12:39:45 +0200 (CEST)","from [192.168.0.26]\n\t(cpc139364-aztw33-2-0-cust1325.18-1.cable.virginm.net\n\t[94.173.229.46])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CFDAF443;\n\tSun, 19 May 2019 12:39:44 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1558262385;\n\tbh=aI/1ncIrQZKxdV+s9n7b6pqC0uGeIh+7mS+6UabjCZM=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=NtMZSG/P7EVwVwD2uSKdZrGi1L5tYsWymIminEFiFJo+izqdwE4ctOEeAus+clV/T\n\t4DQ2CkebXUddcW62/GQt+lybv4yqmfXf/rSNPkUM12DXHnVG0eqMvHWt/FhiKZOq1P\n\t1omRqTB4o+5xG2iMWQXE10qyh00iXAQA9afBfVuk=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190517230621.24668-1-laurent.pinchart@ideasonboard.com>\n\t<20190517230621.24668-2-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<5cfabdb2-bf20-780f-0ede-4fe1ed3f6196@ideasonboard.com>","Date":"Sun, 19 May 2019 11:39:42 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.6.1","MIME-Version":"1.0","In-Reply-To":"<20190517230621.24668-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH/RFC 01/12] libcamera: camera: Fix\n\tstd::ostringstream initialisation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 19 May 2019 10:39:45 -0000"}},{"id":1628,"web_url":"https://patchwork.libcamera.org/comment/1628/","msgid":"<20190519145022.GA5213@pendragon.ideasonboard.com>","date":"2019-05-19T14:50:22","subject":"Re: [libcamera-devel] [PATCH/RFC 01/12] libcamera: camera: Fix\n\tstd::ostringstream initialisation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Sun, May 19, 2019 at 11:39:42AM +0100, Kieran Bingham wrote:\n> On 18/05/2019 00:06, Laurent Pinchart wrote:\n> > We use the std::ostringstream class to generate log messages in the\n> > Camera class. The stream is initialised with initial content, but is not\n> > opened without seeking to the end, which results in the content being\n> > overwritten immediately. Fix it by opening the stream with\n> > std::ios_base::ate.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/camera.cpp | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> > index fbc66dedba51..1a21acac9899 100644\n> > --- a/src/libcamera/camera.cpp\n> > +++ b/src/libcamera/camera.cpp\n> > @@ -560,7 +560,7 @@ Camera::streamConfiguration(const std::vector &usages)\n> > \n> > \tCameraConfiguration config = pipe_->streamConfiguration(this, usages);\n> > \n> > -\tstd::ostringstream msg(\"streams configuration:\");\n> > +\tstd::ostringstream msg(\"streams configuration:\", std::ios_base::ate);\n> \n> > \tunsigned int index = 0;\n> > \n> > \tfor (Stream *stream : config) {\n> > @@ -614,7 +614,7 @@ int Camera::configureStreams(const CameraConfiguration &config)\n> > \t\treturn -EINVAL;\n> > \t}\n> > \n> > -\tstd::ostringstream msg(\"configuring streams:\");\n> > +\tstd::ostringstream msg(\"configuring streams:\", std::ios_base::ate);\n> > \tunsigned int index = 0;\n> > \n> > \tfor (Stream *stream : config) {\n> \n> Should all of this be moved to the CameraConfiguration class as a\n> toString() or such? or will this be the only place we print a\n> CameraConfiguration...\n\nIf we end up printing it somewhere else then a toString() method would\nbe useful, I agree. When objects get more complex, however, I'm not sure\nif we can come up with a single string representation that would fit all\nneeds, but we can try.","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 94E7E60E4C\n\tfor ;\n\tSun, 19 May 2019 16:50:39 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB231443;\n\tSun, 19 May 2019 16:50:38 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1558277439;\n\tbh=LEo3I10tGHIXUorQkTQ/eNYBKOKhU+RanGletXwLykY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=H4bEyAbvtN3iNqizvbjoiEsw6xriCdnHcYIzU9t6tz5PuwMqIG1bskz+A3USaA4ge\n\trVPZqJ6v/PGkAoX1d+pGY+8qXrtwWUHEMUIaRgr7lY76TxUyxL1Z2tOj9bKTkTGr4F\n\tyAxuGgsfTZsmzBShTV9mzXJ0BVMoBhpU9I6TqS9k=","Date":"Sun, 19 May 2019 17:50:22 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190519145022.GA5213@pendragon.ideasonboard.com>","References":"<20190517230621.24668-1-laurent.pinchart@ideasonboard.com>\n\t<20190517230621.24668-2-laurent.pinchart@ideasonboard.com>\n\t<5cfabdb2-bf20-780f-0ede-4fe1ed3f6196@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<5cfabdb2-bf20-780f-0ede-4fe1ed3f6196@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH/RFC 01/12] libcamera: camera: Fix\n\tstd::ostringstream initialisation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 19 May 2019 14:50:39 -0000"}}]