{"id":12178,"url":"https://patchwork.libcamera.org/api/patches/12178/?format=json","web_url":"https://patchwork.libcamera.org/patch/12178/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210503104152.34048-10-jacopo@jmondi.org>","date":"2021-05-03T10:41:44","name":"[libcamera-devel,v5,09/17] libcamera: rkisp1: Report sensor timestamp","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"dbc1826f2b36a7eb8e8e1aeabe1e470272583b72","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12178/mbox/","series":[{"id":1994,"url":"https://patchwork.libcamera.org/api/series/1994/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1994","date":"2021-05-03T10:41:35","name":"Support SensorTimestamp metadata","version":5,"mbox":"https://patchwork.libcamera.org/series/1994/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12178/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12178/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3515ABDE78\n\tfor ;\n\tMon, 3 May 2021 10:41:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4C0368923;\n\tMon, 3 May 2021 12:41:20 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33E6C68927\n\tfor ;\n\tMon, 3 May 2021 12:41:15 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id ED06CFF805\n\tfor ;\n\tMon, 3 May 2021 10:41:14 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 3 May 2021 12:41:44 +0200","Message-Id":"<20210503104152.34048-10-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210503104152.34048-1-jacopo@jmondi.org>","References":"<20210503104152.34048-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 09/17] libcamera: rkisp1: Report sensor\n\ttimestamp","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Report the sensor's timestamp in the Request metadata using the\ncompleted buffer timestamp.\n\nThe buffer's timestamp is recorded at DMA-transfer time, and it does not\ntheoretically matches the 'start of exposure' definition. Record this with\na \\todo entry.\n\nReviewed-by: Hirokazu Honda \nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 26f708242523..cee6d85fac47 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -1070,6 +1070,15 @@ void PipelineHandlerRkISP1::bufferReady(FrameBuffer *buffer)\n {\n \tRequest *request = buffer->request();\n \n+\t/*\n+\t * Record the sensor's timestamp in the request metadata.\n+\t *\n+\t * \\todo The sensor timestamp should be better estimated by connecting\n+\t * to the V4L2Device::frameStart signal.\n+\t */\n+\trequest->metadata().set(controls::SensorTimestamp,\n+\t\t\t\tbuffer->metadata().timestamp);\n+\n \tcompleteBuffer(request, buffer);\n \ttryCompleteRequest(request);\n }\n","prefixes":["libcamera-devel","v5","09/17"]}