[{"id":16752,"web_url":"https://patchwork.libcamera.org/comment/16752/","msgid":"<6b3f5cb9-7f15-5b20-f297-315b60e0f499@ideasonboard.com>","date":"2021-05-04T08:13:53","subject":"Re: [libcamera-devel] [PATCH v5 06/17] libcamera: ipu3: Merge IPA\n\tmetadata controls","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 03/05/2021 11:41, Jacopo Mondi wrote:\n> When a Request is completed upon receiving the IPA produced metadata,\n> they should be merged with the metadata set by the pipeline handler\n> before reporting them to applications.\n> \n> Use ControlList::merge() to collect the IPA produced controls to the\n> request's metadata.\n> \n> Signed-off-by: Jacopo Mondi \n\nAha great, thank you - Good to have consistency here, even if we haven't\nyet started adding metadata to this ipa.\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +----\n> 1 file changed, 1 insertion(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 88b7bd1e52c3..ade8ffbddb0e 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -1190,11 +1190,8 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n> \t\tif (!info)\n> \t\t\tbreak;\n> \n> -\t\t/*\n> -\t\t * \\todo Parse the value of the controls returned by the IPA\n> -\t\t * in action.controls to register additional metadata.\n> -\t\t */\n> \t\tRequest *request = info->request;\n> +\t\trequest->metadata().merge(action.controls);\n> \n> \t\tinfo->metadataProcessed = true;\n> \t\tif (frameInfos_.tryComplete(info))\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 832A2BDE79\n\tfor ;\n\tTue, 4 May 2021 08:13:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 45DFD68911;\n\tTue, 4 May 2021 10:13:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 69AAD6890C\n\tfor ;\n\tTue, 4 May 2021 10:13:57 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EEAD93F2;\n\tTue, 4 May 2021 10:13:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UTO0Ds9P\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1620116037;\n\tbh=8BAyChv3Xzg6iUlzEjbBs3gIwFFF+Mf5kFyhjROpesY=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=UTO0Ds9Pv8YOOd8j7EpiBPlMkbArdyWdwy6ivjGw0hdVMxDKGSAIAfYi8HV4qftEM\n\tu59OgOSupsF/IyzS/1ixXzHF2rl2CgzD9lN0TfB9FZe4z9TiCuTsXVpXu2CqqROqLj\n\tuDxXXFR8AxoeiWTH8D8Zbfq1tMSF3fXNzXM0R7SE=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20210503104152.34048-1-jacopo@jmondi.org>\n\t<20210503104152.34048-7-jacopo@jmondi.org>","From":"Kieran Bingham ","Organization":"Ideas on Board","Message-ID":"<6b3f5cb9-7f15-5b20-f297-315b60e0f499@ideasonboard.com>","Date":"Tue, 4 May 2021 09:13:53 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"<20210503104152.34048-7-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v5 06/17] libcamera: ipu3: Merge IPA\n\tmetadata controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16780,"web_url":"https://patchwork.libcamera.org/comment/16780/","msgid":"","date":"2021-05-06T05:00:36","subject":"Re: [libcamera-devel] [PATCH v5 06/17] libcamera: ipu3: Merge IPA\n\tmetadata controls","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Jacopo, thank you for the patch.\n\nOn Tue, May 4, 2021 at 5:13 PM Kieran Bingham <\nkieran.bingham@ideasonboard.com> wrote:\n\n> Hi Jacopo,\n>\n> On 03/05/2021 11:41, Jacopo Mondi wrote:\n> > When a Request is completed upon receiving the IPA produced metadata,\n> > they should be merged with the metadata set by the pipeline handler\n> > before reporting them to applications.\n> >\n> > Use ControlList::merge() to collect the IPA produced controls to the\n> > request's metadata.\n> >\n> > Signed-off-by: Jacopo Mondi \n>\n> Aha great, thank you - Good to have consistency here, even if we haven't\n> yet started adding metadata to this ipa.\n>\n> Reviewed-by: Kieran Bingham \n>\n> > ---\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +----\n> > 1 file changed, 1 insertion(+), 4 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index 88b7bd1e52c3..ade8ffbddb0e 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -1190,11 +1190,8 @@ void IPU3CameraData::queueFrameAction(unsigned\n> int id,\n> > if (!info)\n> > break;\n> >\n> > - /*\n> > - * \\todo Parse the value of the controls returned by the\n> IPA\n> > - * in action.controls to register additional metadata.\n> > - */\n> > Request *request = info->request;\n> > + request->metadata().merge(action.controls);\n> >\n> > info->metadataProcessed = true;\n> > if (frameInfos_.tryComplete(info))\n> >\n>\n>\nReviewed-by: Hirokazu Honda \n\n\n> --\n> Regards\n> --\n> Kieran\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3E34BDE7D\n\tfor ;\n\tThu, 6 May 2021 05:00:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 742A568911;\n\tThu, 6 May 2021 07:00:49 +0200 (CEST)","from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com\n\t[IPv6:2a00:1450:4864:20::62e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 55A1C688E5\n\tfor ;\n\tThu, 6 May 2021 07:00:47 +0200 (CEST)","by mail-ej1-x62e.google.com with SMTP id l4so6274346ejc.10\n\tfor ;\n\tWed, 05 May 2021 22:00:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"ARueYoZq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=mktcC5Ivh+WskfrTJsOm0luXC5DuFcLemAIGAZ19Ays=;\n\tb=ARueYoZqni3LlfFeezZYz0X8jVmi7lehW2BLhN9En8ASkkGgWmgwOR+TPnrgmBJfyO\n\tEhykv/+RrYTx2Eo6nvXWz9EusOP2bfj4fTmOzzleTYRqtOefIW0j6Pz2HgZCLmejuMev\n\tSg62ZW+FZPorbyVRpk4QrIENzqdtXpaUvkmVE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=mktcC5Ivh+WskfrTJsOm0luXC5DuFcLemAIGAZ19Ays=;\n\tb=msTCf7QLv/K69nd8InLzNHPUTIeF7rCP3PEIPsM7PA/8fMDtlPrcWlqsYUDQA6Lu85\n\tOFLf6OdlBPhFBCxmbX7kF88Yu79Ve6iEOT9EUBc8hiVRukQ1uDbCTbFhOd2axmOSkNhm\n\trJpwqd9sl7gc1b+K4MnhP3EIDjulNv4lq3f9NoedEf19LKU8hyW2Sp94FGNA4zD018sP\n\txGfSbPk4ZtPPDCcaGvn3CVYpf+lZJ5+injyl75Bp+eZ9yA9VZs7aXlkjBQE6vaxIeuuu\n\trSqT3M6nHck3nzc2ZltteAsyBUQMaNZpdRL+2gA9SE4YkfiBeFg/mrMOh4RG0pmwhWD1\n\tRmGw==","X-Gm-Message-State":"AOAM532pxpcpAOEfNjF4fJ2lwVYzVYWDPGp92JDy8h5p8wRoPRBHbqij\n\tq8MHK+Mt83Cv7s+nVrrRzkfU86Xc2yOGyTTqPOSVTg==","X-Google-Smtp-Source":"ABdhPJyllCWXUZQrZSI72OQxvo1pVPExzdqD7pBUWT5/Z3bozv5OWusaCCU1FUyvO7bX9LcWOB4gjiLLqY1UV19LeP8=","X-Received":"by 2002:a17:907:209b:: with SMTP id\n\tpv27mr2334370ejb.475.1620277246923; \n\tWed, 05 May 2021 22:00:46 -0700 (PDT)","MIME-Version":"1.0","References":"<20210503104152.34048-1-jacopo@jmondi.org>\n\t<20210503104152.34048-7-jacopo@jmondi.org>\n\t<6b3f5cb9-7f15-5b20-f297-315b60e0f499@ideasonboard.com>","In-Reply-To":"<6b3f5cb9-7f15-5b20-f297-315b60e0f499@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Thu, 6 May 2021 14:00:36 +0900","Message-ID":"","To":"Kieran Bingham ","Subject":"Re: [libcamera-devel] [PATCH v5 06/17] libcamera: ipu3: Merge IPA\n\tmetadata controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============2819906618794169166==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16791,"web_url":"https://patchwork.libcamera.org/comment/16791/","msgid":"","date":"2021-05-06T07:05:44","subject":"Re: [libcamera-devel] [PATCH v5 06/17] libcamera: ipu3: Merge IPA\n\tmetadata controls","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2021-05-03 12:41:41 +0200, Jacopo Mondi wrote:\n> When a Request is completed upon receiving the IPA produced metadata,\n> they should be merged with the metadata set by the pipeline handler\n> before reporting them to applications.\n> \n> Use ControlList::merge() to collect the IPA produced controls to the\n> request's metadata.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +----\n> 1 file changed, 1 insertion(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 88b7bd1e52c3..ade8ffbddb0e 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -1190,11 +1190,8 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n> \t\tif (!info)\n> \t\t\tbreak;\n> \n> -\t\t/*\n> -\t\t * \\todo Parse the value of the controls returned by the IPA\n> -\t\t * in action.controls to register additional metadata.\n> -\t\t */\n> \t\tRequest *request = info->request;\n> +\t\trequest->metadata().merge(action.controls);\n> \n> \t\tinfo->metadataProcessed = true;\n> \t\tif (frameInfos_.tryComplete(info))\n> -- \n> 2.31.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D6461BF81D\n\tfor ;\n\tThu, 6 May 2021 07:05:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4FAF468918;\n\tThu, 6 May 2021 09:05:49 +0200 (CEST)","from mail-lj1-x230.google.com (mail-lj1-x230.google.com\n\t[IPv6:2a00:1450:4864:20::230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 29CC868909\n\tfor ;\n\tThu, 6 May 2021 09:05:48 +0200 (CEST)","by mail-lj1-x230.google.com with SMTP id b21so5698145ljf.11\n\tfor ;\n\tThu, 06 May 2021 00:05:48 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tw15sm567474ljm.76.2021.05.06.00.05.45\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 06 May 2021 00:05:45 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"JhRs5s6h\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=N3fQImSzugFcRfp+c5W96YD1VueLYDkIZqGbLWwSh/E=;\n\tb=JhRs5s6hsiLRS320Ars3x5ca/QEi3hRq1wFvzBkmrBtx400jNwK5/n3tUg/ZqNkYm6\n\t6CUZd8KA+nljD2gWz2KEoYtl11GfOvrdifdiipvXSbo+jf7ZvN/1gPCRUGyT11m/9FFF\n\tuc4xJiYYqwPg3stMOGGWRggf0C/n+O2IVFztlaq8pSVC703SDRtNPTfELNjf5rae4541\n\tDqRkSpOpR6Uo0oAJy4dIltSlzUk/aDF0f9/jcklNp8LhC5gCQelGOMDxFnUYOM+UdEto\n\t4vLRSwQxI/PXj/8BsjVOgPLFHgftXTkoGUK8byZOWVrFOk6ud+YveXBNAwy2FEQTuzpj\n\tZ2gA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=N3fQImSzugFcRfp+c5W96YD1VueLYDkIZqGbLWwSh/E=;\n\tb=kFBzxpc3HalKEaLVIZV+gVIMxzyCyaC4A3uMbtHH4PrVzFnzHZoqLU1ZCLgF94apyK\n\t8FW/r4lkyhQnKIBF+f/MzjxlrPHDQ2WuZ+6oKUoyCdBpauprv67mI0yxU49EDHEN+GjF\n\tp94grVVySbUZfj3H+0EgDRmAdfKNMi+G27ylp3wq8OlFwThgSV+y/0siZoXSOqB0XWvw\n\tpbxHI3Zkeicz66cO5WVSkUdagyTeGZuVlcyTjzkY2xEl7C2Ll8UBCOgGgdNA9VwnuOPX\n\tBavzqeyqb3PKHIz9Ce/mVS6xy0rFd5GlUfOsAHaBlN6iOIABR5aOCtNp9Dca9LH4WhXB\n\tM+6g==","X-Gm-Message-State":"AOAM532O5yn9Swj1aoJQUxWfF7uR3cgOyCZDPDzbHUxOQd4jHq43zpXR\n\t1WQSNJmQ3MwZNaE2AyggH7cX0A==","X-Google-Smtp-Source":"ABdhPJyPgo4LzyRbmQwPgcsPIDkXFrUlaihn8PyBNYYThI/8Syw/GP/Z6E3GvENmWHJOcDcpK4U7hA==","X-Received":"by 2002:a2e:898c:: with SMTP id\n\tc12mr2071237lji.431.1620284747347; \n\tThu, 06 May 2021 00:05:47 -0700 (PDT)","Date":"Thu, 6 May 2021 09:05:44 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210503104152.34048-1-jacopo@jmondi.org>\n\t<20210503104152.34048-7-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210503104152.34048-7-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v5 06/17] libcamera: ipu3: Merge IPA\n\tmetadata controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]