[{"id":16735,"web_url":"https://patchwork.libcamera.org/comment/16735/","msgid":"","date":"2021-05-03T09:48:57","subject":"Re: [libcamera-devel] [PATCH v2 7/7] libcamera: ipu3: imgu: Bump\n\tscript version","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, May 03, 2021 at 11:27:05AM +0200, Jacopo Mondi wrote:\n> Update the revision of the ImgU Python configuration tool the\n> libcamera implementation is based on to commit 243d134\n> (\"Fix some bug for some resolutions\").\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\n> index c874a07e8da6..b5143ef7ed8a 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> @@ -31,7 +31,7 @@ namespace {\n> * The procedure to calculate the ImgU pipe configuration has been ported\n> * from the pipe_config.py python script, available at:\n> * https://github.com/intel/intel-ipu3-pipecfg\n> - * at revision: 61e83f2f7606 (\"Add more information into README\")\n> + * at revision: 243d134 (\"Fix some bug for some resolutions\")\n\nNit-picking, the risk of collision is very low in this case, but 12\ndigits commit IDs are usually preferred.\n\nI love the commit message summary by the way :-)\n\nReviewed-by: Laurent Pinchart \n\n> */\n> \n> static constexpr unsigned int FILTER_W = 4;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60964BDE77\n\tfor ;\n\tMon, 3 May 2021 09:49:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC2AC6890C;\n\tMon, 3 May 2021 11:49:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 18A84602C0\n\tfor ;\n\tMon, 3 May 2021 11:49:00 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8DF662CF;\n\tMon, 3 May 2021 11:48:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OqKe4epS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1620035339;\n\tbh=7aXMYI8vrKav06FmNs+Cw+kwKMW0AAUwBwxYIy9nylE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OqKe4epSebiuRi8rA2BMlzaZWnSS3l+5r1YHB6nTQOX3687P6oRJmvkwKc1GSMg1L\n\t7jsNfnslIbFaqNogC9aI3M9xvFAbJBGaEvbyYRfWayRs/5CGGdtelQDBar5RW09e4J\n\t1+Jh/j+K7WzIk72Ycxgrpb7uVsNVG7Uf/zXJBD8k=","Date":"Mon, 3 May 2021 12:48:57 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210503092705.15562-1-jacopo@jmondi.org>\n\t<20210503092705.15562-8-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210503092705.15562-8-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 7/7] libcamera: ipu3: imgu: Bump\n\tscript version","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16789,"web_url":"https://patchwork.libcamera.org/comment/16789/","msgid":"","date":"2021-05-06T05:57:58","subject":"Re: [libcamera-devel] [PATCH v2 7/7] libcamera: ipu3: imgu: Bump\n\tscript version","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Jacopo, thank you for the patch.\n\nOn Mon, May 3, 2021 at 6:49 PM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Mon, May 03, 2021 at 11:27:05AM +0200, Jacopo Mondi wrote:\n> > Update the revision of the ImgU Python configuration tool the\n> > libcamera implementation is based on to commit 243d134\n> > (\"Fix some bug for some resolutions\").\n> >\n> > Signed-off-by: Jacopo Mondi \n>\n\nReviewed-by: Hirokazu Honda \n\n\n> > ---\n> > src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp\n> b/src/libcamera/pipeline/ipu3/imgu.cpp\n> > index c874a07e8da6..b5143ef7ed8a 100644\n> > --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> > @@ -31,7 +31,7 @@ namespace {\n> > * The procedure to calculate the ImgU pipe configuration has been\n> ported\n> > * from the pipe_config.py python script, available at:\n> > * https://github.com/intel/intel-ipu3-pipecfg\n> > - * at revision: 61e83f2f7606 (\"Add more information into README\")\n> > + * at revision: 243d134 (\"Fix some bug for some resolutions\")\n>\n> Nit-picking, the risk of collision is very low in this case, but 12\n> digits commit IDs are usually preferred.\n>\n> I love the commit message summary by the way :-)\n>\n> Reviewed-by: Laurent Pinchart \n>\n> */\n> >\n> > static constexpr unsigned int FILTER_W = 4;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56407BDE7D\n\tfor ;\n\tThu, 6 May 2021 05:58:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 11C1E6891A;\n\tThu, 6 May 2021 07:58:10 +0200 (CEST)","from mail-ej1-x635.google.com (mail-ej1-x635.google.com\n\t[IPv6:2a00:1450:4864:20::635])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 266CF68901\n\tfor ;\n\tThu, 6 May 2021 07:58:09 +0200 (CEST)","by mail-ej1-x635.google.com with SMTP id m12so6491353eja.2\n\tfor ;\n\tWed, 05 May 2021 22:58:09 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"k+Mwu4Lp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=esID6Fsc9vt5OCvHbWad1snhtWqZaLKFkdNWOeE4iYc=;\n\tb=k+Mwu4Lp8eqlHG7MM7/Oy3mwpe7LvfCArGvvCto+EHSk8XhEO/ZRNMZtCubj3ozKxm\n\tF/0obHD2KDKnZdN6jopONQGePxKt0De/C0udQLpAsxvahioKsnQDTy0PZ5VTyhrrmaD+\n\tsSMgtcx6hNvEyrsDSYQ9pLbVnkw+Mcb7cpxBA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=esID6Fsc9vt5OCvHbWad1snhtWqZaLKFkdNWOeE4iYc=;\n\tb=mmbw8C77IsGSiNjnRdh7lj8aetg8aTaU+QSN3D3iCAHcigOlz32H33DH3dQoXvP1Ra\n\twkuhgKvzpkd7dJo7yJYqI00NJ1h80jGopkYcLS248t+Gb9YHAkPeOM0DsCsQqR0HGUGm\n\tYL2DAyghrG/sKPXqDyivLgP55MumAT7iBQMISD1y9SIPKYvJtNLlvPCLvjPcxcJ7QDLc\n\tG1di+8bbidUIsRxwvIG0JgkR3UEBy7rv7e7NVtO4lw0GfcBF7xklDFsI3YrRMO8If1Qk\n\tk8eOrcD1PpQiA+wR6jInJH3EwEWUWvpjakZYsPXVtgprkx0hBM4Xb5T3LK1oByQ4eual\n\tl54A==","X-Gm-Message-State":"AOAM533KExCierD8zaRrcHbhIJ821o7YQ2RZ6FVQYkPRLR7e+eo5ftGa\n\tpACUPgYKntamRzwYDcoW4pAZYCP8FhAcmvOXi2ebCHSeY9aOfw==","X-Google-Smtp-Source":"ABdhPJxsErcSsfL1jLv4bW+49xCcf73hs++pgk6hUTX4ihge/d+MG/vIFU6CH3tJ65AzOwVt7YtcmxUvevCv9dm5Li8=","X-Received":"by 2002:a17:907:1b06:: with SMTP id\n\tmp6mr2626762ejc.292.1620280688877; \n\tWed, 05 May 2021 22:58:08 -0700 (PDT)","MIME-Version":"1.0","References":"<20210503092705.15562-1-jacopo@jmondi.org>\n\t<20210503092705.15562-8-jacopo@jmondi.org>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Thu, 6 May 2021 14:57:58 +0900","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v2 7/7] libcamera: ipu3: imgu: Bump\n\tscript version","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============9082307243990774113==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]