[{"id":16737,"web_url":"https://patchwork.libcamera.org/comment/16737/","msgid":"","date":"2021-05-03T10:53:41","subject":"Re: [libcamera-devel] [PATCH v2 5/7] libcamera: ipu3: imgu: Fix BSD\n\theight size comparison","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2021-05-03 11:27:03 +0200, Jacopo Mondi wrote:\n> Fix a size comparison when iterating on the BDS sizes to accepts\n> values that are equal to the minimum accepted height.\n> \n> Tested-by: Jean-Michel Hautbois \n> Reviewed-by: Jean-Michel Hautbois \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\n> index feee2cc55abd..fa8cf7eeef19 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> @@ -182,7 +182,7 @@ void calculateBDSHeight(ImgUDevice::Pipe *pipe, const Size &iif, const Size &gdc\n> \t\t}\n> \t} else {\n> \t\tifHeight = utils::alignUp(iif.height, IF_ALIGN_H);\n> -\t\twhile (ifHeight > minIFHeight && ifHeight / bdsSF >= minBDSHeight) {\n> +\t\twhile (ifHeight >= minIFHeight && ifHeight / bdsSF >= minBDSHeight) {\n> \n> \t\t\tbdsHeight = ifHeight / bdsSF;\n> \t\t\tif (std::fmod(ifHeight, 1.0) == 0 && std::fmod(bdsHeight, 1.0) == 0) {\n> -- \n> 2.31.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 472F6BDE77\n\tfor ;\n\tMon, 3 May 2021 10:53:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0094F6890C;\n\tMon, 3 May 2021 12:53:44 +0200 (CEST)","from mail-ej1-x629.google.com (mail-ej1-x629.google.com\n\t[IPv6:2a00:1450:4864:20::629])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C64D460511\n\tfor ;\n\tMon, 3 May 2021 12:53:42 +0200 (CEST)","by mail-ej1-x629.google.com with SMTP id f24so7171723ejc.6\n\tfor ;\n\tMon, 03 May 2021 03:53:42 -0700 (PDT)","from localhost (p54ac5521.dip0.t-ipconnect.de. [84.172.85.33])\n\tby smtp.gmail.com with ESMTPSA id\n\tr15sm7906630edp.62.2021.05.03.03.53.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 03 May 2021 03:53:42 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"wbdQCdlm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=ZVuPAQNT4SanB88bXNbSvpQpkm7Hs1Ldr5nC4CWhlg4=;\n\tb=wbdQCdlmKXLflhnJNyq+SflSxKfTgPWkKK3luhOPA9L0xwSA0Z1TelniW5s3rghsRT\n\tB2PKXxSo67HzZPAUKK29u4TtrluA0/4eT1ZdWqstyTov7h/wn3acAfBm47FY96hodxtC\n\tbxKcr5z8qKav8Xfjxw1E+MGmmkc82vmr1ReSW/Dl3UxZu1J/UwpeKEAatjqHyuNGGlTl\n\tkO13M7qaoxbZhTxK3MFi0BS7Meqws+SxWdDvl9mADVO5csABYx6M6w4HBjLXrIpmB7UY\n\tHwyfHaCj9pN8cv8V0tqQUgqD3XSSfRbHYCjFmuTkQscTY/6gEr8OHVzwjI3tRxywomYf\n\tRpjw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=ZVuPAQNT4SanB88bXNbSvpQpkm7Hs1Ldr5nC4CWhlg4=;\n\tb=i1RMLfC7/+DnEJW2YcWuBTGGd0FZhOiHTVHC9ehKDZztPqZSsCnb14WS2oiS/EOR3z\n\tj3fZAFHeqpVz2LahjPj46cw3sixwKgmKXXZhagAV3CBrBFeKPdnwRgtKYHuKW2fNze6/\n\t0Ot8tUTuUnbTJUPLezKT5Ge+gtsYRg6kdpbcWIMdgpAgC4S6Uiid3JJI52LYq1zfnVD2\n\tSRqzi3hLJWgsTGSUM6Oyokt879aMqdw70CrH9ehRRF0xtLihPXZwSRJ6f+u6aGuqb5uE\n\tBd5/RvMoBWnYTnT4ZZ6AqG/SudU5yZingoL0IVHmrsAhOcZF4odtDbFFc8iFy6wR2a1T\n\tljMA==","X-Gm-Message-State":"AOAM530FFVl/09/0f8RYcOG4yGAXMkiJ2k3egMtB0aPRCAVUYe/9Eky+\n\ttNyQ8cHjk6i3F+4FLe3SUAxN0A==","X-Google-Smtp-Source":"ABdhPJzPXvCB1sew5yQi+qwGeJ5rjoaiD8PO8O5AgIAJUfW3iSBj67MDDQT+QriY95xSMzIIWMaQEg==","X-Received":"by 2002:a17:907:d27:: with SMTP id\n\tgn39mr2059905ejc.389.1620039222411; \n\tMon, 03 May 2021 03:53:42 -0700 (PDT)","Date":"Mon, 3 May 2021 12:53:41 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210503092705.15562-1-jacopo@jmondi.org>\n\t<20210503092705.15562-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210503092705.15562-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 5/7] libcamera: ipu3: imgu: Fix BSD\n\theight size comparison","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16787,"web_url":"https://patchwork.libcamera.org/comment/16787/","msgid":"","date":"2021-05-06T05:56:00","subject":"Re: [libcamera-devel] [PATCH v2 5/7] libcamera: ipu3: imgu: Fix BSD\n\theight size comparison","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Jacopo, thank you for the patch,\n\nOn Mon, May 3, 2021 at 7:53 PM Niklas Söderlund <\nniklas.soderlund@ragnatech.se> wrote:\n\n> Hi Jacopo,\n>\n> Thanks for your work.\n>\n> On 2021-05-03 11:27:03 +0200, Jacopo Mondi wrote:\n> > Fix a size comparison when iterating on the BDS sizes to accepts\n> > values that are equal to the minimum accepted height.\n> >\n> > Tested-by: Jean-Michel Hautbois \n> > Reviewed-by: Jean-Michel Hautbois \n> > Reviewed-by: Laurent Pinchart \n> > Signed-off-by: Jacopo Mondi \n>\n> Reviewed-by: Niklas Söderlund \n>\n>\nReviewed-by: Hirokazu Honda \n\n\n> > ---\n> > src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp\n> b/src/libcamera/pipeline/ipu3/imgu.cpp\n> > index feee2cc55abd..fa8cf7eeef19 100644\n> > --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> > @@ -182,7 +182,7 @@ void calculateBDSHeight(ImgUDevice::Pipe *pipe,\n> const Size &iif, const Size &gdc\n> > }\n> > } else {\n> > ifHeight = utils::alignUp(iif.height, IF_ALIGN_H);\n> > - while (ifHeight > minIFHeight && ifHeight / bdsSF >=\n> minBDSHeight) {\n> > + while (ifHeight >= minIFHeight && ifHeight / bdsSF >=\n> minBDSHeight) {\n> >\n> > bdsHeight = ifHeight / bdsSF;\n> > if (std::fmod(ifHeight, 1.0) == 0 &&\n> std::fmod(bdsHeight, 1.0) == 0) {\n> > --\n> > 2.31.1\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 164B1BDE7E\n\tfor ;\n\tThu, 6 May 2021 05:56:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 868476891D;\n\tThu, 6 May 2021 07:56:13 +0200 (CEST)","from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com\n\t[IPv6:2a00:1450:4864:20::52f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9038168901\n\tfor ;\n\tThu, 6 May 2021 07:56:11 +0200 (CEST)","by mail-ed1-x52f.google.com with SMTP id bf4so4704931edb.11\n\tfor ;\n\tWed, 05 May 2021 22:56:11 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"lh9YmvHB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=/nsM1ooVgU93trxggkjiLlbylKW960XnVXGhjjOi1dg=;\n\tb=lh9YmvHB39Cukel/4ABURA9rIs0C1JHiC1jNAFceXWultx/BoaWS8ngnAJ30toXILW\n\tlQQ0kxwnF/9zBdsrk4jEiPF4C0aPhJUORW0A44kxaES3hattPrrhfQ3iJ+lcJcoPENJc\n\t/HwmMUBjalCm5ni2tPC7Vc0uKWmzSGWrbSmSM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=/nsM1ooVgU93trxggkjiLlbylKW960XnVXGhjjOi1dg=;\n\tb=cRqCqX0EqyRXR5wKLMvxM0uSgiRnMUBfVnOjITMD23P+zpFJFZbY1a7vNUnJPgr0lE\n\t82ddagNR3zkDw65RjEHp7g654O8KL3GEuunIrcjxcsZF2jCScJcR+nu1LZOB9j6OJGAy\n\twuliXQuuRsK1ssKmVBMYYEbe2GEpLjGWD7YdJ1ixrWTMSNGxp8Z3Y7ozqDk93G9L0wvU\n\tr8LgMbWPSvXHmCkjpeicQrF9e6oJtrXaI+suPkctofVyPTV9Tn7B+q7yHc2/deDu3PKB\n\ttR1G6zPEv24ZIYXk8uLI5J7J7zMq22lleBHon4o5K5m81xOX9Q/NgRGd+nPcqK5DRIi6\n\tc99w==","X-Gm-Message-State":"AOAM532fHq7r0Zz2vKXyRL4BuoVxG2RvYjnWAPO50vU+Np8wQNH07dNw\n\tR+Q/ICwjdftjSvmgdreZy4J+zHgA8lvoa9p+fmxgnouCqSo=","X-Google-Smtp-Source":"ABdhPJz3MiildzDB5QNul2t24eXlqby0jae5VpdWFeYVxLIOD3ArpzeY2DmFt/B4HHioJ78Wn6xu3niWIWd7ZaYoJqc=","X-Received":"by 2002:a05:6402:3585:: with SMTP id\n\ty5mr3003317edc.233.1620280571286; \n\tWed, 05 May 2021 22:56:11 -0700 (PDT)","MIME-Version":"1.0","References":"<20210503092705.15562-1-jacopo@jmondi.org>\n\t<20210503092705.15562-6-jacopo@jmondi.org>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Thu, 6 May 2021 14:56:00 +0900","Message-ID":"","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","Subject":"Re: [libcamera-devel] [PATCH v2 5/7] libcamera: ipu3: imgu: Fix BSD\n\theight size comparison","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============2041883576944494292==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]