{"id":12166,"url":"https://patchwork.libcamera.org/api/patches/12166/?format=json","web_url":"https://patchwork.libcamera.org/patch/12166/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210503092705.15562-6-jacopo@jmondi.org>","date":"2021-05-03T09:27:03","name":"[libcamera-devel,v2,5/7] libcamera: ipu3: imgu: Fix BSD height size comparison","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"931fde495cfb4efac1b850d57c554801313690f8","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/12166/mbox/","series":[{"id":1993,"url":"https://patchwork.libcamera.org/api/series/1993/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1993","date":"2021-05-03T09:26:58","name":"ipu3: imgu: Improve ImgU calculation procedure","version":2,"mbox":"https://patchwork.libcamera.org/series/1993/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12166/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12166/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 513E7BDE79\n\tfor ;\n\tMon, 3 May 2021 09:26:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 81A2468922;\n\tMon, 3 May 2021 11:26:29 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7133A68922\n\tfor ;\n\tMon, 3 May 2021 11:26:26 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 3E710E0009\n\tfor ;\n\tMon, 3 May 2021 09:26:26 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 3 May 2021 11:27:03 +0200","Message-Id":"<20210503092705.15562-6-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210503092705.15562-1-jacopo@jmondi.org>","References":"<20210503092705.15562-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 5/7] libcamera: ipu3: imgu: Fix BSD\n\theight size comparison","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Fix a size comparison when iterating on the BDS sizes to accepts\nvalues that are equal to the minimum accepted height.\n\nTested-by: Jean-Michel Hautbois \nReviewed-by: Jean-Michel Hautbois \nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\nindex feee2cc55abd..fa8cf7eeef19 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.cpp\n+++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n@@ -182,7 +182,7 @@ void calculateBDSHeight(ImgUDevice::Pipe *pipe, const Size &iif, const Size &gdc\n \t\t}\n \t} else {\n \t\tifHeight = utils::alignUp(iif.height, IF_ALIGN_H);\n-\t\twhile (ifHeight > minIFHeight && ifHeight / bdsSF >= minBDSHeight) {\n+\t\twhile (ifHeight >= minIFHeight && ifHeight / bdsSF >= minBDSHeight) {\n \n \t\t\tbdsHeight = ifHeight / bdsSF;\n \t\t\tif (std::fmod(ifHeight, 1.0) == 0 && std::fmod(bdsHeight, 1.0) == 0) {\n","prefixes":["libcamera-devel","v2","5/7"]}