[{"id":16769,"web_url":"https://patchwork.libcamera.org/comment/16769/","msgid":"","date":"2021-05-05T09:31:22","subject":"Re: [libcamera-devel] [PATCH] ipa: rpi: controller: Fix typo and\n\timprove comment","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Sebastian,\n\nOn 5/2/21 3:35 PM, Sebastian Fricke wrote:\n> Fix a typo ('for a collecting') within the comment, improve and simplify\n> the comment.\n>\n> Signed-off-by: Sebastian Fricke \n> ---\n> src/ipa/raspberrypi/controller/controller.hpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/controller/controller.hpp b/src/ipa/raspberrypi/controller/controller.hpp\n> index 49b1a551..910aeae1 100644\n> --- a/src/ipa/raspberrypi/controller/controller.hpp\n> +++ b/src/ipa/raspberrypi/controller/controller.hpp\n> @@ -6,8 +6,8 @@\n> */\n> #pragma once\n> \n> -// The Controller is simply a container for a collecting together a number of\n> -// \"control algorithms\" (such as AWB etc.) and for running them all in a\n> +// The Controller is simply a container, that collects a number of\n> +// \"control algorithms\" (such as AWB etc.) and runs them all in a\nThis is already better, but for sake of complete-ness, maybe I will add\n\n+// The Controller is simply a container, that collects a number of\n+// \"control algorithms\" (such as AWB etc.) from the tuning file and runs them all in a\n\n\nReviewed-by: Umang Jain \n> // convenient manner.\n> \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2AD8BBDE79\n\tfor ;\n\tWed, 5 May 2021 09:31:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A7F2D602BE;\n\tWed, 5 May 2021 11:31:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A78F3602BD\n\tfor ;\n\tWed, 5 May 2021 11:31:28 +0200 (CEST)","from localhost.localdomain (unknown [103.251.226.24])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 880224A5;\n\tWed, 5 May 2021 11:31:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DMyEgxmL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1620207088;\n\tbh=aciJAFctATUryZwsMHi5TbtvVEy0IMc3cbbiqGZpsmQ=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=DMyEgxmLkhlmX5snYk77QoALjqsIrVCjwx1TJuoHWwfY/cnT1qafIQF/IRwVj1P5T\n\tTQZkk+7HhUBcovI4RK4zAP7ixaSxa6JfCYn3M7bEb8gH23/RDwG12nPHg4yrXzK36b\n\t0VSHjhzQDmpPkez2F4CBbw6WmCNj4pNdc0ZTyNsw=","To":"Sebastian Fricke ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210502100548.20024-1-sebastian.fricke@posteo.net>","From":"Umang Jain ","Message-ID":"","Date":"Wed, 5 May 2021 15:01:22 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.11.0","MIME-Version":"1.0","In-Reply-To":"<20210502100548.20024-1-sebastian.fricke@posteo.net>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] ipa: rpi: controller: Fix typo and\n\timprove comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]