{"id":12152,"url":"https://patchwork.libcamera.org/api/patches/12152/?format=json","web_url":"https://patchwork.libcamera.org/patch/12152/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210430160026.190724-14-jacopo@jmondi.org>","date":"2021-04-30T16:00:23","name":"[libcamera-devel,v4,13/16] libcamera: raspberry: Report sensor timestamp","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4997ce028cb307a1c95bd9639efc3c54f13f70e2","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12152/mbox/","series":[{"id":1990,"url":"https://patchwork.libcamera.org/api/series/1990/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1990","date":"2021-04-30T16:00:10","name":"Support SensorTimestamp metadata","version":4,"mbox":"https://patchwork.libcamera.org/series/1990/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12152/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12152/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 378A2BDE4C\n\tfor ;\n\tFri, 30 Apr 2021 16:00:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C554768919;\n\tFri, 30 Apr 2021 18:00:10 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2289968909\n\tfor ;\n\tFri, 30 Apr 2021 18:00:01 +0200 (CEST)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 08F45FF804;\n\tFri, 30 Apr 2021 15:59:59 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 30 Apr 2021 18:00:23 +0200","Message-Id":"<20210430160026.190724-14-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210430160026.190724-1-jacopo@jmondi.org>","References":"<20210430160026.190724-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 13/16] libcamera: raspberry: Report\n\tsensor timestamp","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Report the sensor's timestamp in the Request metadata by using the\nUnicam::Image buffer timestamp as an initial approximation.\n\nThe buffer's timestamp is recorded at DMA-transfer time, and it does not\ntheoretically matches the 'start of exposure' definition, but when used\nto compare two consecutive frames it gives an acceptable estimation of\nthe sensor frame period duration.\n\nReviewed-by: Hirokazu Honda \nReviewed-by: Laurent Pinchart \nReviewed-by: Naushir Patuck \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 46f418aa8d73..0a8bc2f3c249 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1414,6 +1414,18 @@ void RPiCameraData::unicamBufferDequeue(FrameBuffer *buffer)\n \t\t\t<< \", timestamp: \" << buffer->metadata().timestamp;\n \n \tif (stream == &unicam_[Unicam::Image]) {\n+\t\t/*\n+\t\t * Record the sensor timestamp in the Request.\n+\t\t *\n+\t\t * \\todo Do not assume the request in the front of the queue\n+\t\t * is the correct one\n+\t\t */\n+\t\tRequest *request = requestQueue_.front();\n+\t\tASSERT(request);\n+\n+\t\trequest->metadata().set(controls::SensorTimestamp,\n+\t\t\t\t\tbuffer->metadata().timestamp);\n+\n \t\t/*\n \t\t * Lookup the sensor controls used for this frame sequence from\n \t\t * DelayedControl and queue them along with the frame buffer.\n","prefixes":["libcamera-devel","v4","13/16"]}