{"id":12148,"url":"https://patchwork.libcamera.org/api/patches/12148/?format=json","web_url":"https://patchwork.libcamera.org/patch/12148/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210430160026.190724-10-jacopo@jmondi.org>","date":"2021-04-30T16:00:19","name":"[libcamera-devel,v4,09/16] libcamera: simple: Report sensor timestamp","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ee612ad1c896670d38468a459f78c4e6b9b7c51e","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12148/mbox/","series":[{"id":1990,"url":"https://patchwork.libcamera.org/api/series/1990/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1990","date":"2021-04-30T16:00:10","name":"Support SensorTimestamp metadata","version":4,"mbox":"https://patchwork.libcamera.org/series/1990/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12148/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12148/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A73A4BDE4C\n\tfor ;\n\tFri, 30 Apr 2021 16:00:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5CF76688A5;\n\tFri, 30 Apr 2021 18:00:04 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA6AB68919\n\tfor ;\n\tFri, 30 Apr 2021 17:59:56 +0200 (CEST)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 05DCBFF803;\n\tFri, 30 Apr 2021 15:59:55 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 30 Apr 2021 18:00:19 +0200","Message-Id":"<20210430160026.190724-10-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210430160026.190724-1-jacopo@jmondi.org>","References":"<20210430160026.190724-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 09/16] libcamera: simple: Report sensor\n\ttimestamp","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Report the sensor's timestamp in the Request metadata using the\ncompleted buffer timestamp.\n\nThe buffer's timestamp is recorded at DMA-transfer time, and it does not\ntheoretically matches the 'start of exposure' definition. Record this with\na \\todo entry.\n\nReviewed-by: Hirokazu Honda \nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/simple/simple.cpp | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex f6095d38e97a..e1ee640b0a92 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -22,6 +22,7 @@\n #include \n \n #include \n+#include \n #include \n #include \n \n@@ -1116,6 +1117,16 @@ void SimplePipelineHandler::bufferReady(FrameBuffer *buffer)\n \t\treturn;\n \t}\n \n+\t/*\n+\t * Record the sensor's timestamp in the request metadata.\n+\t *\n+\t * \\todo The sensor timestamp should be better estimated by connecting\n+\t * to the V4L2Device::frameStart signal if the platform provides it.\n+\t */\n+\tRequest *request = buffer->request();\n+\trequest->metadata().set(controls::SensorTimestamp,\n+\t\t\t\tbuffer->metadata().timestamp);\n+\n \t/*\n \t * Queue the captured and the request buffer to the converter if format\n \t * conversion is needed. If there's no queued request, just requeue the\n@@ -1133,7 +1144,6 @@ void SimplePipelineHandler::bufferReady(FrameBuffer *buffer)\n \t}\n \n \t/* Otherwise simply complete the request. */\n-\tRequest *request = buffer->request();\n \tcompleteBuffer(request, buffer);\n \tcompleteRequest(request);\n }\n","prefixes":["libcamera-devel","v4","09/16"]}