[{"id":16712,"web_url":"https://patchwork.libcamera.org/comment/16712/","msgid":"","date":"2021-05-01T06:31:58","subject":"Re: [libcamera-devel] [PATCH v4 08/16] libcamera: rkisp1: Report\n\tsensor timestamp","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2021-04-30 18:00:18 +0200, Jacopo Mondi wrote:\n> Report the sensor's timestamp in the Request metadata using the\n> completed buffer timestamp.\n> \n> The buffer's timestamp is recorded at DMA-transfer time, and it does not\n> theoretically matches the 'start of exposure' definition. Record this with\n> a \\todo entry.\n> \n> Reviewed-by: Hirokazu Honda \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 26f708242523..cee6d85fac47 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -1070,6 +1070,15 @@ void PipelineHandlerRkISP1::bufferReady(FrameBuffer *buffer)\n> {\n> \tRequest *request = buffer->request();\n> \n> +\t/*\n> +\t * Record the sensor's timestamp in the request metadata.\n> +\t *\n> +\t * \\todo The sensor timestamp should be better estimated by connecting\n> +\t * to the V4L2Device::frameStart signal.\n> +\t */\n\nSame comment as for previous patch, I think what is done here is the \nbetter solution.\n\nReviewed-by: Niklas Söderlund \n\n> +\trequest->metadata().set(controls::SensorTimestamp,\n> +\t\t\t\tbuffer->metadata().timestamp);\n> +\n> \tcompleteBuffer(request, buffer);\n> \ttryCompleteRequest(request);\n> }\n> -- \n> 2.31.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 73B4ABDE6B\n\tfor ;\n\tSat, 1 May 2021 06:32:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D39BD60511;\n\tSat, 1 May 2021 08:32:01 +0200 (CEST)","from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com\n\t[IPv6:2a00:1450:4864:20::12c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C82C602BF\n\tfor ;\n\tSat, 1 May 2021 08:32:00 +0200 (CEST)","by mail-lf1-x12c.google.com with SMTP id 12so371075lfq.13\n\tfor ;\n\tFri, 30 Apr 2021 23:32:00 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tl24sm492049lfc.23.2021.04.30.23.31.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 30 Apr 2021 23:31:59 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"a1iadLrq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=tCpmI8s000FNMqtqJyS3WBlZPl38IBoj2Eh1BQ1KuFY=;\n\tb=a1iadLrq3KOKKRkgOFwF2vUFcrjtR5/5+hhoCvsISvOWXWQ11lrXhDlp5gNLav9Kfl\n\tVcJPggRO7WSBkiOO8XHxfUHnN8/srdkLBuAG5UzyAc0GscNNNb4URz7vvsEB+FGYRGVI\n\td5rojCPD7ccEDiwYGeU9vbhFcr9e5cPmEh06iNnYgnOHSUccQrmhAXPQI0a4Ex8rlgyI\n\tN/lzuc6vKfjSOeV4gw6/8kAH6hCpcrqBFyW4tQ48BWM4v9Wo5u5BZPYhPcWmPu5x2c56\n\twjRCp7ofUeFyPAOw8aEyuRQFj3UE5ca/zmcO4Yltp/N0J7rhM+NKxy2iillLejfrc9oZ\n\tQ3Bw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=tCpmI8s000FNMqtqJyS3WBlZPl38IBoj2Eh1BQ1KuFY=;\n\tb=kdehiS/Q+QdEnyaojmjzr0ZjyIrYpSSbCJqNmoR8Q9BqsiX7D1cGBd7yRxd1ux4kaS\n\thdzoUr98I187I82OxqjLLtBJTXRCE+mswcED2qzjbwzatAIna5uTIhL042ove75py6te\n\t3A242RcpC3t8GvH0LlKVyZWzFq1rNLZjEP4uOFarh6Qrk9KomkdxbknGASgfDPPTbNDF\n\tTDTER2O1t5/MfFvzaR0W1Zd+8+TxZ7ItxVJARe6PhjhvJieF4EnjHVghM+9vSXDdrvS+\n\t28teTVNKdRCfMDIMR8Rkrcc3ryCFeZ+pHhrrmHnoJy65wDHpSSgQZmc+bN6f0gvlZ9PV\n\t1/Rg==","X-Gm-Message-State":"AOAM533CZJu+lJSeH4W76z1l5BasMIx77AXTe0vP3l5V1b8DO5wPSuGO\n\tlv4LLENzbI8oJS+V3U6vglE8dkTzCbHxsg==","X-Google-Smtp-Source":"ABdhPJzF9pyskHT0T0V5K0U584mq4KyUNxfg19V1RXqGKE/l3w1Vy26Erwyul5LdSzU3Ud1DegN0pw==","X-Received":"by 2002:a05:6512:20f:: with SMTP id\n\ta15mr5759059lfo.531.1619850720032; \n\tFri, 30 Apr 2021 23:32:00 -0700 (PDT)","Date":"Sat, 1 May 2021 08:31:58 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210430160026.190724-1-jacopo@jmondi.org>\n\t<20210430160026.190724-9-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210430160026.190724-9-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v4 08/16] libcamera: rkisp1: Report\n\tsensor timestamp","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]