[{"id":16765,"web_url":"https://patchwork.libcamera.org/comment/16765/","msgid":"<20210505075323.cirpzeaiwbpjasob@uno.localdomain>","date":"2021-05-05T07:53:23","subject":"Re: [libcamera-devel] [PATCH v3 2/2] test: bayer-format: Rectify\n\tinternal header's #include path","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Umang,\n\nOn Fri, Apr 30, 2021 at 10:09:57AM +0530, Umang Jain wrote:\n> libcamera internal headers are not available system-wide. Hence,\n> directive `#include ` is wrong. Fix it\n> by using \"\" for the #include directive.\n>\n> Fixes: e09c487b97f8 (\"test: Add unit tests for the BayerFormat class\")\n> Signed-off-by: Umang Jain \n\nThanks, looks good!\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> test/bayer-format.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/test/bayer-format.cpp b/test/bayer-format.cpp\n> index 047e7db3..e396ee83 100644\n> --- a/test/bayer-format.cpp\n> +++ b/test/bayer-format.cpp\n> @@ -7,9 +7,10 @@\n>\n> #include \n>\n> -#include \n> #include \n>\n> +#include \"libcamera/internal/bayer_format.h\"\n> +\n> #include \"test.h\"\n>\n> using namespace std;\n> --\n> 2.29.2\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 006C0BDE7B\n\tfor ;\n\tWed, 5 May 2021 07:52:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4075768909;\n\tWed, 5 May 2021 09:52:41 +0200 (CEST)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 862B4602BD\n\tfor ;\n\tWed, 5 May 2021 09:52:40 +0200 (CEST)","from uno.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id E01C5100019;\n\tWed, 5 May 2021 07:52:39 +0000 (UTC)"],"Date":"Wed, 5 May 2021 09:53:23 +0200","From":"Jacopo Mondi ","To":"Umang Jain ","Message-ID":"<20210505075323.cirpzeaiwbpjasob@uno.localdomain>","References":"<20210430043957.111667-1-umang.jain@ideasonboard.com>\n\t<20210430043957.111667-3-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210430043957.111667-3-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 2/2] test: bayer-format: Rectify\n\tinternal header's #include path","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16766,"web_url":"https://patchwork.libcamera.org/comment/16766/","msgid":"<20210505080720.qozwbhndmogee4x3@basti-TUXEDO-Book-XA1510>","date":"2021-05-05T08:07:20","subject":"Re: [libcamera-devel] [PATCH v3 2/2] test: bayer-format: Rectify\n\tinternal header's #include path","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"content":"Hey Umang,\n\nThank you for the patch.\n\nOn 30.04.2021 10:09, Umang Jain wrote:\n>libcamera internal headers are not available system-wide. Hence,\n>directive `#include ` is wrong. Fix it\n>by using \"\" for the #include directive.\n>\n>Fixes: e09c487b97f8 (\"test: Add unit tests for the BayerFormat class\")\n>Signed-off-by: Umang Jain \nReviewed-by: Sebastian Fricke \n>---\n> test/bayer-format.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n>diff --git a/test/bayer-format.cpp b/test/bayer-format.cpp\n>index 047e7db3..e396ee83 100644\n>--- a/test/bayer-format.cpp\n>+++ b/test/bayer-format.cpp\n>@@ -7,9 +7,10 @@\n>\n> #include \n>\n>-#include \n> #include \n>\n>+#include \"libcamera/internal/bayer_format.h\"\n>+\n\nThis was my fault, thank you for fixing it!\n\n> #include \"test.h\"\n>\n> using namespace std;\n>-- \n>2.29.2\n>\n>_______________________________________________\n>libcamera-devel mailing list\n>libcamera-devel@lists.libcamera.org\n>https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5122DBDE79\n\tfor ;\n\tWed, 5 May 2021 08:07:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A19D168909;\n\tWed, 5 May 2021 10:07:24 +0200 (CEST)","from mout01.posteo.de (mout01.posteo.de [185.67.36.65])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1585C602BD\n\tfor ;\n\tWed, 5 May 2021 10:07:23 +0200 (CEST)","from submission (posteo.de [89.146.220.130]) \n\tby mout01.posteo.de (Postfix) with ESMTPS id 973EE240029\n\tfor ;\n\tWed, 5 May 2021 10:07:22 +0200 (CEST)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4FZq7Y41rYz6tm5;\n\tWed, 5 May 2021 10:07:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"O/dP3Hd6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1620202042; bh=37DaUBrXGX1sHBP99vvjEtPahEqxJS+ogEo7ZrI1EXI=;\n\th=Date:From:To:Cc:Subject:From;\n\tb=O/dP3Hd6ls/Tv61GU5xGivZUW1ECYCZ0hchrRzR6QHn0J5wyIwODF7sgMvyn8ODH6\n\tNWONjRONO6FYDpK7XJcNOEDFIZCM4wnBfRmICvnD67ALmiXqnDpwb/SCARm2fZ9C1X\n\tYrH1NgTGkfsoLOfH5VjSVdME/qG/n/zbgrOT9J23tLSmtBbMslNS1chXylsXeitBxf\n\twLW5sN6qqDrCNzDW4kBzczB26AhBvadcURNUaWTNRH/j9WttrI8pXjW4U9/9RUiv4C\n\t2MRUF0o+h8MPR1stlxOXEkK9ui1eYjSOTDZiLR/4w+4cyU70qrnNhz9xuvSEhx7D/+\n\tHCdqLWvQe8XtQ==","Date":"Wed, 5 May 2021 08:07:20 +0000","From":"Sebastian Fricke ","To":"Umang Jain ","Message-ID":"<20210505080720.qozwbhndmogee4x3@basti-TUXEDO-Book-XA1510>","References":"<20210430043957.111667-1-umang.jain@ideasonboard.com>\n\t<20210430043957.111667-3-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210430043957.111667-3-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 2/2] test: bayer-format: Rectify\n\tinternal header's #include path","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16767,"web_url":"https://patchwork.libcamera.org/comment/16767/","msgid":"<20210505083351.zig5zukw4bkc4xqp@uno.localdomain>","date":"2021-05-05T08:33:51","subject":"Re: [libcamera-devel] [PATCH v3 2/2] test: bayer-format: Rectify\n\tinternal header's #include path","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Sebastian,\n I've -literally- just pushed this one. I'm sorry for not waiting\nfor your tag!\n\nOn Wed, May 05, 2021 at 08:07:20AM +0000, Sebastian Fricke wrote:\n> Hey Umang,\n>\n> Thank you for the patch.\n>\n> On 30.04.2021 10:09, Umang Jain wrote:\n> > libcamera internal headers are not available system-wide. Hence,\n> > directive `#include ` is wrong. Fix it\n> > by using \"\" for the #include directive.\n> >\n> > Fixes: e09c487b97f8 (\"test: Add unit tests for the BayerFormat class\")\n> > Signed-off-by: Umang Jain \n> Reviewed-by: Sebastian Fricke \n> > ---\n> > test/bayer-format.cpp | 3 ++-\n> > 1 file changed, 2 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/test/bayer-format.cpp b/test/bayer-format.cpp\n> > index 047e7db3..e396ee83 100644\n> > --- a/test/bayer-format.cpp\n> > +++ b/test/bayer-format.cpp\n> > @@ -7,9 +7,10 @@\n> >\n> > #include \n> >\n> > -#include \n> > #include \n> >\n> > +#include \"libcamera/internal/bayer_format.h\"\n> > +\n>\n> This was my fault, thank you for fixing it!\n>\n> > #include \"test.h\"\n> >\n> > using namespace std;\n> > --\n> > 2.29.2\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C859BDE7B\n\tfor ;\n\tWed, 5 May 2021 08:33:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0A0C602BE;\n\tWed, 5 May 2021 10:33:09 +0200 (CEST)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66B8D602BD\n\tfor ;\n\tWed, 5 May 2021 10:33:08 +0200 (CEST)","from uno.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id B72D0100015;\n\tWed, 5 May 2021 08:33:07 +0000 (UTC)"],"Date":"Wed, 5 May 2021 10:33:51 +0200","From":"Jacopo Mondi ","To":"Sebastian Fricke ","Message-ID":"<20210505083351.zig5zukw4bkc4xqp@uno.localdomain>","References":"<20210430043957.111667-1-umang.jain@ideasonboard.com>\n\t<20210430043957.111667-3-umang.jain@ideasonboard.com>\n\t<20210505080720.qozwbhndmogee4x3@basti-TUXEDO-Book-XA1510>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210505080720.qozwbhndmogee4x3@basti-TUXEDO-Book-XA1510>","Subject":"Re: [libcamera-devel] [PATCH v3 2/2] test: bayer-format: Rectify\n\tinternal header's #include path","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]