[{"id":16695,"web_url":"https://patchwork.libcamera.org/comment/16695/","msgid":"<20210430062519.GP195599@pyrite.rasen.tech>","date":"2021-04-30T06:25:19","subject":"Re: [libcamera-devel] [PATCH v3 1/2] src: android: Rectify internal\n\theader's #include path","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Umang,\n\nOn Fri, Apr 30, 2021 at 10:09:56AM +0530, Umang Jain wrote:\n> libcamera internal headers are not installed system-wide. Hence, any\n> inclusion of internal headers should be follow the #include directive\n> form:\n> \t#include \"libcamera/internal/header.h\"\n> \n> This was not the case for a few of the class in android HAL. Fix them.\n> \n> Signed-off-by: Umang Jain \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Hirokazu Honda \n\nReviewed-by: Paul Elder \n\n> ---\n> src/android/camera_stream.h | 2 +-\n> src/android/mm/generic_camera_buffer.cpp | 2 +-\n> src/android/post_processor.h | 2 +-\n> 3 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n> index f68fdd3a..34016722 100644\n> --- a/src/android/camera_stream.h\n> +++ b/src/android/camera_stream.h\n> @@ -19,7 +19,7 @@\n> #include \n> #include \n> \n> -#include \n> +#include \"libcamera/internal/buffer.h\"\n> \n> class CameraDevice;\n> class CameraMetadata;\n> diff --git a/src/android/mm/generic_camera_buffer.cpp b/src/android/mm/generic_camera_buffer.cpp\n> index 929e078a..334498c1 100644\n> --- a/src/android/mm/generic_camera_buffer.cpp\n> +++ b/src/android/mm/generic_camera_buffer.cpp\n> @@ -7,7 +7,7 @@\n> \n> #include \"../camera_buffer.h\"\n> \n> -#include \n> +#include \"libcamera/internal/buffer.h\"\n> #include \"libcamera/internal/log.h\"\n> \n> using namespace libcamera;\n> diff --git a/src/android/post_processor.h b/src/android/post_processor.h\n> index 4944078b..547fda37 100644\n> --- a/src/android/post_processor.h\n> +++ b/src/android/post_processor.h\n> @@ -10,7 +10,7 @@\n> #include \n> #include \n> \n> -#include \n> +#include \"libcamera/internal/buffer.h\"\n> \n> #include \"camera_buffer.h\"\n> \n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81D8CBDE45\n\tfor ;\n\tFri, 30 Apr 2021 06:25:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8DADC68901;\n\tFri, 30 Apr 2021 08:25:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C0250602C0\n\tfor ;\n\tFri, 30 Apr 2021 08:25:26 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 50135E8;\n\tFri, 30 Apr 2021 08:25:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"onKY8XuA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619763926;\n\tbh=vxVwT+5/lge5KvfpEzgFovLkwn3zOdZSYsrZguNWjHc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=onKY8XuAV/3AXwmYQw4/LkT/wG0h4IOcLQucm6NSaJieXyqn2J754m6auwn2//9hl\n\tO/ATcn1xoOyvSKhQod8jGfcibOBpSAhzZLCZnx/pmQhjtDGfMU8tjzBR2qiJIANHuz\n\t4JC3BAgC4LmNLIa8IM/ZDTrRxq76AQeQo1keMDko=","Date":"Fri, 30 Apr 2021 15:25:19 +0900","From":"paul.elder@ideasonboard.com","To":"Umang Jain ","Message-ID":"<20210430062519.GP195599@pyrite.rasen.tech>","References":"<20210430043957.111667-1-umang.jain@ideasonboard.com>\n\t<20210430043957.111667-2-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210430043957.111667-2-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 1/2] src: android: Rectify internal\n\theader's #include path","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]