[{"id":16688,"web_url":"https://patchwork.libcamera.org/comment/16688/","msgid":"","date":"2021-04-29T11:26:00","subject":"Re: [libcamera-devel] [PATCH] android: camera_stream: Rectify\n\tinternal header's #include path","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Umang,\n\nThanks for your work.\n\nOn 2021-04-29 16:27:41 +0530, Umang Jain wrote:\n> libcamera internal headers are not installed system-wide. Hence, any\n> inclusion of internal headers should be follow the #include directive\n> form:\n> \t#include \"libcamera/internal/header.h\"\n\nThis also needs fixing in generic_camera_buffer.cpp and \npost_processor.h.\n\n> \n> This was not the case with buffer.h internal header. Fix it.\n> \n> Signed-off-by: Umang Jain \n> ---\n> src/android/camera_stream.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n> index f68fdd3a..34016722 100644\n> --- a/src/android/camera_stream.h\n> +++ b/src/android/camera_stream.h\n> @@ -19,7 +19,7 @@\n> #include \n> #include \n> \n> -#include \n> +#include \"libcamera/internal/buffer.h\"\n> \n> class CameraDevice;\n> class CameraMetadata;\n> -- \n> 2.29.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A3264BDE44\n\tfor ;\n\tThu, 29 Apr 2021 11:26:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ED4236890D;\n\tThu, 29 Apr 2021 13:26:02 +0200 (CEST)","from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com\n\t[IPv6:2a00:1450:4864:20::12e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 290EB60511\n\tfor ;\n\tThu, 29 Apr 2021 13:26:02 +0200 (CEST)","by mail-lf1-x12e.google.com with SMTP id b23so21672546lfv.8\n\tfor ;\n\tThu, 29 Apr 2021 04:26:02 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tv130sm494730lfa.262.2021.04.29.04.26.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 29 Apr 2021 04:26:01 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"bx9ZCsRW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=FVFZvF+Jg/2+VzrLIzxRoA3OOTsf+Ed0ijTDyM/4r90=;\n\tb=bx9ZCsRWWTWBAut5tMLyKqds4lypdoE4djHnaO9NbHjlpe6A6OtjmvUWmckJI7rLnl\n\tgXI7EKP1MjMfoowj1Ok4l6588LM+1gyrujulzw0oYtSFWCddrFZqXWBD8HX7o32MJ46I\n\tkZ5pfa4QG8lmREn/IKolj7v31k0kOTBHjHXV80ELHpluJAlpWHJUmhDrFx4bS55ARDrm\n\tAuWu4eEuCv3ZFip2oQc1DCSFTQ7u8B2I1H6Wy6OyWq1xjPRUwnr8DLf+INn0rrKcQcDZ\n\tx/umf9Zf00ItXCK00vUV8NDxUKW/zhuBrHkh6yryqnYfdzATylvL5OyF1WMrrgvBNYQS\n\tPKtw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=FVFZvF+Jg/2+VzrLIzxRoA3OOTsf+Ed0ijTDyM/4r90=;\n\tb=KB3EcqNBITFz0/DtYgpmm0/e0loQf3rBwTFxZIQ99cJgvNPZM6B2G1bH5Yl9378NZV\n\tBDtwY58IgZgt6RLZati2M70b+5R11MBMYkB0jwSoN3C+qci/0ZYurWZOnnIhbHtQqGtQ\n\tn4O/Feu48iWEWztqCyB6RdnfLZzIOUbdhtbCMtN22SWZTjkn51qurNs9wjs4uXOoO3fJ\n\toBdLrJ1gDt+e/xzmLDbRQcVj1ogA3mhJ3+hH3x78mE9osVfjhgi4nEgtb+o2hBMNYNkl\n\tSGGgi4zBrSGL4Pb/lUeflJr5whXNGQlMuaZ4YXv0MDL49fh6VFh8cGCkGHq9McjqUaAn\n\ttFUQ==","X-Gm-Message-State":"AOAM531GYx5jHnWObu2JdURB/clxxyKQlZzaIWvhLU091jusRFsD1Kr7\n\tfvKMUxJDolprSapF0pKvzDxikQaovDGRuQty","X-Google-Smtp-Source":"ABdhPJyz6caYbdplYYXctD/XrOvb8VRMOvz+yas8WTMDkBXFGWTLgf6YhmkQ7XlGfPR+IOxwhoNu1A==","X-Received":"by 2002:ac2:551a:: with SMTP id\n\tj26mr23812211lfk.61.1619695561600; \n\tThu, 29 Apr 2021 04:26:01 -0700 (PDT)","Date":"Thu, 29 Apr 2021 13:26:00 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Umang Jain ","Message-ID":"","References":"<20210429105741.59236-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210429105741.59236-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] android: camera_stream: Rectify\n\tinternal header's #include path","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16693,"web_url":"https://patchwork.libcamera.org/comment/16693/","msgid":"","date":"2021-04-30T04:07:18","subject":"Re: [libcamera-devel] [PATCH] android: camera_stream: Rectify\n\tinternal header's #include path","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Umang, thanks for the patch.\n\nOn Thu, Apr 29, 2021 at 8:26 PM Niklas Söderlund <\nniklas.soderlund@ragnatech.se> wrote:\n>\n> Hi Umang,\n>\n> Thanks for your work.\n>\n> On 2021-04-29 16:27:41 +0530, Umang Jain wrote:\n> > libcamera internal headers are not installed system-wide. Hence, any\n> > inclusion of internal headers should be follow the #include directive\n> > form:\n> > #include \"libcamera/internal/header.h\"\n>\n> This also needs fixing in generic_camera_buffer.cpp and\n> post_processor.h.\n>\n\nMy quick grep shows the following result. Would you fix them as well?\n\n$ rg \"#include \nsrc/android/post_processor.h\n13:#include \nsrc/android/camera_stream.h\n22:#include \nsrc/android/mm/generic_camera_buffer.cpp\n10:#include \n\n\n-Hiro\n\n> >\n> > This was not the case with buffer.h internal header. Fix it.\n> >\n> > Signed-off-by: Umang Jain \n> > ---\n> > src/android/camera_stream.h | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n> > index f68fdd3a..34016722 100644\n> > --- a/src/android/camera_stream.h\n> > +++ b/src/android/camera_stream.h\n> > @@ -19,7 +19,7 @@\n> > #include \n> > #include \n> >\n> > -#include \n> > +#include \"libcamera/internal/buffer.h\"\n> >\n> > class CameraDevice;\n> > class CameraMetadata;\n> > --\n> > 2.29.2\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D448BDE45\n\tfor ;\n\tFri, 30 Apr 2021 04:07:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7993068901;\n\tFri, 30 Apr 2021 06:07:30 +0200 (CEST)","from mail-ej1-x629.google.com (mail-ej1-x629.google.com\n\t[IPv6:2a00:1450:4864:20::629])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 987E4602C0\n\tfor ;\n\tFri, 30 Apr 2021 06:07:29 +0200 (CEST)","by mail-ej1-x629.google.com with SMTP id f24so4607042ejc.6\n\tfor ;\n\tThu, 29 Apr 2021 21:07:29 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Vk9tLI4f\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=QxmfIP+/g+DUGhTu/AFbo6RyQ0P7S0ac/D1yl9hCdsw=;\n\tb=Vk9tLI4f1xQpbsR+SH+6ADb1fojxRSajZwnLMJo/5W67usWHOgP6tCjDWKu4kI6Q5O\n\tSuh7KCA+g1ZfpBdZ5uyf0T2cyRvpZ1m9waaMZSaXp3wC/KPoyQDYfewIWkjLjswfWHsa\n\tWjF/ofJbELP+qBYZO4mGj98+TBjkbLYkSlYlk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=QxmfIP+/g+DUGhTu/AFbo6RyQ0P7S0ac/D1yl9hCdsw=;\n\tb=NJrkzrPZGGwpPokzeghmMMYDEyAPuFWK+O7/T0LhTPKtZYLR1y17N7ZcchbkLksdNu\n\thzlFsQFsRKcWUyikmBZ5X4jNs0fKrdAqQiUPwtgj0IaJ8nf9n9xet+fCWQMCLzbLVhLJ\n\t9SChRKk3gAxJoLQd7eTsr+pZwsFSY109aRYmN/Xg8JxaYcneW5k48L4zI5yl3w0TB6pm\n\tJr8+kjLzyiIKPgcwgrNu4g/3BaeDX5/D3L7n4tkB5wrAAKGmDva2iotaqFaxUuCAoGDs\n\t/0SfqfkBBEJSgaouqPbGnloh8QA1ldU5zhfhavZrLxX0F3zSQKA1z0R/cvfxMThTscLu\n\thSpg==","X-Gm-Message-State":"AOAM533c/kTKML77BBz6jy5oRqKPBZ0fkCfDeCrIBwfztebTCPTI8WVW\n\t9b4ZAZB0vYWnWxAC5iGQa71VpQrFEV5iVFXVI2KUMJIEe6uMGg==","X-Google-Smtp-Source":"ABdhPJw9QgEk/haWWOkkQkZRitbGd7JqlAlTmTj8Ti9hokGqAsb/yQHYDD9ba1n6DJhEnqe264n3xtB8SVMrGURRNOE=","X-Received":"by 2002:a17:907:1b06:: with SMTP id\n\tmp6mr1985578ejc.292.1619755649247; \n\tThu, 29 Apr 2021 21:07:29 -0700 (PDT)","MIME-Version":"1.0","References":"<20210429105741.59236-1-umang.jain@ideasonboard.com>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Fri, 30 Apr 2021 13:07:18 +0900","Message-ID":"","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","Subject":"Re: [libcamera-devel] [PATCH] android: camera_stream: Rectify\n\tinternal header's #include path","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============1570291463614251715==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]