{"id":1210,"url":"https://patchwork.libcamera.org/api/patches/1210/?format=json","web_url":"https://patchwork.libcamera.org/patch/1210/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190517005447.27171-6-niklas.soderlund@ragnatech.se>","date":"2019-05-17T00:54:41","name":"[libcamera-devel,v4,05/11] test: media_device: Create a common MediaDeviceTest base class","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e47e853a3893972211d5e9b00415febab0e7271e","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1210/mbox/","series":[{"id":306,"url":"https://patchwork.libcamera.org/api/series/306/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=306","date":"2019-05-17T00:54:36","name":"libcamerea: Add support for exclusive access to cameras between processes","version":4,"mbox":"https://patchwork.libcamera.org/series/306/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1210/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1210/checks/","tags":{},"headers":{"Return-Path":"","Received":["from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 518646186F\n\tfor ;\n\tFri, 17 May 2019 02:55:12 +0200 (CEST)","from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 6be6f0e0-783e-11e9-8d05-005056917f90;\n\tFri, 17 May 2019 02:55:10 +0200 (CEST)"],"X-Halon-ID":"6be6f0e0-783e-11e9-8d05-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 17 May 2019 02:54:41 +0200","Message-Id":"<20190517005447.27171-6-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190517005447.27171-1-niklas.soderlund@ragnatech.se>","References":"<20190517005447.27171-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 05/11] test: media_device: Create a\n\tcommon MediaDeviceTest base class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 17 May 2019 00:55:12 -0000"},"content":"Before adding more tests which will act on the vimc pipeline break out a\ncommon base from media_device_link_test.cpp which already acts on vimc.\nThe new common base class will help reduce code duplication.\n\nSigned-off-by: Niklas Söderlund \n---\n test/media_device/media_device_link_test.cpp | 71 ++++++--------------\n test/media_device/media_device_test.cpp | 36 ++++++++++\n test/media_device/media_device_test.h | 34 ++++++++++\n test/media_device/meson.build | 9 ++-\n 4 files changed, 99 insertions(+), 51 deletions(-)\n create mode 100644 test/media_device/media_device_test.cpp\n create mode 100644 test/media_device/media_device_test.h","diff":"diff --git a/test/media_device/media_device_link_test.cpp b/test/media_device/media_device_link_test.cpp\nindex 334bb44a6fc14371..60e502df8043f979 100644\n--- a/test/media_device/media_device_link_test.cpp\n+++ b/test/media_device/media_device_link_test.cpp\n@@ -4,13 +4,10 @@\n *\n * media_device_link_test.cpp - Tests link handling on VIMC media device\n */\n+\n #include \n-#include \n \n-#include \"device_enumerator.h\"\n-#include \"media_device.h\"\n-\n-#include \"test.h\"\n+#include \"media_device_test.h\"\n \n using namespace libcamera;\n using namespace std;\n@@ -29,44 +26,21 @@ using namespace std;\n * loaded) the test is skipped.\n */\n \n-class MediaDeviceLinkTest : public Test\n+class MediaDeviceLinkTest : public MediaDeviceTest\n {\n-\tint init()\n-\t{\n-\t\tenumerator = unique_ptr(DeviceEnumerator::create());\n-\t\tif (!enumerator) {\n-\t\t\tcerr << \"Failed to create device enumerator\" << endl;\n-\t\t\treturn TestFail;\n-\t\t}\n-\n-\t\tif (enumerator->enumerate()) {\n-\t\t\tcerr << \"Failed to enumerate media devices\" << endl;\n-\t\t\treturn TestFail;\n-\t\t}\n-\n-\t\tDeviceMatch dm(\"vimc\");\n-\t\tdev_ = enumerator->search(dm);\n-\t\tif (!dev_) {\n-\t\t\tcerr << \"No VIMC media device found: skip test\" << endl;\n-\t\t\treturn TestSkip;\n-\t\t}\n-\n-\t\tif (!dev_->acquire()) {\n-\t\t\tcerr << \"Unable to acquire media device \"\n-\t\t\t << dev_->deviceNode() << endl;\n-\t\t\treturn TestSkip;\n-\t\t}\n-\n-\t\treturn 0;\n-\t}\n-\n \tint run()\n \t{\n+\t\tif (!media_->acquire()) {\n+\t\t\tcerr << \"Unable to acquire media device \"\n+\t\t\t << media_->deviceNode() << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n \t\t/*\n \t\t * First of all disable all links in the media graph to\n \t\t * ensure we start from a known state.\n \t\t */\n-\t\tif (dev_->disableLinks()) {\n+\t\tif (media_->disableLinks()) {\n \t\t\tcerr << \"Failed to disable all links in the media graph\";\n \t\t\treturn TestFail;\n \t\t}\n@@ -76,26 +50,26 @@ class MediaDeviceLinkTest : public Test\n \t\t * different methods the media device offers.\n \t\t */\n \t\tstring linkName(\"'Debayer A':[1] -> 'Scaler':[0]'\");\n-\t\tMediaLink *link = dev_->link(\"Debayer A\", 1, \"Scaler\", 0);\n+\t\tMediaLink *link = media_->link(\"Debayer A\", 1, \"Scaler\", 0);\n \t\tif (!link) {\n \t\t\tcerr << \"Unable to find link: \" << linkName\n \t\t\t << \" using lookup by name\" << endl;\n \t\t\treturn TestFail;\n \t\t}\n \n-\t\tMediaEntity *source = dev_->getEntityByName(\"Debayer A\");\n+\t\tMediaEntity *source = media_->getEntityByName(\"Debayer A\");\n \t\tif (!source) {\n \t\t\tcerr << \"Unable to find entity: 'Debayer A'\" << endl;\n \t\t\treturn TestFail;\n \t\t}\n \n-\t\tMediaEntity *sink = dev_->getEntityByName(\"Scaler\");\n+\t\tMediaEntity *sink = media_->getEntityByName(\"Scaler\");\n \t\tif (!sink) {\n \t\t\tcerr << \"Unable to find entity: 'Scaler'\" << endl;\n \t\t\treturn TestFail;\n \t\t}\n \n-\t\tMediaLink *link2 = dev_->link(source, 1, sink, 0);\n+\t\tMediaLink *link2 = media_->link(source, 1, sink, 0);\n \t\tif (!link2) {\n \t\t\tcerr << \"Unable to find link: \" << linkName\n \t\t\t << \" using lookup by entity\" << endl;\n@@ -108,7 +82,7 @@ class MediaDeviceLinkTest : public Test\n \t\t\treturn TestFail;\n \t\t}\n \n-\t\tlink2 = dev_->link(source->getPadByIndex(1),\n+\t\tlink2 = media_->link(source->getPadByIndex(1),\n \t\t\t\t sink->getPadByIndex(0));\n \t\tif (!link2) {\n \t\t\tcerr << \"Unable to find link: \" << linkName\n@@ -160,7 +134,7 @@ class MediaDeviceLinkTest : public Test\n \n \t\t/* Try to get a non existing link. */\n \t\tlinkName = \"'Sensor A':[1] -> 'Scaler':[0]\";\n-\t\tlink = dev_->link(\"Sensor A\", 1, \"Scaler\", 0);\n+\t\tlink = media_->link(\"Sensor A\", 1, \"Scaler\", 0);\n \t\tif (link) {\n \t\t\tcerr << \"Link lookup for \" << linkName\n \t\t\t << \" succeeded but link does not exist\"\n@@ -170,7 +144,7 @@ class MediaDeviceLinkTest : public Test\n \n \t\t/* Now get an immutable link and try to disable it. */\n \t\tlinkName = \"'Sensor A':[0] -> 'Raw Capture 0':[0]\";\n-\t\tlink = dev_->link(\"Sensor A\", 0, \"Raw Capture 0\", 0);\n+\t\tlink = media_->link(\"Sensor A\", 0, \"Raw Capture 0\", 0);\n \t\tif (!link) {\n \t\t\tcerr << \"Unable to find link: \" << linkName\n \t\t\t << \" using lookup by name\" << endl;\n@@ -195,7 +169,7 @@ class MediaDeviceLinkTest : public Test\n \t\t * after disabling all links in the media graph.\n \t\t */\n \t\tlinkName = \"'Debayer B':[1] -> 'Scaler':[0]'\";\n-\t\tlink = dev_->link(\"Debayer B\", 1, \"Scaler\", 0);\n+\t\tlink = media_->link(\"Debayer B\", 1, \"Scaler\", 0);\n \t\tif (!link) {\n \t\t\tcerr << \"Unable to find link: \" << linkName\n \t\t\t << \" using lookup by name\" << endl;\n@@ -215,7 +189,7 @@ class MediaDeviceLinkTest : public Test\n \t\t\treturn TestFail;\n \t\t}\n \n-\t\tif (dev_->disableLinks()) {\n+\t\tif (media_->disableLinks()) {\n \t\t\tcerr << \"Failed to disable all links in the media graph\";\n \t\t\treturn TestFail;\n \t\t}\n@@ -227,17 +201,14 @@ class MediaDeviceLinkTest : public Test\n \t\t\treturn TestFail;\n \t\t}\n \n+\n \t\treturn 0;\n \t}\n \n \tvoid cleanup()\n \t{\n-\t\tdev_->release();\n+\t\tmedia_->release();\n \t}\n-\n-private:\n-\tunique_ptr enumerator;\n-\tshared_ptr dev_;\n };\n \n TEST_REGISTER(MediaDeviceLinkTest);\ndiff --git a/test/media_device/media_device_test.cpp b/test/media_device/media_device_test.cpp\nnew file mode 100644\nindex 0000000000000000..055069ad1c331cbb\n--- /dev/null\n+++ b/test/media_device/media_device_test.cpp\n@@ -0,0 +1,36 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * libcamera MediaDevice API tests\n+ */\n+\n+#include \n+\n+#include \"media_device_test.h\"\n+\n+using namespace libcamera;\n+using namespace std;\n+\n+int MediaDeviceTest::init()\n+{\n+\tenumerator_ = unique_ptr(DeviceEnumerator::create());\n+\tif (!enumerator_) {\n+\t\tcerr << \"Failed to create device enumerator\" << endl;\n+\t\treturn TestFail;\n+\t}\n+\n+\tif (enumerator_->enumerate()) {\n+\t\tcerr << \"Failed to enumerate media devices\" << endl;\n+\t\treturn TestFail;\n+\t}\n+\n+\tDeviceMatch dm(\"vimc\");\n+\tmedia_ = enumerator_->search(dm);\n+\tif (!media_) {\n+\t\tcerr << \"No VIMC media device found: skip test\" << endl;\n+\t\treturn TestSkip;\n+\t}\n+\n+\treturn TestPass;\n+}\ndiff --git a/test/media_device/media_device_test.h b/test/media_device/media_device_test.h\nnew file mode 100644\nindex 0000000000000000..cdbd14841d5ccca2\n--- /dev/null\n+++ b/test/media_device/media_device_test.h\n@@ -0,0 +1,34 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * media_device_test.h - libcamera media device test base class\n+ */\n+#ifndef __LIBCAMERA_MEDIADEVICE_TEST_H__\n+#define __LIBCAMERA_MEDIADEVICE_TEST_H__\n+\n+#include \n+\n+#include \"device_enumerator.h\"\n+#include \"media_device.h\"\n+\n+#include \"test.h\"\n+\n+using namespace libcamera;\n+\n+class MediaDeviceTest : public Test\n+{\n+public:\n+\tMediaDeviceTest()\n+\t\t: media_(nullptr), enumerator_(nullptr) {}\n+\n+protected:\n+\tint init();\n+\n+\tstd::shared_ptr media_;\n+\n+private:\n+\tstd::unique_ptr enumerator_;\n+};\n+\n+#endif /* __LIBCAMERA_MEDIADEVICE_TEST_H__ */\ndiff --git a/test/media_device/meson.build b/test/media_device/meson.build\nindex d91a022fab190abf..364b4ecf662077ac 100644\n--- a/test/media_device/meson.build\n+++ b/test/media_device/meson.build\n@@ -1,11 +1,18 @@\n+libmediadevicetest_sources = files([\n+ 'media_device_test.cpp',\n+])\n+\n media_device_tests = [\n ['media_device_print_test', 'media_device_print_test.cpp'],\n ['media_device_link_test', 'media_device_link_test.cpp'],\n ]\n \n+libmediadevicetest = static_library('libmediadevicetest', libmediadevicetest_sources,\n+ include_directories : test_includes_internal)\n+\n foreach t : media_device_tests\n exe = executable(t[0], t[1],\n- link_with : test_libraries,\n+ link_with : [test_libraries, libmediadevicetest],\n include_directories : test_includes_internal)\n \n test(t[0], exe, suite: 'media_device', is_parallel: false)\n","prefixes":["libcamera-devel","v4","05/11"]}