[{"id":16890,"web_url":"https://patchwork.libcamera.org/comment/16890/","msgid":"<581c5760-37bd-3557-6645-508be55df259@ideasonboard.com>","date":"2021-05-11T10:05:43","subject":"Re: [libcamera-devel] [PATCH/RFC 3/3] v4l2: Replace manual loop\n\tcounters with utils::enumerate()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 23/04/2021 03:09, Laurent Pinchart wrote:\n> Use the newly introduced utils::enumerate() to replace manual loop\n> counters. A local variable is needed, as utils::enumerate() requires an\n> lvalue reference.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/v4l2/v4l2_compat_manager.cpp | 18 +++++++++---------\n> 1 file changed, 9 insertions(+), 9 deletions(-)\n> \n> diff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp\n> index 90c0f0121a32..bf5bf8e3223d 100644\n> --- a/src/v4l2/v4l2_compat_manager.cpp\n> +++ b/src/v4l2/v4l2_compat_manager.cpp\n> @@ -23,6 +23,7 @@\n> #include \n> \n> #include \"libcamera/internal/log.h\"\n> +#include \"libcamera/internal/utils.h\"\n> \n> #include \"v4l2_camera_file.h\"\n> \n> @@ -81,11 +82,11 @@ int V4L2CompatManager::start()\n> \t * For each Camera registered in the system, a V4L2CameraProxy gets\n> \t * created here to wrap a camera device.\n> \t */\n> -\tunsigned int index = 0;\n> -\tfor (auto &camera : cm_->cameras()) {\n> -\t\tV4L2CameraProxy *proxy = new V4L2CameraProxy(index, camera);\n> +\tauto cameras = cm_->cameras();\n> +\tfor (const auto camera : utils::enumerate(cameras)) {\n\nIs it possible to used named scopes here like:\n\n for (const auto [index, camera] : utils::enumerate(cameras)) {\n V4L2CameraProxy *proxy = new V4L2CameraProxy(index, camera);\n\n(note, I'm asking if your series makes this possible, not for you to\nmake this change)\n\nOtherwise, I like that the index becomes part of the iteration.\nI have a slight dislike to treating your iterated item as 'value' ...\nbut that's just the same dislike I have for std::pair, but at least in\nthis case it's not named first and second!\n\nReviewed-by: Kieran Bingham \n\n\n\n> +\t\tV4L2CameraProxy *proxy = new V4L2CameraProxy(camera.index,\n> +\t\t\t\t\t\t\t camera.value);\n> \t\tproxies_.emplace_back(proxy);\n> -\t\t++index;\n> \t}\n> \n> \treturn 0;\n> @@ -117,11 +118,10 @@ int V4L2CompatManager::getCameraIndex(int fd)\n> \tif (!target)\n> \t\treturn -1;\n> \n> -\tunsigned int index = 0;\n> -\tfor (auto &camera : cm_->cameras()) {\n> -\t\tif (camera == target)\n> -\t\t\treturn index;\n> -\t\t++index;\n> +\tauto cameras = cm_->cameras();\n> +\tfor (const auto camera : utils::enumerate(cameras)) {\n> +\t\tif (camera.value == target)\n> +\t\t\treturn camera.index;\n> \t}\n> \n> \treturn -1;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96506BF829\n\tfor ;\n\tTue, 11 May 2021 10:05:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0666468918;\n\tTue, 11 May 2021 12:05:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 75CEC61538\n\tfor ;\n\tTue, 11 May 2021 12:05:46 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E83204A2;\n\tTue, 11 May 2021 12:05:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FZjzjQv0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1620727546;\n\tbh=A2NVkLoZ/8pK/q8couEAEMlECvR1DBid6VOCo0/UIzY=;\n\th=Reply-To:To:References:From:Subject:Date:In-Reply-To:From;\n\tb=FZjzjQv0Qg7ureDBShzSGi9fTTbPcx7auHK640BtFTUuMWWPIx2SJMHzE2lJJK8hH\n\tcekOp0Z2XTdeEx5X8pYjP0CXMIxisJbjcBhRhr5KZBYmerWRnBOYX9RWHCtWQ0EJup\n\tjz079da1WSXHNY6DGJlAd1ajcEEG3bZZ+Nck7kM0=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210423020932.2760-1-laurent.pinchart@ideasonboard.com>\n\t<20210423020932.2760-4-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Organization":"Ideas on Board","Message-ID":"<581c5760-37bd-3557-6645-508be55df259@ideasonboard.com>","Date":"Tue, 11 May 2021 11:05:43 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"<20210423020932.2760-4-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH/RFC 3/3] v4l2: Replace manual loop\n\tcounters with utils::enumerate()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16900,"web_url":"https://patchwork.libcamera.org/comment/16900/","msgid":"","date":"2021-05-11T11:43:10","subject":"Re: [libcamera-devel] [PATCH/RFC 3/3] v4l2: Replace manual loop\n\tcounters with utils::enumerate()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2021-04-23 05:09:32 +0300, Laurent Pinchart wrote:\n> Use the newly introduced utils::enumerate() to replace manual loop\n> counters. A local variable is needed, as utils::enumerate() requires an\n> lvalue reference.\n> \n> Signed-off-by: Laurent Pinchart \n\nI would prefers the 1/3 API but for the change itself,\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/v4l2/v4l2_compat_manager.cpp | 18 +++++++++---------\n> 1 file changed, 9 insertions(+), 9 deletions(-)\n> \n> diff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp\n> index 90c0f0121a32..bf5bf8e3223d 100644\n> --- a/src/v4l2/v4l2_compat_manager.cpp\n> +++ b/src/v4l2/v4l2_compat_manager.cpp\n> @@ -23,6 +23,7 @@\n> #include \n> \n> #include \"libcamera/internal/log.h\"\n> +#include \"libcamera/internal/utils.h\"\n> \n> #include \"v4l2_camera_file.h\"\n> \n> @@ -81,11 +82,11 @@ int V4L2CompatManager::start()\n> \t * For each Camera registered in the system, a V4L2CameraProxy gets\n> \t * created here to wrap a camera device.\n> \t */\n> -\tunsigned int index = 0;\n> -\tfor (auto &camera : cm_->cameras()) {\n> -\t\tV4L2CameraProxy *proxy = new V4L2CameraProxy(index, camera);\n> +\tauto cameras = cm_->cameras();\n> +\tfor (const auto camera : utils::enumerate(cameras)) {\n> +\t\tV4L2CameraProxy *proxy = new V4L2CameraProxy(camera.index,\n> +\t\t\t\t\t\t\t camera.value);\n> \t\tproxies_.emplace_back(proxy);\n> -\t\t++index;\n> \t}\n> \n> \treturn 0;\n> @@ -117,11 +118,10 @@ int V4L2CompatManager::getCameraIndex(int fd)\n> \tif (!target)\n> \t\treturn -1;\n> \n> -\tunsigned int index = 0;\n> -\tfor (auto &camera : cm_->cameras()) {\n> -\t\tif (camera == target)\n> -\t\t\treturn index;\n> -\t\t++index;\n> +\tauto cameras = cm_->cameras();\n> +\tfor (const auto camera : utils::enumerate(cameras)) {\n> +\t\tif (camera.value == target)\n> +\t\t\treturn camera.index;\n> \t}\n> \n> \treturn -1;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7B52CBF829\n\tfor ;\n\tTue, 11 May 2021 11:43:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3CD5A68918;\n\tTue, 11 May 2021 13:43:13 +0200 (CEST)","from mail-lf1-x131.google.com (mail-lf1-x131.google.com\n\t[IPv6:2a00:1450:4864:20::131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B8B9B61538\n\tfor ;\n\tTue, 11 May 2021 13:43:11 +0200 (CEST)","by mail-lf1-x131.google.com with SMTP id x2so28146932lff.10\n\tfor ;\n\tTue, 11 May 2021 04:43:11 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tu10sm2606359lfq.243.2021.05.11.04.43.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 11 May 2021 04:43:10 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"UIiGdsVE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=U2Y+zUjsl+RKFuy8ko4w72foyO1kPlRqnrwRQJ3GPmo=;\n\tb=UIiGdsVE7qreNXlrgJmZboUhH5BG052UGb7ac2LtKod0oapqkNcm9134zL+XrWYBdg\n\t9pTgehpptTTPIFHqlJu/wObKK4ySRcNPncKTWfGGQP5M1q1UNZmLYp+zkDvBEt+JqLYK\n\t1nNroEMXPgRu/hKyt9nn9I9uxwVI5nIYwnf26OTqQhUL1dk8SKzVOAzqKF6QjgT4i6w5\n\thp2gm/9GCYHMt7sYyfZR3Qgmcb5iND1oOGdnvP6hffLsx1BK1fpLudt8/UvhAF1eyHzO\n\tqUOdA1LiIBNoslENnSJRMOooP+t9/MyjBwG9yTb4l5bXV327l6FHHYYIpKVh11ZjXMhA\n\t7Mbw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=U2Y+zUjsl+RKFuy8ko4w72foyO1kPlRqnrwRQJ3GPmo=;\n\tb=OvSJuyXRXwqfF3xjPOAWK5govS5BLMOLW8Gq1WAjUa03qPRAtHjFKApxHUY+93ikKf\n\tqQZZFpVBaSz4t1zvTzy9JLb7XBpNJY8BN30/WMwQe3X6ScGv9CWzEI+xT1jCc4mrD1nB\n\thjXyqqahQ74zVHVFzstxLEzZtk3oIbYjjukusXVU7yzhJtPDSRXPKzw2CHy256Kdg6tE\n\tm8ZTXDFIXikLA6+U0uEDQXosjUPnrTu/Geo2rc+6n57xzVbWtQ6jFSpKBOXJwo5D0Vod\n\t8FNpCZXs8vJl4OSKtYn0XZFOLW9VVVYmxqXd5PzPYjKHTKyAjjquAUv4uOevw5XGBzvW\n\tIs0w==","X-Gm-Message-State":"AOAM532te9Kwl9i0GgMJjTWmch1OotBBfdKQyl2s09kEINpbz7DVNDPA\n\tz9z98KovMMSxB3GQ8um6mSmYvg==","X-Google-Smtp-Source":"ABdhPJxJ6HopGIq8dmj2GpsR0K6NN0PopHTuSwXdzWlgNrL/DAi/ssAZUeAxH7vRBqU6PCb2t2dhcA==","X-Received":"by 2002:a05:6512:3b9e:: with SMTP id\n\tg30mr8907160lfv.247.1620733391243; \n\tTue, 11 May 2021 04:43:11 -0700 (PDT)","Date":"Tue, 11 May 2021 13:43:10 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20210423020932.2760-1-laurent.pinchart@ideasonboard.com>\n\t<20210423020932.2760-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210423020932.2760-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH/RFC 3/3] v4l2: Replace manual loop\n\tcounters with utils::enumerate()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16951,"web_url":"https://patchwork.libcamera.org/comment/16951/","msgid":"","date":"2021-05-15T02:50:36","subject":"Re: [libcamera-devel] [PATCH/RFC 3/3] v4l2: Replace manual loop\n\tcounters with utils::enumerate()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Tue, May 11, 2021 at 11:05:43AM +0100, Kieran Bingham wrote:\n> On 23/04/2021 03:09, Laurent Pinchart wrote:\n> > Use the newly introduced utils::enumerate() to replace manual loop\n> > counters. A local variable is needed, as utils::enumerate() requires an\n> > lvalue reference.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/v4l2/v4l2_compat_manager.cpp | 18 +++++++++---------\n> > 1 file changed, 9 insertions(+), 9 deletions(-)\n> > \n> > diff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp\n> > index 90c0f0121a32..bf5bf8e3223d 100644\n> > --- a/src/v4l2/v4l2_compat_manager.cpp\n> > +++ b/src/v4l2/v4l2_compat_manager.cpp\n> > @@ -23,6 +23,7 @@\n> > #include \n> > \n> > #include \"libcamera/internal/log.h\"\n> > +#include \"libcamera/internal/utils.h\"\n> > \n> > #include \"v4l2_camera_file.h\"\n> > \n> > @@ -81,11 +82,11 @@ int V4L2CompatManager::start()\n> > \t * For each Camera registered in the system, a V4L2CameraProxy gets\n> > \t * created here to wrap a camera device.\n> > \t */\n> > -\tunsigned int index = 0;\n> > -\tfor (auto &camera : cm_->cameras()) {\n> > -\t\tV4L2CameraProxy *proxy = new V4L2CameraProxy(index, camera);\n> > +\tauto cameras = cm_->cameras();\n> > +\tfor (const auto camera : utils::enumerate(cameras)) {\n> \n> Is it possible to used named scopes here like:\n> \n> for (const auto [index, camera] : utils::enumerate(cameras)) {\n> V4L2CameraProxy *proxy = new V4L2CameraProxy(index, camera);\n> \n> (note, I'm asking if your series makes this possible, not for you to\n> make this change)\n\nIf you drop patch 2/3, yes, that's what would happen. Both you and\nNiklas seem to prefer that option, so that's what I'll do in v2.\n\n> Otherwise, I like that the index becomes part of the iteration.\n> I have a slight dislike to treating your iterated item as 'value' ...\n> but that's just the same dislike I have for std::pair, but at least in\n> this case it's not named first and second!\n> \n> Reviewed-by: Kieran Bingham \n> \n> > +\t\tV4L2CameraProxy *proxy = new V4L2CameraProxy(camera.index,\n> > +\t\t\t\t\t\t\t camera.value);\n> > \t\tproxies_.emplace_back(proxy);\n> > -\t\t++index;\n> > \t}\n> > \n> > \treturn 0;\n> > @@ -117,11 +118,10 @@ int V4L2CompatManager::getCameraIndex(int fd)\n> > \tif (!target)\n> > \t\treturn -1;\n> > \n> > -\tunsigned int index = 0;\n> > -\tfor (auto &camera : cm_->cameras()) {\n> > -\t\tif (camera == target)\n> > -\t\t\treturn index;\n> > -\t\t++index;\n> > +\tauto cameras = cm_->cameras();\n> > +\tfor (const auto camera : utils::enumerate(cameras)) {\n> > +\t\tif (camera.value == target)\n> > +\t\t\treturn camera.index;\n> > \t}\n> > \n> > \treturn -1;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B2AFC31F6\n\tfor ;\n\tSat, 15 May 2021 02:50:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F14468919;\n\tSat, 15 May 2021 04:50:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 577DC602B3\n\tfor ;\n\tSat, 15 May 2021 04:50:47 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4DE34559;\n\tSat, 15 May 2021 04:50:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tE8RcHZV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621047046;\n\tbh=wXWWeexUAl+plKUBtfIgE/4m1EhfJSVzeGa2IKHdolM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tE8RcHZVNfg/Iz7lJjtc0lAjHgs7ul+4pvSda+8cRlig49JqK5C5gZ+/OK1HzmeRS\n\tOYgfFU0fsVJPSxifrpjsL4rW3QdH6K9OGerdA6AvhRjhHuijJ07F74Bc69CZD+mjZJ\n\tthWtfyqAClicy+NLvdNKmQSivMouOhNKXIX/KCZI=","Date":"Sat, 15 May 2021 05:50:36 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210423020932.2760-1-laurent.pinchart@ideasonboard.com>\n\t<20210423020932.2760-4-laurent.pinchart@ideasonboard.com>\n\t<581c5760-37bd-3557-6645-508be55df259@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<581c5760-37bd-3557-6645-508be55df259@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH/RFC 3/3] v4l2: Replace manual loop\n\tcounters with utils::enumerate()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]