[{"id":16515,"web_url":"https://patchwork.libcamera.org/comment/16515/","msgid":"<5d2867a3-ed38-9bf3-7a2b-e3a5a5b879dd@ideasonboard.com>","date":"2021-04-22T12:59:14","subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: fix coverity issues in AWB","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi JM,\n\nOn 22/04/2021 13:41, Jean-Michel Hautbois wrote:\n> This patch fixes two minor issues detected by converity after merging in\n> master.\n\nPerhaps we can describe the patch rather than what caused it to be created?\n\n\"The BNR configuration structure has inconsistent initialisation of two\nmembers.\n\nThis was picked up by Coverity, after merge.\nWhile this code is still functional, fix them to be consistent with the\nother initialisations within the struct.\"\n\n\nFor the code change,\n\nReviewed-by: Kieran Bingham \n--\nKieran\n\n\n> Reported-by: Coverity CID=320056\n> Reported-by: Coverity CID=320058\n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/ipu3_awb.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3_awb.cpp b/src/ipa/ipu3/ipu3_awb.cpp\n> index 060d1e18..f8788065 100644\n> --- a/src/ipa/ipu3/ipu3_awb.cpp\n> +++ b/src/ipa/ipu3/ipu3_awb.cpp\n> @@ -96,14 +96,14 @@ static const struct ipu3_uapi_bnr_static_config imguCssBnrDefaults = {\n> \t.wb_gains_thr = { 255, 255, 255, 255 },\n> \t.thr_coeffs = { 1700, 0, 31, 31, 0, 16 },\n> \t.thr_ctrl_shd = { 26, 26, 26, 26 },\n> -\t.opt_center{ -648, 0, -366, 0 },\n> +\t.opt_center = { -648, 0, -366, 0 },\n> \t.lut = {\n> \t\t{ 17, 23, 28, 32, 36, 39, 42, 45,\n> \t\t 48, 51, 53, 55, 58, 60, 62, 64,\n> \t\t 66, 68, 70, 72, 73, 75, 77, 78,\n> \t\t 80, 82, 83, 85, 86, 88, 89, 90 } },\n> \t.bp_ctrl = { 20, 0, 1, 40, 0, 6, 0, 6, 0 },\n> -\t.dn_detect_ctrl{ 9, 3, 4, 0, 8, 0, 1, 1, 1, 1, 0 },\n> +\t.dn_detect_ctrl = { 9, 3, 4, 0, 8, 0, 1, 1, 1, 1, 0 },\n> \t.column_size = 1296,\n> \t.opt_center_sqr = { 419904, 133956 },\n> };\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 445F3BDB17\n\tfor ;\n\tThu, 22 Apr 2021 12:59:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ABF6D68858;\n\tThu, 22 Apr 2021 14:59:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A2E468806\n\tfor ;\n\tThu, 22 Apr 2021 14:59:18 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C7EA3EE;\n\tThu, 22 Apr 2021 14:59:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U9Ls/Cr2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619096357;\n\tbh=RK1+hW8R0mbmWnOyWsN+CnaqQQhLdO5aJfxO55gfCPI=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=U9Ls/Cr29NisuTCvpIei2unsmQgeaPaanmW1xuhzq1r8pm0fTY1wGA+Rz9ZNscFEu\n\twGF1SGDswOFCQHjtdXFK4gpfgkx7ALJiKFIhofer7616f4AGwCSzLMC2/9l6pT1Ao3\n\tFPJR7J6+ePs6p80PQSToGymIDZ6DXuYjgl7M9yO0=","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210422124123.113903-1-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","Organization":"Ideas on Board","Message-ID":"<5d2867a3-ed38-9bf3-7a2b-e3a5a5b879dd@ideasonboard.com>","Date":"Thu, 22 Apr 2021 13:59:14 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"<20210422124123.113903-1-jeanmichel.hautbois@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: fix coverity issues in AWB","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16516,"web_url":"https://patchwork.libcamera.org/comment/16516/","msgid":"","date":"2021-04-22T14:34:47","subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: fix coverity issues in AWB","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jean-Michel,\n\nNice work, this fixes gcc7 compilation for me.\n\nOn 2021-04-22 14:41:23 +0200, Jean-Michel Hautbois wrote:\n> This patch fixes two minor issues detected by converity after merging in\n> master.\n> \n> Reported-by: Coverity CID=320056\n> Reported-by: Coverity CID=320058\n> Signed-off-by: Jean-Michel Hautbois \n\nTested-by: Niklas Söderlund \n\n> ---\n> src/ipa/ipu3/ipu3_awb.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3_awb.cpp b/src/ipa/ipu3/ipu3_awb.cpp\n> index 060d1e18..f8788065 100644\n> --- a/src/ipa/ipu3/ipu3_awb.cpp\n> +++ b/src/ipa/ipu3/ipu3_awb.cpp\n> @@ -96,14 +96,14 @@ static const struct ipu3_uapi_bnr_static_config imguCssBnrDefaults = {\n> \t.wb_gains_thr = { 255, 255, 255, 255 },\n> \t.thr_coeffs = { 1700, 0, 31, 31, 0, 16 },\n> \t.thr_ctrl_shd = { 26, 26, 26, 26 },\n> -\t.opt_center{ -648, 0, -366, 0 },\n> +\t.opt_center = { -648, 0, -366, 0 },\n> \t.lut = {\n> \t\t{ 17, 23, 28, 32, 36, 39, 42, 45,\n> \t\t 48, 51, 53, 55, 58, 60, 62, 64,\n> \t\t 66, 68, 70, 72, 73, 75, 77, 78,\n> \t\t 80, 82, 83, 85, 86, 88, 89, 90 } },\n> \t.bp_ctrl = { 20, 0, 1, 40, 0, 6, 0, 6, 0 },\n> -\t.dn_detect_ctrl{ 9, 3, 4, 0, 8, 0, 1, 1, 1, 1, 0 },\n> +\t.dn_detect_ctrl = { 9, 3, 4, 0, 8, 0, 1, 1, 1, 1, 0 },\n> \t.column_size = 1296,\n> \t.opt_center_sqr = { 419904, 133956 },\n> };\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C7C31BDB15\n\tfor ;\n\tThu, 22 Apr 2021 14:34:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1542268851;\n\tThu, 22 Apr 2021 16:34:52 +0200 (CEST)","from mail-lj1-x234.google.com (mail-lj1-x234.google.com\n\t[IPv6:2a00:1450:4864:20::234])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4030F68806\n\tfor ;\n\tThu, 22 Apr 2021 16:34:50 +0200 (CEST)","by mail-lj1-x234.google.com with SMTP id a25so38810391ljm.11\n\tfor ;\n\tThu, 22 Apr 2021 07:34:50 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id u2sm279284lfl.5.2021.04.22.07.34.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 22 Apr 2021 07:34:48 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"M4oneFHo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=CWPd0OKba6ErT6lgnbcJNfpbic7ZrH50hqsIasMUOYE=;\n\tb=M4oneFHooALfGGr7HekvvvblogjnZF+dCkG7PgvP4Ra3GM3QYf0D55bBCTTc6irjzE\n\tnb29p/VTxQZ4DsAW2OqRPwwWjn+31fVRWquLcS/CWT9wNXrnblxUX4RybB8t3DNOrLin\n\tEFLHi4GMCJBJo/+vpqwRhm97q7zUvbcjEpnPebYYGIco4D4o9PaxBal0ZcogM9AnZs2m\n\tnXzykeJx0uuUVVKYTHHfE4828HF/UyqWWimcrU+1lK+i/9fc4jUDUAWtMGHzr6SZNGO5\n\tVey115BbYc9NcqL5Drge7yc+bjvFFdgNL/WXodzxrdEpPl8JwWC8mBbgR/EA6dSHXSCX\n\tgTSA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=CWPd0OKba6ErT6lgnbcJNfpbic7ZrH50hqsIasMUOYE=;\n\tb=rmtvZFJgyVD1DtHflTFJjVF+B0Lw6XU/WpYx3QZYWgnlX6qNr8cZeSrGDmxz5Z6QLV\n\t77hPyCFf1h8Q/upl9H09wNKfLAcjnht1rXAJWMolbZ/7Mbi2RUHtAbvL9sVWIryvo7QL\n\tTfX1AZ5tgxDgyYRJWudd4hRQyRWjmeMv77lU1znPekwHR/4dGFkT813Z5GRMaTd64laL\n\tfjTStHHzJU6YNdDaKLKizKP6vhaeMYUtx7oliDwSUqT35ZFYnX5Dspdg3kxpLi5YgjpJ\n\tWcf6/+Ahl8GZDFkuckfp6hg9LCTpF2szDCnBv2Ib+u0QYEzDcitHMYiEmgJcXZvP5uo/\n\t7ntA==","X-Gm-Message-State":"AOAM530nYTlFiviKE5o3ovKCdgRUurBa4L+lWPRpkHyOoH4JuX5AEkKj\n\tmuBy86H8Ai3HGS61xWKVgxXK3A==","X-Google-Smtp-Source":"ABdhPJy+xUOhGYiMdVuh01KL1STUcH7T4UFMZGiU7nELJ+I0WG6ZgHXkqPeTNxrwjj905oYqvUHfzg==","X-Received":"by 2002:a05:651c:b1e:: with SMTP id\n\tb30mr2718427ljr.202.1619102089690; \n\tThu, 22 Apr 2021 07:34:49 -0700 (PDT)","Date":"Thu, 22 Apr 2021 16:34:47 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20210422124123.113903-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210422124123.113903-1-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: fix coverity issues in AWB","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16517,"web_url":"https://patchwork.libcamera.org/comment/16517/","msgid":"","date":"2021-04-22T15:08:05","subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: fix coverity issues in AWB","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Apr 22, 2021 at 04:34:47PM +0200, Niklas Söderlund wrote:\n> Hi Jean-Michel,\n> \n> Nice work, this fixes gcc7 compilation for me.\n\nAnd with clang-9 too.\n\nWith a better commit message as mentioned by Kieran,\n\nReviewed-by: Laurent Pinchart \n\n> On 2021-04-22 14:41:23 +0200, Jean-Michel Hautbois wrote:\n> > This patch fixes two minor issues detected by converity after merging in\n> > master.\n> > \n> > Reported-by: Coverity CID=320056\n> > Reported-by: Coverity CID=320058\n> > Signed-off-by: Jean-Michel Hautbois \n> \n> Tested-by: Niklas Söderlund \n> \n> > ---\n> > src/ipa/ipu3/ipu3_awb.cpp | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/ipa/ipu3/ipu3_awb.cpp b/src/ipa/ipu3/ipu3_awb.cpp\n> > index 060d1e18..f8788065 100644\n> > --- a/src/ipa/ipu3/ipu3_awb.cpp\n> > +++ b/src/ipa/ipu3/ipu3_awb.cpp\n> > @@ -96,14 +96,14 @@ static const struct ipu3_uapi_bnr_static_config imguCssBnrDefaults = {\n> > \t.wb_gains_thr = { 255, 255, 255, 255 },\n> > \t.thr_coeffs = { 1700, 0, 31, 31, 0, 16 },\n> > \t.thr_ctrl_shd = { 26, 26, 26, 26 },\n> > -\t.opt_center{ -648, 0, -366, 0 },\n> > +\t.opt_center = { -648, 0, -366, 0 },\n> > \t.lut = {\n> > \t\t{ 17, 23, 28, 32, 36, 39, 42, 45,\n> > \t\t 48, 51, 53, 55, 58, 60, 62, 64,\n> > \t\t 66, 68, 70, 72, 73, 75, 77, 78,\n> > \t\t 80, 82, 83, 85, 86, 88, 89, 90 } },\n> > \t.bp_ctrl = { 20, 0, 1, 40, 0, 6, 0, 6, 0 },\n> > -\t.dn_detect_ctrl{ 9, 3, 4, 0, 8, 0, 1, 1, 1, 1, 0 },\n> > +\t.dn_detect_ctrl = { 9, 3, 4, 0, 8, 0, 1, 1, 1, 1, 0 },\n> > \t.column_size = 1296,\n> > \t.opt_center_sqr = { 419904, 133956 },\n> > };","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 141E1BDB17\n\tfor ;\n\tThu, 22 Apr 2021 15:08:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5668268851;\n\tThu, 22 Apr 2021 17:08:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD89968806\n\tfor ;\n\tThu, 22 Apr 2021 17:08:09 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 54E1F3EE;\n\tThu, 22 Apr 2021 17:08:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"By1kKc5m\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619104089;\n\tbh=Qs/bjpFBGNRJ63ZTBoa+FjvfBNWQxcsVGAY6ctf7A34=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=By1kKc5mVvtbP5HjMF/UYsKETTFH7aTSQFuwpsA1z+fKyjko1m/kgI4ST3xRDzfjE\n\tbRIxtRh0vZSaxa3OLaUo84tmsS/e6fISYtD9QWFvMBXqIFnIXuj8WXXME0U2ao/Jau\n\tn6s1F7m6ZIlh8KOBRj1/glhcb9xpQoHit+3NRtqg=","Date":"Thu, 22 Apr 2021 18:08:05 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"","References":"<20210422124123.113903-1-jeanmichel.hautbois@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: fix coverity issues in AWB","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]