{"id":12071,"url":"https://patchwork.libcamera.org/api/patches/12071/?format=json","web_url":"https://patchwork.libcamera.org/patch/12071/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210422094102.371772-5-paul.elder@ideasonboard.com>","date":"2021-04-22T09:40:54","name":"[libcamera-devel,RFC,v2,04/12] android: jpeg: get ISO from SENSOR_SENSITIVITY","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2eddbcb00e08cb25a8a368e1721ee1c4297b33d1","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/12071/mbox/","series":[{"id":1962,"url":"https://patchwork.libcamera.org/api/series/1962/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1962","date":"2021-04-22T09:40:50","name":"FULL hardware level fixes","version":2,"mbox":"https://patchwork.libcamera.org/series/1962/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12071/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12071/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE06FBDB17\n\tfor ;\n\tThu, 22 Apr 2021 09:41:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9192768863;\n\tThu, 22 Apr 2021 11:41:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B08896883E\n\tfor ;\n\tThu, 22 Apr 2021 11:41:20 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 54A2D9DA;\n\tThu, 22 Apr 2021 11:41:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"V4Y+o4FH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619084480;\n\tbh=uhdciWBQvoTrZ+xsu98ZFWRkzMz8ikxe354w4G5Snxg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=V4Y+o4FHSI74OxPRXI+tPufvP1CME2i4uv+IQ7JYHsqilbHyXi0wO8+E+aFepQefu\n\tXvyH2GGYzPS8Aj58PXzRu73TOh0j5cCoNEktBeDruAHIulT5JS38VhR+bfgLpjVEPj\n\tELxrN6kGqGw1JFk9bt8/lMP5MXD4uxGovOhBavdA=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 22 Apr 2021 18:40:54 +0900","Message-Id":"<20210422094102.371772-5-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210422094102.371772-1-paul.elder@ideasonboard.com>","References":"<20210422094102.371772-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC PATCH v2 04/12] android: jpeg: get ISO from\n\tSENSOR_SENSITIVITY","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The data for the exif ISO tag needs to come from SENSOR_SENSITIVITY. Set\nit.\n\nSigned-off-by: Paul Elder \n\n---\nThis on its own doesn't fix any CTS tests, but it prevents a test\nfailure later on when we add the proper static metadata for the FULL\nhardware level.\n---\n src/android/jpeg/post_processor_jpeg.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\nindex 3bf16996..237fb318 100644\n--- a/src/android/jpeg/post_processor_jpeg.cpp\n+++ b/src/android/jpeg/post_processor_jpeg.cpp\n@@ -119,7 +119,10 @@ int PostProcessorJpeg::process(const FrameBuffer &source,\n \tret = requestMetadata.getEntry(ANDROID_LENS_APERTURE, &entry);\n \tif (ret)\n \t\texif.setAperture(*entry.data.f);\n-\texif.setISO(100);\n+\n+\tret = resultMetadata->getEntry(ANDROID_SENSOR_SENSITIVITY, &entry);\n+\texif.setISO(ret ? *entry.data.i32 : 100);\n+\n \texif.setFlash(Exif::Flash::FlashNotPresent);\n \texif.setWhiteBalance(Exif::WhiteBalance::Auto);\n \n","prefixes":["libcamera-devel","RFC","v2","04/12"]}