[{"id":16609,"web_url":"https://patchwork.libcamera.org/comment/16609/","msgid":"","date":"2021-04-27T04:12:02","subject":"Re: [libcamera-devel] [RFC PATCH v2 01/12] android: camera_device:\n\tFix typo in result metadata allocation error","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Thu, Apr 22, 2021 at 06:40:51PM +0900, Paul Elder wrote:\n> Fix an error message typo s/static/result/.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 2b8fd1e6..9336a027 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -2195,7 +2195,7 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons\n> \tstd::unique_ptr resultMetadata =\n> \t\tstd::make_unique(44, 166);\n> \tif (!resultMetadata->isValid()) {\n> -\t\tLOG(HAL, Error) << \"Failed to allocate static metadata\";\n> +\t\tLOG(HAL, Error) << \"Failed to allocate result metadata\";\n> \t\treturn nullptr;\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 638A6BDCA6\n\tfor ;\n\tTue, 27 Apr 2021 04:12:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C208688A8;\n\tTue, 27 Apr 2021 06:12:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7598360512\n\tfor ;\n\tTue, 27 Apr 2021 06:12:09 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5AACAE9;\n\tTue, 27 Apr 2021 06:12:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rgI0wK8y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619496728;\n\tbh=aFp1QMaPjBKwHlE+8SxxSqztlO1oBB7HWECCVKIv3W0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rgI0wK8yRv1OJ45zWW556ivahhm7x+J66gafwJkk3FPPU7LHVx1FkxuARYx1sx4kv\n\tg87uFD3vqP3yHhem7CUCgYpxRExNuwIyToiIol9jDqGfERZ1GSfYf6fTlRtmO3iXqx\n\tOHRSD7KCkc+xpBXg9DsUJiEPRUCtvgS/9spIMo14=","Date":"Tue, 27 Apr 2021 07:12:02 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210422094102.371772-1-paul.elder@ideasonboard.com>\n\t<20210422094102.371772-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210422094102.371772-2-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH v2 01/12] android: camera_device:\n\tFix typo in result metadata allocation error","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16639,"web_url":"https://patchwork.libcamera.org/comment/16639/","msgid":"<20210427074045.p5gbs2ie5jeiu27l@uno.localdomain>","date":"2021-04-27T07:40:45","subject":"Re: [libcamera-devel] [RFC PATCH v2 01/12] android: camera_device:\n\tFix typo in result metadata allocation error","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Thu, Apr 22, 2021 at 06:40:51PM +0900, Paul Elder wrote:\n> Fix an error message typo s/static/result/.\n>\n> Signed-off-by: Paul Elder \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 2b8fd1e6..9336a027 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -2195,7 +2195,7 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons\n> \tstd::unique_ptr resultMetadata =\n> \t\tstd::make_unique(44, 166);\n> \tif (!resultMetadata->isValid()) {\n> -\t\tLOG(HAL, Error) << \"Failed to allocate static metadata\";\n> +\t\tLOG(HAL, Error) << \"Failed to allocate result metadata\";\n> \t\treturn nullptr;\n> \t}\n>\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04396BDCC3\n\tfor ;\n\tTue, 27 Apr 2021 07:40:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4068F688BB;\n\tTue, 27 Apr 2021 09:40:05 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F7C2688B5\n\tfor ;\n\tTue, 27 Apr 2021 09:40:04 +0200 (CEST)","from uno.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id A34DE200002;\n\tTue, 27 Apr 2021 07:40:03 +0000 (UTC)"],"Date":"Tue, 27 Apr 2021 09:40:45 +0200","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20210427074045.p5gbs2ie5jeiu27l@uno.localdomain>","References":"<20210422094102.371772-1-paul.elder@ideasonboard.com>\n\t<20210422094102.371772-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210422094102.371772-2-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH v2 01/12] android: camera_device:\n\tFix typo in result metadata allocation error","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]