[{"id":16523,"web_url":"https://patchwork.libcamera.org/comment/16523/","msgid":"","date":"2021-04-23T03:09:41","subject":"Re: [libcamera-devel] [PATCH v2 2/2] utils: ipc: Include instead of\n\tforward-declare CameraSensorInfo","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Thu, Apr 22, 2021 at 05:08:16PM +0900, Paul Elder wrote:\n> For structs defined in core.mojom that have the skipHeader tag, if\n> they're only used in function parameters (in a mojom file) then a\n> forward-declaration is sufficient. However, if the struct is used in\n> another struct in a mojom file, then the forward-declaration is\n> insufficient, and the definition needs to be included. Do so for\n> CameraSensorInfo, which is the only forward-declared struct in\n> ipa_interface.h, and update the documentation comment.\n\nMakes sense.\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Paul Elder \n> ---\n> New in v2\n> \n> include/libcamera/ipa/ipa_interface.h | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 5d99e2cf..dfe1b40a 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -18,15 +18,15 @@\n> #include \n> #include \n> \n> +#include \"libcamera/internal/camera_sensor.h\"\n> +\n> namespace libcamera {\n> \n> /*\n> * Structs that are defined in core.mojom and have the skipHeader tag must be\n> - * forward-declared or #included here.\n> + * #included here.\n> */\n> \n> -struct CameraSensorInfo;\n> -\n> class IPAInterface\n> {\n> public:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 43DC5BDB1A\n\tfor ;\n\tFri, 23 Apr 2021 03:09:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 856D86886D;\n\tFri, 23 Apr 2021 05:09:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9CF8160513\n\tfor ;\n\tFri, 23 Apr 2021 05:09:46 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE3A3EE;\n\tFri, 23 Apr 2021 05:09:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bEHiUAgM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619147386;\n\tbh=0Q3I0bsK11uk29nA+el0DoHFV9Z00lwZnHoLmnIp0qc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bEHiUAgMJHF+qKi4mcwNIsvNx6WnoUa1R3WucRRLKEZxUMzdY9WJWbimk2RKyF48h\n\tbH8dVwsI26oAZjwMh1wp+/ty/Flh6+XQLadICBsSzAjHDVOb+6SvpLtv6zpTBxrkiu\n\tkXb6y/UqwXHHdILPh1SXAtl4PopIdTDKs1R8Gxn8=","Date":"Fri, 23 Apr 2021 06:09:41 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210422080816.364948-1-paul.elder@ideasonboard.com>\n\t<20210422080816.364948-3-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210422080816.364948-3-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] utils: ipc: Include instead of\n\tforward-declare CameraSensorInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16524,"web_url":"https://patchwork.libcamera.org/comment/16524/","msgid":"","date":"2021-04-23T03:15:16","subject":"Re: [libcamera-devel] [PATCH v2 2/2] utils: ipc: Include instead of\n\tforward-declare CameraSensorInfo","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Apr 23, 2021 at 06:09:42AM +0300, Laurent Pinchart wrote:\n> On Thu, Apr 22, 2021 at 05:08:16PM +0900, Paul Elder wrote:\n> > For structs defined in core.mojom that have the skipHeader tag, if\n> > they're only used in function parameters (in a mojom file) then a\n> > forward-declaration is sufficient. However, if the struct is used in\n> > another struct in a mojom file, then the forward-declaration is\n> > insufficient, and the definition needs to be included. Do so for\n> > CameraSensorInfo, which is the only forward-declared struct in\n> > ipa_interface.h, and update the documentation comment.\n> \n> Makes sense.\n> \n> Reviewed-by: Laurent Pinchart \n\nActually, you also need to update a comment in core.mojom.\n\n> > Signed-off-by: Paul Elder \n> > ---\n> > New in v2\n> > \n> > include/libcamera/ipa/ipa_interface.h | 6 +++---\n> > 1 file changed, 3 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> > index 5d99e2cf..dfe1b40a 100644\n> > --- a/include/libcamera/ipa/ipa_interface.h\n> > +++ b/include/libcamera/ipa/ipa_interface.h\n> > @@ -18,15 +18,15 @@\n> > #include \n> > #include \n> > \n> > +#include \"libcamera/internal/camera_sensor.h\"\n> > +\n> > namespace libcamera {\n> > \n> > /*\n> > * Structs that are defined in core.mojom and have the skipHeader tag must be\n> > - * forward-declared or #included here.\n> > + * #included here.\n> > */\n> > \n> > -struct CameraSensorInfo;\n> > -\n> > class IPAInterface\n> > {\n> > public:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34F64BDB15\n\tfor ;\n\tFri, 23 Apr 2021 03:15:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B2D36886D;\n\tFri, 23 Apr 2021 05:15:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F2FB60513\n\tfor ;\n\tFri, 23 Apr 2021 05:15:22 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E359EE;\n\tFri, 23 Apr 2021 05:15:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RIAEQuB1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619147721;\n\tbh=JMKGMIjJhjuSOKJmGO2TGwi36TyTh0Pqm4MdvN2pcqQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RIAEQuB1iRZHayAZvLeP8ukiDACXNnIedpWjJK9fIfZ2PxTd+m5btbMitXjCY5KtG\n\tBvRTKvfQ2wRKPs5EyCvZyrnz8zodUxleEf05LFE8rnXgvEi87VSMJeXnXuaZlj2X5N\n\tVL2ohv/olwZM4cHzWhNf2PQtCgIXWq4cD8DYeQNY=","Date":"Fri, 23 Apr 2021 06:15:16 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210422080816.364948-1-paul.elder@ideasonboard.com>\n\t<20210422080816.364948-3-paul.elder@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] utils: ipc: Include instead of\n\tforward-declare CameraSensorInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]