[{"id":16468,"web_url":"https://patchwork.libcamera.org/comment/16468/","msgid":"","date":"2021-04-21T18:49:27","subject":"Re: [libcamera-devel] [PATCH v3 14/16] cam: Add option to print the\n\tRequest metadata","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2021-04-21 18:03:17 +0200, Jacopo Mondi wrote:\n> Add the \"--metadata\" option to the cam tool, which will be used to\n> print the metadata associated with a completed capture request.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/cam/main.cpp | 3 +++\n> src/cam/main.h | 1 +\n> 2 files changed, 4 insertions(+)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index 994fbb343029..687142d8b1a8 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -197,6 +197,9 @@ int CamApp::parseOptions(int argc, char *argv[])\n> \tparser.addOption(OptStrictFormats, OptionNone,\n> \t\t\t \"Do not allow requested stream format(s) to be adjusted\",\n> \t\t\t \"strict-formats\");\n> +\tparser.addOption(OptMetadata, OptionNone,\n> +\t\t\t \"Print the list of metadata associated with each completed capture request\",\n> +\t\t\t \"metadata\");\n> \n> \toptions_ = parser.parse(argc, argv);\n> \tif (!options_.valid())\n> diff --git a/src/cam/main.h b/src/cam/main.h\n> index ea8dfd330830..d22451f59817 100644\n> --- a/src/cam/main.h\n> +++ b/src/cam/main.h\n> @@ -19,6 +19,7 @@ enum {\n> \tOptStream = 's',\n> \tOptListControls = 256,\n> \tOptStrictFormats = 257,\n> +\tOptMetadata = 258,\n> };\n> \n> #endif /* __CAM_MAIN_H__ */\n> -- \n> 2.31.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A373BBDB15\n\tfor ;\n\tWed, 21 Apr 2021 18:49:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5AF7B68847;\n\tWed, 21 Apr 2021 20:49:30 +0200 (CEST)","from mail-lj1-x233.google.com (mail-lj1-x233.google.com\n\t[IPv6:2a00:1450:4864:20::233])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 883B868840\n\tfor ;\n\tWed, 21 Apr 2021 20:49:28 +0200 (CEST)","by mail-lj1-x233.google.com with SMTP id a5so11915581ljk.0\n\tfor ;\n\tWed, 21 Apr 2021 11:49:28 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id 5sm39130lfy.15.2021.04.21.11.49.27\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 21 Apr 2021 11:49:27 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"EK/HXrWi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=4krDZ7hbgK9A3xcLTzBS3tg636x2O8uxG5VBqgdOZMA=;\n\tb=EK/HXrWift0MqZyffeucCKAJUTJnnRK0GTB8tFONQPi2ur3sFyimcrZJpiv/PeUaEL\n\tFEy37NiRrJRZD47Lez5bhwHDfSaqVaNfnSKMnqPrzAZpwNrfPUKECZVXGJx1boEw8OB5\n\tOSjrD2GXvmRTDP0PIZmBFe6WVu+WcbsSnSchBjqAOGcZ2fy8M/OYNLe06orJmzKwHd12\n\tQT286fGr0/mJz4woGJw0nRwJrznCywiWut7HxXre1penXzBe9UaZVvigP9yCHOjoLkMs\n\tJmlyVgVmIuAhz64Tqy8HpZaCvKMYykauUerrT2znz/wQi//eEYCGH3XCiKZS8kxW7Zp+\n\tXRKw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=4krDZ7hbgK9A3xcLTzBS3tg636x2O8uxG5VBqgdOZMA=;\n\tb=TxWHIeI/xox3X+lOqHzoSZIjaELZVRGlKHxm/BsPgmDAGpcHNwrI/h0CuZSblgqgAV\n\tbABrLF+ln7ZWz6bFhcUltuD079Myqaq8bzzR0twE4bsJPCkFoyOL13bwgCuhGvVhYm44\n\tbRO/gu9vJeXrI4wkE7/5yuCu4bly1i6hfDh4K1sW2m7ecng2WtP9PtHoB1HpHSalYsA9\n\t5vfYCDWzgEoR3l4lE/f0QLT9sMA+8eguTAHKN5FnlSKn6Y/hpnh8SQWkaP4pxuV0EHdo\n\tKsD5UtOuRIERXlh5YZ232m8g1tYW3suuytMjbgViT8m1osjlV2IJ8KJ9PzKmkdriU3hs\n\tZfaw==","X-Gm-Message-State":"AOAM533EXnYVrzjeoeqzuGDnanmY6ELXljAAiDTkJDVCpn1rAhIHKdkL\n\tDWTmz3Sm1zVWuMt65kleSEpf/3qgcwXigM+a","X-Google-Smtp-Source":"ABdhPJxsVdzjeTROtondDKOVGXYd1WVTBYYmTtI7uUTchThXL3UepVklUsgG2VEQ91eArdC7t/IpKQ==","X-Received":"by 2002:a2e:b810:: with SMTP id\n\tu16mr18025092ljo.300.1619030968056; \n\tWed, 21 Apr 2021 11:49:28 -0700 (PDT)","Date":"Wed, 21 Apr 2021 20:49:27 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210421160319.42251-1-jacopo@jmondi.org>\n\t<20210421160319.42251-15-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210421160319.42251-15-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 14/16] cam: Add option to print the\n\tRequest metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16486,"web_url":"https://patchwork.libcamera.org/comment/16486/","msgid":"","date":"2021-04-22T05:41:14","subject":"Re: [libcamera-devel] [PATCH v3 14/16] cam: Add option to print the\n\tRequest metadata","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Jacopo, thank you for the patch.\n\nOn Thu, Apr 22, 2021 at 3:49 AM Niklas Söderlund\n wrote:\n>\n> Hi Jacopo,\n>\n> Thanks for your patch.\n>\n> On 2021-04-21 18:03:17 +0200, Jacopo Mondi wrote:\n> > Add the \"--metadata\" option to the cam tool, which will be used to\n> > print the metadata associated with a completed capture request.\n> >\n> > Signed-off-by: Jacopo Mondi \n>\n> Reviewed-by: Niklas Söderlund \n>\n\nReviewed-by: Hirokazu Honda \n\n> > ---\n> > src/cam/main.cpp | 3 +++\n> > src/cam/main.h | 1 +\n> > 2 files changed, 4 insertions(+)\n> >\n> > diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> > index 994fbb343029..687142d8b1a8 100644\n> > --- a/src/cam/main.cpp\n> > +++ b/src/cam/main.cpp\n> > @@ -197,6 +197,9 @@ int CamApp::parseOptions(int argc, char *argv[])\n> > parser.addOption(OptStrictFormats, OptionNone,\n> > \"Do not allow requested stream format(s) to be adjusted\",\n> > \"strict-formats\");\n> > + parser.addOption(OptMetadata, OptionNone,\n> > + \"Print the list of metadata associated with each completed capture request\",\n> > + \"metadata\");\n> >\n> > options_ = parser.parse(argc, argv);\n> > if (!options_.valid())\n> > diff --git a/src/cam/main.h b/src/cam/main.h\n> > index ea8dfd330830..d22451f59817 100644\n> > --- a/src/cam/main.h\n> > +++ b/src/cam/main.h\n> > @@ -19,6 +19,7 @@ enum {\n> > OptStream = 's',\n> > OptListControls = 256,\n> > OptStrictFormats = 257,\n> > + OptMetadata = 258,\n> > };\n> >\n> > #endif /* __CAM_MAIN_H__ */\n> > --\n> > 2.31.1\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 207D6BDB15\n\tfor ;\n\tThu, 22 Apr 2021 05:41:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A49C06884C;\n\tThu, 22 Apr 2021 07:41:27 +0200 (CEST)","from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com\n\t[IPv6:2a00:1450:4864:20::52a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A75626884B\n\tfor ;\n\tThu, 22 Apr 2021 07:41:25 +0200 (CEST)","by mail-ed1-x52a.google.com with SMTP id s15so51945329edd.4\n\tfor ;\n\tWed, 21 Apr 2021 22:41:25 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"O1DybK6y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=ZhWVKjtM1ZsLa2KydozyAjzdgpM0RPUmqs63xC9V2YE=;\n\tb=O1DybK6y6oP6bwzYoXTFJ8ueN+t8B9L54sWKd7Zh8Qh8PtLzldosOl4ynxUgyzV52J\n\tSC0PCkrDLr6vVfUb+EceNVsONcNAMMyDH0DG3Rh2JglUC7Se+dY8xPuYR4yeQoeCw+7D\n\tJVzkMDni/Qs8NOEXclAtIqEkbql92yAUhCFbA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=ZhWVKjtM1ZsLa2KydozyAjzdgpM0RPUmqs63xC9V2YE=;\n\tb=n1QnqafHD25RXgYQloNX3xgv5y8lZaiT/wocQsgNOCiso1DcLKafa3oSi5jtuvfMgz\n\tvcOd/Xji15nOKCww6dOIQEYdGVsQc505jmkSZqyeEd35MZLPoFpogwCONt6k2d8eL4op\n\tLDbWYBW5YAtERWaUnNqHE2R4j40P5lb8ccptIXw3PctEEiGcDRnGmGhV8KEprobNH0yl\n\tC7DHu8zZK+cmVYj56hYZU3pZj/b4ziUoGgbd1TIiPAkhjR/Nb9nRxzHjWuDM/00E8/2i\n\tUUwiD/41b+iZmuThc+y6Bk/AgzZjJNuLXWmrlbt4ye8t83PnEHqEaivKNUzwe5WqBbP9\n\tYzAQ==","X-Gm-Message-State":"AOAM531jjo1OCxSQ8kO6iDt7vWeeLf5CiJ4yh0EEFi93DCuEXZ2OmZr6\n\trH5IuUuOWVBbwwnjTQQrFPb5ySJLr++kG8QjFdZ17w226VU=","X-Google-Smtp-Source":"ABdhPJxNUwHVlEiHuGu2DT+3OG1STvJHO/rRNso9ErWy7cRpfh4W5Y/KJChO07NpE/P7nnwbJK7gs5ELNlpHV3lFVCo=","X-Received":"by 2002:aa7:d48a:: with SMTP id\n\tb10mr1591202edr.202.1619070085381; \n\tWed, 21 Apr 2021 22:41:25 -0700 (PDT)","MIME-Version":"1.0","References":"<20210421160319.42251-1-jacopo@jmondi.org>\n\t<20210421160319.42251-15-jacopo@jmondi.org>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Thu, 22 Apr 2021 14:41:14 +0900","Message-ID":"","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","Subject":"Re: [libcamera-devel] [PATCH v3 14/16] cam: Add option to print the\n\tRequest metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16563,"web_url":"https://patchwork.libcamera.org/comment/16563/","msgid":"","date":"2021-04-26T05:07:57","subject":"Re: [libcamera-devel] [PATCH v3 14/16] cam: Add option to print the\n\tRequest metadata","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Apr 21, 2021 at 06:03:17PM +0200, Jacopo Mondi wrote:\n> Add the \"--metadata\" option to the cam tool, which will be used to\n> print the metadata associated with a completed capture request.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/cam/main.cpp | 3 +++\n> src/cam/main.h | 1 +\n> 2 files changed, 4 insertions(+)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index 994fbb343029..687142d8b1a8 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -197,6 +197,9 @@ int CamApp::parseOptions(int argc, char *argv[])\n> \tparser.addOption(OptStrictFormats, OptionNone,\n> \t\t\t \"Do not allow requested stream format(s) to be adjusted\",\n> \t\t\t \"strict-formats\");\n> +\tparser.addOption(OptMetadata, OptionNone,\n> +\t\t\t \"Print the list of metadata associated with each completed capture request\",\n\nI would have shortened this a bit to avoid too long lines, maybe to\n\"Print the metadata for completed requests\", but it doesn't matter that\nmuch.\n\nReviewed-by: Laurent Pinchart \n\n> +\t\t\t \"metadata\");\n> \n> \toptions_ = parser.parse(argc, argv);\n> \tif (!options_.valid())\n> diff --git a/src/cam/main.h b/src/cam/main.h\n> index ea8dfd330830..d22451f59817 100644\n> --- a/src/cam/main.h\n> +++ b/src/cam/main.h\n> @@ -19,6 +19,7 @@ enum {\n> \tOptStream = 's',\n> \tOptListControls = 256,\n> \tOptStrictFormats = 257,\n> +\tOptMetadata = 258,\n> };\n> \n> #endif /* __CAM_MAIN_H__ */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A37DBDC92\n\tfor ;\n\tMon, 26 Apr 2021 05:08:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 79907688A7;\n\tMon, 26 Apr 2021 07:08:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B033605BD\n\tfor ;\n\tMon, 26 Apr 2021 07:08:03 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EBFC4FB;\n\tMon, 26 Apr 2021 07:08:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WcrZdx7j\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619413682;\n\tbh=x3Oy0Md4VzSbxf9TMRWm7ZDJT5l5T1Iv9E1UlsFojew=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WcrZdx7jM+s/8F1339KnXuO4GAMWWwEZWEy8CrM+t71cL0IM4HzfwD+IJ9yauBJ9G\n\tSMtiZJBgO0qa6VeB0RmlzEUkO9UQMwxTAcr1CHlfIXM7YYXZOKlYHJW6clVlE5O1Bl\n\tMyUmbgAima5G3Eso7+Eu/CUv4JL7yU+7o2YIx1x8=","Date":"Mon, 26 Apr 2021 08:07:57 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210421160319.42251-1-jacopo@jmondi.org>\n\t<20210421160319.42251-15-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210421160319.42251-15-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 14/16] cam: Add option to print the\n\tRequest metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]