{"id":12041,"url":"https://patchwork.libcamera.org/api/patches/12041/?format=json","web_url":"https://patchwork.libcamera.org/patch/12041/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210421160319.42251-10-jacopo@jmondi.org>","date":"2021-04-21T16:03:12","name":"[libcamera-devel,v3,09/16] libcamera: simple: Report sensor timestamp","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ee612ad1c896670d38468a459f78c4e6b9b7c51e","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/12041/mbox/","series":[{"id":1957,"url":"https://patchwork.libcamera.org/api/series/1957/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1957","date":"2021-04-21T16:03:03","name":"Support SensorTimestamp metadata","version":3,"mbox":"https://patchwork.libcamera.org/series/1957/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12041/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12041/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 71625BDB17\n\tfor ;\n\tWed, 21 Apr 2021 16:02:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0549868850;\n\tWed, 21 Apr 2021 18:02:57 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4482568850\n\tfor ;\n\tWed, 21 Apr 2021 18:02:49 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id DD61F240012;\n\tWed, 21 Apr 2021 16:02:48 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 21 Apr 2021 18:03:12 +0200","Message-Id":"<20210421160319.42251-10-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210421160319.42251-1-jacopo@jmondi.org>","References":"<20210421160319.42251-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 09/16] libcamera: simple: Report sensor\n\ttimestamp","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Report the sensor's timestamp in the Request metadata using the\ncompleted buffer timestamp.\n\nThe buffer's timestamp is recorded at DMA-transfer time, and it does not\ntheoretically matches the 'start of exposure' definition. Record this with\na \\todo entry.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/simple/simple.cpp | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex f6095d38e97a..e1ee640b0a92 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -22,6 +22,7 @@\n #include \n \n #include \n+#include \n #include \n #include \n \n@@ -1116,6 +1117,16 @@ void SimplePipelineHandler::bufferReady(FrameBuffer *buffer)\n \t\treturn;\n \t}\n \n+\t/*\n+\t * Record the sensor's timestamp in the request metadata.\n+\t *\n+\t * \\todo The sensor timestamp should be better estimated by connecting\n+\t * to the V4L2Device::frameStart signal if the platform provides it.\n+\t */\n+\tRequest *request = buffer->request();\n+\trequest->metadata().set(controls::SensorTimestamp,\n+\t\t\t\tbuffer->metadata().timestamp);\n+\n \t/*\n \t * Queue the captured and the request buffer to the converter if format\n \t * conversion is needed. If there's no queued request, just requeue the\n@@ -1133,7 +1144,6 @@ void SimplePipelineHandler::bufferReady(FrameBuffer *buffer)\n \t}\n \n \t/* Otherwise simply complete the request. */\n-\tRequest *request = buffer->request();\n \tcompleteBuffer(request, buffer);\n \tcompleteRequest(request);\n }\n","prefixes":["libcamera-devel","v3","09/16"]}