[{"id":16481,"web_url":"https://patchwork.libcamera.org/comment/16481/","msgid":"","date":"2021-04-22T04:54:48","subject":"Re: [libcamera-devel] [PATCH v3 08/16] libcamera: rkisp1: Report\n\tsensor timestamp","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Jacopo, thank you for the patch.\n\nOn Thu, Apr 22, 2021 at 1:02 AM Jacopo Mondi wrote:\n>\n> Report the sensor's timestamp in the Request metadata using the\n> completed buffer timestamp.\n>\n> The buffer's timestamp is recorded at DMA-transfer time, and it does not\n> theoretically matches the 'start of exposure' definition. Record this with\n> a \\todo entry.\n>\n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index c3d390f775f2..da57624a2817 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -1067,6 +1067,15 @@ void PipelineHandlerRkISP1::bufferReady(FrameBuffer *buffer)\n> {\n> Request *request = buffer->request();\n>\n> + /*\n> + * Record the sensor's timestamp in the request metadata.\n> + *\n> + * \\todo The sensor timestamp should be better estimated by connecting\n> + * to the V4L2Device::frameStart signal.\n> + */\n> + request->metadata().set(controls::SensorTimestamp,\n> + buffer->metadata().timestamp);\n> +\n\nReviewed-by: Hirokazu Honda \n\n> completeBuffer(request, buffer);\n> tryCompleteRequest(request);\n> }\n> --\n> 2.31.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5FBF0BDB17\n\tfor ;\n\tThu, 22 Apr 2021 04:55:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C9D6B6884C;\n\tThu, 22 Apr 2021 06:55:01 +0200 (CEST)","from mail-ej1-x636.google.com (mail-ej1-x636.google.com\n\t[IPv6:2a00:1450:4864:20::636])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F159260516\n\tfor ;\n\tThu, 22 Apr 2021 06:54:59 +0200 (CEST)","by mail-ej1-x636.google.com with SMTP id w3so66809635ejc.4\n\tfor ;\n\tWed, 21 Apr 2021 21:54:59 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"fmGTdiQv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=Hpv1W4T4KZZsyoON9LE0PigvbPi3Bn8oudeByy4ZLG8=;\n\tb=fmGTdiQvLdaHR5gG2Rvqq7faB9v3BumoZ+amPorjLq3V3vXY5SJySc8nLRrhFODwBn\n\tQh/iKPQjoX/DgwTgeA7x76EwFz/anJ+9wOS8kDV8lLpVetFGI17iowaXOJ/wNJ0KJoNy\n\tvUiTtXs/LaVYbEXzy63bn73IfdHygcy1VxVJY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Hpv1W4T4KZZsyoON9LE0PigvbPi3Bn8oudeByy4ZLG8=;\n\tb=EIlILthSqvIwYuJeHwCKnuEA5GUg01bEo5zdsZNXUe6de62ZNEsRYGDsiZa7UkU120\n\tVdh0gJbO2Qu7JZB+yN41uCYkUKwklJPp2wvH7iOIiDUrPw87f9W7nS8b0nv4qMEcuaeB\n\tVN3w78QUjTT8ma8Eue9a2UYTh+ecbIiElvsEKb6oVh7HW63aU4I91YhTwAZRxNTn/46Y\n\tzAbeXmJRo9za4M0c329bk+QeRM9yDgEUUm91vep766jEJJbZEdwbntWSNqtzNJ2IjPcm\n\taxmBhFoTvEy0lyUvL8By9PrO6Xii59sEkN+U72CYFX2LTEgRa5Q5u9ra4ME69h7CGD3x\n\tj5lQ==","X-Gm-Message-State":"AOAM530Gb0hSCszIC7FLLdOwTGUCp0FWTN9nZo0oHS7mXe7doJJAA3Z8\n\tEBFDjQpDvlzU+2Swej22Nr5dQby+nHUZjvdRnP8dZQ==","X-Google-Smtp-Source":"ABdhPJz6WK1WX7s9MinEbq/iz9YA+RcRUAmphFV4uPogLM21QOl2oyR9KKKMCr4u6Ehl/Lqml4QRDmWxMsSC16tQtz4=","X-Received":"by 2002:a17:906:13d6:: with SMTP id\n\tg22mr1290236ejc.475.1619067299744; \n\tWed, 21 Apr 2021 21:54:59 -0700 (PDT)","MIME-Version":"1.0","References":"<20210421160319.42251-1-jacopo@jmondi.org>\n\t<20210421160319.42251-9-jacopo@jmondi.org>","In-Reply-To":"<20210421160319.42251-9-jacopo@jmondi.org>","From":"Hirokazu Honda ","Date":"Thu, 22 Apr 2021 13:54:48 +0900","Message-ID":"","To":"Jacopo Mondi ","Subject":"Re: [libcamera-devel] [PATCH v3 08/16] libcamera: rkisp1: Report\n\tsensor timestamp","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]