[{"id":16479,"web_url":"https://patchwork.libcamera.org/comment/16479/","msgid":"","date":"2021-04-22T04:35:10","subject":"Re: [libcamera-devel] [PATCH v3 06/16] libcamera: uvc: Report\n\tsensor timestamp","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Jacopo, thank you for the patch.\n\nOn Thu, Apr 22, 2021 at 1:02 AM Jacopo Mondi wrote:\n>\n> Report the sensor's timestamp in the Request metadata using the\n> completed buffer timestamp.\n>\n> The UVC driver reports timestamps of SOE event through metadata, for\n> which there is no support in the current pipeline implementation.\n>\n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Hirokazu Honda \n\n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index b6c6ade5ebaf..faa8d6b05f46 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -662,6 +662,10 @@ void UVCCameraData::bufferReady(FrameBuffer *buffer)\n> {\n> Request *request = buffer->request();\n>\n> + /* \\todo Use the UVC metadata to calculate a more precise timestamp */\n> + request->metadata().set(controls::SensorTimestamp,\n> + buffer->metadata().timestamp);\n> +\n> pipe_->completeBuffer(request, buffer);\n> pipe_->completeRequest(request);\n> }\n> --\n> 2.31.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2917FBDB15\n\tfor ;\n\tThu, 22 Apr 2021 04:35:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A390B68847;\n\tThu, 22 Apr 2021 06:35:23 +0200 (CEST)","from mail-ej1-x630.google.com (mail-ej1-x630.google.com\n\t[IPv6:2a00:1450:4864:20::630])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A7E460516\n\tfor ;\n\tThu, 22 Apr 2021 06:35:21 +0200 (CEST)","by mail-ej1-x630.google.com with SMTP id g5so59989015ejx.0\n\tfor ;\n\tWed, 21 Apr 2021 21:35:21 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"F2kxawh1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=tk5iIVvOABuIjNi1k/btOvhyejZkDXZ9IdZv3ASoHM8=;\n\tb=F2kxawh14Cm0eTTVfdM+FJ2xXi4Hg2UhGUxnG7/VSlVkI3iYarkZwE7IzqkEFEZy9H\n\txFOpLwikH20m7fiuY5WjSmk8+xe32z+SEEZekoiUUD51tLDirdKZ9Ie6p2g4JrRNG0zh\n\tGqaL6IEq697jSUEOLdu79TnreI+A6mgtTuyIU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=tk5iIVvOABuIjNi1k/btOvhyejZkDXZ9IdZv3ASoHM8=;\n\tb=a11NSYwizfD2uOlsSgu0vyPuEt4lsKfIyl6H8TQwkJPnB5jKON9oZ9Y347R5psNn6V\n\tD1op1Z8c1dtsXPM4RHW+FimiRp4tU8zXysgO4Onl9nexhiTMRAVv45Hjk/6F4mLa7Yyp\n\t/c5SBdSLK7RyJUYKlhuxLuDOsGuCBxtwQ0y3XIEUn8TFSBvCQngCeJYx3VJ79+w4LMAf\n\tP139NfXNMhAVfwkETw/zZsZncop83GwbiqeqIahKG7oUJA8dcUEIxU7PUCtqoSAmIhUj\n\tONEFGZC6neet0025KVC5XONu7DH31AeK1gWdjoztEGTaqSr9Rh1nffTn9OpA7vAvinGT\n\tu2gg==","X-Gm-Message-State":"AOAM531Kzb6KdlYCARAx9XhGUjDYiG7bIaM6SwBhZ7zo2HJMhYHxXVnt\n\tyICFYJNhrlTp7wjAnQBthRL2IWhDmXD6LXuL0sG6Gm079gw=","X-Google-Smtp-Source":"ABdhPJw+hXI6M3FmjeSjg82O18211Iy1L/INx7ijJBbakSVoqKwHukL6no1DYXXl7OCwEpR4u544QRsVuVenb0cIzdA=","X-Received":"by 2002:a17:906:46d6:: with SMTP id\n\tk22mr1208534ejs.243.1619066121275; \n\tWed, 21 Apr 2021 21:35:21 -0700 (PDT)","MIME-Version":"1.0","References":"<20210421160319.42251-1-jacopo@jmondi.org>\n\t<20210421160319.42251-7-jacopo@jmondi.org>","In-Reply-To":"<20210421160319.42251-7-jacopo@jmondi.org>","From":"Hirokazu Honda ","Date":"Thu, 22 Apr 2021 13:35:10 +0900","Message-ID":"","To":"Jacopo Mondi ","Subject":"Re: [libcamera-devel] [PATCH v3 06/16] libcamera: uvc: Report\n\tsensor timestamp","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]