[{"id":16463,"web_url":"https://patchwork.libcamera.org/comment/16463/","msgid":"","date":"2021-04-21T18:14:43","subject":"Re: [libcamera-devel] [PATCH v3 03/16] test: control_list: Test\n\tControlList::merge()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2021-04-21 18:03:06 +0200, Jacopo Mondi wrote:\n> Test the newly introduce ControlList::merge() method by creating\n\nnit: s/newly introduce//\n\n> a new list with a single control and merging it with the existing one.\n> \n> Test that the merged list contains all the controls and their values\n> are not changed.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> test/controls/control_list.cpp | 40 ++++++++++++++++++++++++++++++++++\n> 1 file changed, 40 insertions(+)\n> \n> diff --git a/test/controls/control_list.cpp b/test/controls/control_list.cpp\n> index 2b321ddd6fa4..91b38993abf9 100644\n> --- a/test/controls/control_list.cpp\n> +++ b/test/controls/control_list.cpp\n> @@ -150,6 +150,46 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\t/*\n> +\t\t * Create a new list with a new control and merge it with the\n> +\t\t * existing one, verifying that the existing controls\n> +\t\t * values does not get changed.\n> +\t\t */\n> +\t\tControlList mergeList(controls::controls, &validator);\n> +\t\tmergeList.set(controls::Saturation, 0.4f);\n> +\n> +\t\tmergeList.merge(list);\n> +\t\tif (mergeList.size() != 3) {\n> +\t\t\tcout << \"Merged list should contain three elements\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (!mergeList.contains(controls::Brightness) ||\n> +\t\t !mergeList.contains(controls::Contrast) ||\n> +\t\t !mergeList.contains(controls::Saturation)) {\n> +\t\t\tcout << \"Merged list does not contain all controls it should\"\n> +\t\t\t << endl;\n\nnit: s/ it should//\n\nWith or without the nits fixed,\n\nReviewed-by: Niklas Söderlund \n\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (mergeList.get(controls::Brightness) != 0.5f) {\n> +\t\t\tcout << \"Brightness control value changed after merging lists\"\n> +\t\t\t << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (mergeList.get(controls::Contrast) != 1.1f) {\n> +\t\t\tcout << \"Contrast control value changed after merging lists\"\n> +\t\t\t << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (mergeList.get(controls::Saturation) != 0.4f) {\n> +\t\t\tcout << \"Saturation control value changed after merging lists\"\n> +\t\t\t << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\treturn TestPass;\n> \t}\n> };\n> -- \n> 2.31.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0587BDB15\n\tfor ;\n\tWed, 21 Apr 2021 18:14:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 508DF6884A;\n\tWed, 21 Apr 2021 20:14:46 +0200 (CEST)","from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com\n\t[IPv6:2a00:1450:4864:20::12c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2A16C68835\n\tfor ;\n\tWed, 21 Apr 2021 20:14:45 +0200 (CEST)","by mail-lf1-x12c.google.com with SMTP id t14so11060153lfe.1\n\tfor ;\n\tWed, 21 Apr 2021 11:14:45 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id l6sm31581lfp.13.2021.04.21.11.14.43\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 21 Apr 2021 11:14:44 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"Ar/QhnwK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=LZTdqzFR1itrBeVpo8r+3Ep25d9ZAViUzb16cA0QUDg=;\n\tb=Ar/QhnwKUB7SFu2HnTr4aom6aR8MQpWxRMa3x7EwoCsEldgwdVxitwOUiZ4HocRKM3\n\teKhOa+V9kNLI1K8mevmNyh2jGr4IcM5M3XgLXUzoSxX3XVQmmxFut/Z+meQTuHiuUekd\n\tSVncXWnzpdTik7jnsMtThA3TMfS/lsI0wYYu0WGUYEpzeK3yExCcXJWKr8ms3gKe53u4\n\tQpeylN2AWhc8XqWFj6C9f3wcpdZbps33E2AYOcfJ7HaVx2ThzTTLjGyeBs/n9ShzyVoJ\n\tiTnCM2u4MIIXRYw3i9rHdJK165mQwZeImzkJ4kqgP/gtZrtWiPziKW/3DFXiPkS1j9X2\n\tE6sw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=LZTdqzFR1itrBeVpo8r+3Ep25d9ZAViUzb16cA0QUDg=;\n\tb=szSdTR5cmQRAebCG26TJT+nS5MNY8H4uP6KyY7q9JWk27tjpuxabfsnuG/wnvQ86uw\n\tjcxm5gYetUvul2Qv8JcFVLlr2RybE0fBF+lKbumrmaKoFr5W2eVqG/Y8bPf/LDBwkBBf\n\t4Bz4Ifen5fqlbYB/iOQUEZ1q8nakND4P2hpWNn93J9lZAzU3srYqgGb4E8LzvIfWCegM\n\t2HKjs0NCgZcw/0TQTeu4oQOLxCTivAbozs6tpnUUzvuIW4bxxVJviK1B30aUGnSbl2GW\n\t0Gnq3TImHEflrobHiyHpb2h5kw5PWI7EpdAwe5G0b05NH1P2RSzrO9Uc6UwP2LgweMzo\n\tlUWg==","X-Gm-Message-State":"AOAM533mS6spjJbKI5SwDAfzaDP92hXFxLDt7FNjzcQe8Gq3MoP4/mtw\n\tBdRl0/4ZfioKlQogMUyj0ubyKSQ4W0Z28L72","X-Google-Smtp-Source":"ABdhPJzmuIjZy6DCXbx31ibGKyY4kYdt5C6zkxv82TgW1XvqQOM1K5jXCHIy+Trrujjum7EmocyeTg==","X-Received":"by 2002:a05:6512:3094:: with SMTP id\n\tz20mr21145231lfd.354.1619028884523; \n\tWed, 21 Apr 2021 11:14:44 -0700 (PDT)","Date":"Wed, 21 Apr 2021 20:14:43 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210421160319.42251-1-jacopo@jmondi.org>\n\t<20210421160319.42251-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210421160319.42251-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 03/16] test: control_list: Test\n\tControlList::merge()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16478,"web_url":"https://patchwork.libcamera.org/comment/16478/","msgid":"","date":"2021-04-22T04:19:28","subject":"Re: [libcamera-devel] [PATCH v3 03/16] test: control_list: Test\n\tControlList::merge()","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Jacopo, thank you for the patch.\n\nOn Thu, Apr 22, 2021 at 3:14 AM Niklas Söderlund\n wrote:\n>\n> Hi Jacopo,\n>\n> Thanks for your patch.\n>\n> On 2021-04-21 18:03:06 +0200, Jacopo Mondi wrote:\n> > Test the newly introduce ControlList::merge() method by creating\n>\n> nit: s/newly introduce//\n>\n> > a new list with a single control and merging it with the existing one.\n> >\n> > Test that the merged list contains all the controls and their values\n> > are not changed.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > test/controls/control_list.cpp | 40 ++++++++++++++++++++++++++++++++++\n> > 1 file changed, 40 insertions(+)\n> >\n> > diff --git a/test/controls/control_list.cpp b/test/controls/control_list.cpp\n> > index 2b321ddd6fa4..91b38993abf9 100644\n> > --- a/test/controls/control_list.cpp\n> > +++ b/test/controls/control_list.cpp\n> > @@ -150,6 +150,46 @@ protected:\n> > return TestFail;\n> > }\n> >\n> > + /*\n> > + * Create a new list with a new control and merge it with the\n> > + * existing one, verifying that the existing controls\n> > + * values does not get changed.\n> > + */\n> > + ControlList mergeList(controls::controls, &validator);\n> > + mergeList.set(controls::Saturation, 0.4f);\n> > +\n> > + mergeList.merge(list);\n> > + if (mergeList.size() != 3) {\n> > + cout << \"Merged list should contain three elements\" << endl;\n> > + return TestFail;\n> > + }\n> > +\n\nShall we check if list.size() is one?\n\n> > + if (!mergeList.contains(controls::Brightness) ||\n> > + !mergeList.contains(controls::Contrast) ||\n> > + !mergeList.contains(controls::Saturation)) {\n> > + cout << \"Merged list does not contain all controls it should\"\n> > + << endl;\n>\n> nit: s/ it should//\n>\n> With or without the nits fixed,\n>\n> Reviewed-by: Niklas Söderlund \n>\n> > + return TestFail;\n> > + }\n> > +\n> > + if (mergeList.get(controls::Brightness) != 0.5f) {\n> > + cout << \"Brightness control value changed after merging lists\"\n> > + << endl;\n> > + return TestFail;\n> > + }\n> > +\n> > + if (mergeList.get(controls::Contrast) != 1.1f) {\n> > + cout << \"Contrast control value changed after merging lists\"\n> > + << endl;\n> > + return TestFail;\n> > + }\n> > +\n> > + if (mergeList.get(controls::Saturation) != 0.4f) {\n> > + cout << \"Saturation control value changed after merging lists\"\n> > + << endl;\n> > + return TestFail;\n> > + }\n> > +\n> > return TestPass;\n> > }\n> > };\n> > --\n> > 2.31.1\n\nI would split the function to pieces to test one thing in each piece.\nBut it should not have to be done in this patch.\n\nReviewed-by: Hirokazu Honda \n\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5CA2BDB17\n\tfor ;\n\tThu, 22 Apr 2021 04:19:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 20DA068847;\n\tThu, 22 Apr 2021 06:19:41 +0200 (CEST)","from mail-ed1-x530.google.com (mail-ed1-x530.google.com\n\t[IPv6:2a00:1450:4864:20::530])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE76360516\n\tfor ;\n\tThu, 22 Apr 2021 06:19:39 +0200 (CEST)","by mail-ed1-x530.google.com with SMTP id g17so51102104edm.6\n\tfor ;\n\tWed, 21 Apr 2021 21:19:39 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"KnaRi05A\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=XFhR6gZItbqlEDgO9nOmzK6GL1HiTCYeuNxTrHsM0h8=;\n\tb=KnaRi05A43cw+T7/sfBSde92qVQOUWMGX6wYIzU1nYkz0ObhnJitmPeUnien37H+9N\n\tIjf/y/fYmfQZ0c478CAQlj3F2+6CliltHdN3UdLoIrpYS3N0PbZtceA0O0jVM0Gg8cu3\n\tLhv3d6R/V2k0EIPz4SjSOVLfX8iyTHzj+x0Tc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=XFhR6gZItbqlEDgO9nOmzK6GL1HiTCYeuNxTrHsM0h8=;\n\tb=NX/U80w+QWpRv5xjSBztknFtGkfwaFhdQq/J8daE2EjP1gdnZjxWR8rTLSfYOa0obE\n\t7HPEvW54q8cOrHaLlVleDgPOAq4UAItEmhZ4bduBgUTw3SbVA1tAKBrDMnmmn0CxRgKb\n\tDvsnz4r2W8LqVAdHBezpDItZ2PKENHgSWnUEU2MK73UFuS3YpifHaOx2j1y+uxCg40K6\n\tvptVAa+ABt7Zih1EYxbLe3GqlsX5/tDLLfdh1Gy0wtAGetXXKr9Z10gkLp5FkDwJhwWb\n\tEnn8/viP96PGwtxI6yiF4eWUu92L2RKq6cp8kPtPxa0j0PRTKjOfbmV9cECj8IrwwwYF\n\tsBjg==","X-Gm-Message-State":"AOAM531rrgZYeGkXgjdPr8Ya12jNa7ZU2UwOPX9jH570OJyq/lY0bFPm\n\tbztXaDdBa4OY6WfQns9Huq6T76mHTcKfxP97uMCToA==","X-Google-Smtp-Source":"ABdhPJzle9TxXpU1gmpxk5g4I4u1aqG1vqw5g4BtR/NhGBv+85rc2zM8miVIxIitmv4oGq0MyG19b2tRoyv/3DJ8hkg=","X-Received":"by 2002:a05:6402:5211:: with SMTP id\n\ts17mr1328630edd.327.1619065179384; \n\tWed, 21 Apr 2021 21:19:39 -0700 (PDT)","MIME-Version":"1.0","References":"<20210421160319.42251-1-jacopo@jmondi.org>\n\t<20210421160319.42251-4-jacopo@jmondi.org>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Thu, 22 Apr 2021 13:19:28 +0900","Message-ID":"","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","Subject":"Re: [libcamera-devel] [PATCH v3 03/16] test: control_list: Test\n\tControlList::merge()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16557,"web_url":"https://patchwork.libcamera.org/comment/16557/","msgid":"","date":"2021-04-26T04:26:12","subject":"Re: [libcamera-devel] [PATCH v3 03/16] test: control_list: Test\n\tControlList::merge()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Apr 21, 2021 at 06:03:06PM +0200, Jacopo Mondi wrote:\n> Test the newly introduce ControlList::merge() method by creating\n\ns/introduce/introduced/ or just drop \"newly introduce\".\n\n> a new list with a single control and merging it with the existing one.\n> \n> Test that the merged list contains all the controls and their values\n> are not changed.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> test/controls/control_list.cpp | 40 ++++++++++++++++++++++++++++++++++\n> 1 file changed, 40 insertions(+)\n> \n> diff --git a/test/controls/control_list.cpp b/test/controls/control_list.cpp\n> index 2b321ddd6fa4..91b38993abf9 100644\n> --- a/test/controls/control_list.cpp\n> +++ b/test/controls/control_list.cpp\n> @@ -150,6 +150,46 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\t/*\n> +\t\t * Create a new list with a new control and merge it with the\n> +\t\t * existing one, verifying that the existing controls\n> +\t\t * values does not get changed.\n\n\"existing control values don't get changed\"\n\n> +\t\t */\n> +\t\tControlList mergeList(controls::controls, &validator);\n> +\t\tmergeList.set(controls::Saturation, 0.4f);\n> +\n> +\t\tmergeList.merge(list);\n> +\t\tif (mergeList.size() != 3) {\n> +\t\t\tcout << \"Merged list should contain three elements\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (!mergeList.contains(controls::Brightness) ||\n> +\t\t !mergeList.contains(controls::Contrast) ||\n> +\t\t !mergeList.contains(controls::Saturation)) {\n> +\t\t\tcout << \"Merged list does not contain all controls it should\"\n> +\t\t\t << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (mergeList.get(controls::Brightness) != 0.5f) {\n> +\t\t\tcout << \"Brightness control value changed after merging lists\"\n> +\t\t\t << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (mergeList.get(controls::Contrast) != 1.1f) {\n> +\t\t\tcout << \"Contrast control value changed after merging lists\"\n> +\t\t\t << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (mergeList.get(controls::Saturation) != 0.4f) {\n> +\t\t\tcout << \"Saturation control value changed after merging lists\"\n> +\t\t\t << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n\nCould you please also test that list.size() is zero after the merge ?\n\nReviewed-by: Laurent Pinchart \n\n> +\n> \t\treturn TestPass;\n> \t}\n> };","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BAABFBDC92\n\tfor ;\n\tMon, 26 Apr 2021 04:26:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1FC77688A1;\n\tMon, 26 Apr 2021 06:26:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66794605BD\n\tfor ;\n\tMon, 26 Apr 2021 06:26:17 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B22E4FB;\n\tMon, 26 Apr 2021 06:26:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FmJxZYMU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619411177;\n\tbh=so/SgP34YqsNZTP3A5MXSP7hNUH1Wnx+e4RLMDfl1rQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FmJxZYMUgXJzMTXGITxcAh2e+nmOqRWFt+kEAFqr5qKIVYrgWxfIyJspvpVLHV8jJ\n\tfLOCivmc9nQTOEUbNwhZGkCjfV7qlg10rGmJevd2EY2YDlGTeSlFzZd6+7ih+tHkbe\n\tiXOaMEebigaYXUbsbWfpSJA7YgbpptbM3MlxqpUY=","Date":"Mon, 26 Apr 2021 07:26:12 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210421160319.42251-1-jacopo@jmondi.org>\n\t<20210421160319.42251-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210421160319.42251-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 03/16] test: control_list: Test\n\tControlList::merge()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]