[{"id":16462,"web_url":"https://patchwork.libcamera.org/comment/16462/","msgid":"","date":"2021-04-21T18:11:00","subject":"Re: [libcamera-devel] [PATCH v3 02/16] test: control_list: Check\n\tfor Brightness presence","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2021-04-21 18:03:05 +0200, Jacopo Mondi wrote:\n> The current test verifies that after adding a new control to a list\n> already populated with one control the new one is present.\n> \n> However the test wrongly tests for its presence twice instead of\n> making sure the existing control is still there.\n> \n> Fix this by checking for the presence of both controls after the\n> update, and fix the error message accordingly.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> test/controls/control_list.cpp | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/test/controls/control_list.cpp b/test/controls/control_list.cpp\n> index b5a49dc17000..2b321ddd6fa4 100644\n> --- a/test/controls/control_list.cpp\n> +++ b/test/controls/control_list.cpp\n> @@ -108,9 +108,10 @@ protected:\n> \t\tlist.set(controls::Brightness, 0.0f);\n> \t\tlist.set(controls::Contrast, 1.5f);\n> \n> -\t\tif (!list.contains(controls::Contrast) ||\n> +\t\tif (!list.contains(controls::Brightness) ||\n> \t\t !list.contains(controls::Contrast)) {\n> -\t\t\tcout << \"List should contain Contrast control\" << endl;\n> +\t\t\tcout << \"List should contain Brightness and Contrast controls\"\n> +\t\t\t << endl;\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> -- \n> 2.31.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47F09BDB17\n\tfor ;\n\tWed, 21 Apr 2021 18:11:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AA7716884A;\n\tWed, 21 Apr 2021 20:11:05 +0200 (CEST)","from mail-lf1-x135.google.com (mail-lf1-x135.google.com\n\t[IPv6:2a00:1450:4864:20::135])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4509F68835\n\tfor ;\n\tWed, 21 Apr 2021 20:11:04 +0200 (CEST)","by mail-lf1-x135.google.com with SMTP id q22so5726508lfu.8\n\tfor ;\n\tWed, 21 Apr 2021 11:11:04 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id u6sm26175ljj.82.2021.04.21.11.11.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 21 Apr 2021 11:11:01 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"Oz+3LhI+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=pljEL9Ce3eysQAl0Xc489XI+pZXoW2K+LyxjUJGKDXI=;\n\tb=Oz+3LhI+uiRKuv/ipmavqpU0oLLgxvLaKc7JgI9Ic+kQ37t0WGVKYbIqRTKDuaxx0g\n\tR3/W1o5v7DCObwhYsCogzvS5nBM7EFZyuF//6fislFBNq+Wl2ZNNn/6AW7e+pz49gpgm\n\t05t2GtwOOhhRQlObHMRC6igWD1sQ3GY8YwYGbuKZMKBGOdYigTkAdtsIR13vdAoubRET\n\tWiuJYQxqzDat44ilGzl0D+/jlGO/0e/RMKPvmk4D39YnEJX7m57X43EpE4DhgGz5+dXp\n\tOuzgQN1kN4zgkMdkYg+pjSr3Wmlml7VXexmuvrxQmaRCp85uaqNPfny9Ospn/e6d4DQ6\n\t39jg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=pljEL9Ce3eysQAl0Xc489XI+pZXoW2K+LyxjUJGKDXI=;\n\tb=t7u1R3lWwkMJfP5M8eNBFtAtwokJN75WCgZVJqnmyeqcs1SzwMuHU4ZW8/v0M9Cmld\n\t7fxbfM0osB2o2v/OCk9UNAJ5uCRXuhXbhwzpND9u1pl4lJFb5Ox5l0/PJDah02KAqMCs\n\tFX47m6hPtWgQ8NFQ5soOmFEFDiZM2FIRS5T2iOaMtTLZepJUs6pnTaRDxpqIPUYhBLHi\n\tAeOPJVe7zmkFYcvVKF2ju9my9m5DrSmmq8s8BJLednLwzUpEaFnb8qdQjKo+NMqSW5Iu\n\tKNDy9cq1tYbFCzevFi9TDfCoqhgusHjI0g+WVRzFPPmQrNlFBnaHJIKFuXZnlgdCknwP\n\tRBzw==","X-Gm-Message-State":"AOAM530qSQ4360sbYmGoTp2pUXj9+eFgBarASouHLnnqL4MZp84Uaq23\n\tDRvhBtk1Tk5d2hNsT0dYKlTFrg==","X-Google-Smtp-Source":"ABdhPJxi6nzs+rzrH+0AbvRKahRttwqzztNEIW5I0whLPeKlYe5qNZB57M4x2uZfxajdu8yJEMI5iA==","X-Received":"by 2002:a05:6512:3741:: with SMTP id\n\ta1mr20518706lfs.121.1619028662113; \n\tWed, 21 Apr 2021 11:11:02 -0700 (PDT)","Date":"Wed, 21 Apr 2021 20:11:00 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210421160319.42251-1-jacopo@jmondi.org>\n\t<20210421160319.42251-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210421160319.42251-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 02/16] test: control_list: Check\n\tfor Brightness presence","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16477,"web_url":"https://patchwork.libcamera.org/comment/16477/","msgid":"","date":"2021-04-22T03:24:43","subject":"Re: [libcamera-devel] [PATCH v3 02/16] test: control_list: Check\n\tfor Brightness presence","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Jacopo, thank you for the patch.\n\nOn Thu, Apr 22, 2021 at 3:11 AM Niklas Söderlund\n wrote:\n>\n> Hi Jacopo,\n>\n> Thanks for your work.\n>\n> On 2021-04-21 18:03:05 +0200, Jacopo Mondi wrote:\n> > The current test verifies that after adding a new control to a list\n> > already populated with one control the new one is present.\n> >\n> > However the test wrongly tests for its presence twice instead of\n> > making sure the existing control is still there.\n> >\n> > Fix this by checking for the presence of both controls after the\n> > update, and fix the error message accordingly.\n> >\n> > Signed-off-by: Jacopo Mondi \n>\n> Reviewed-by: Niklas Söderlund \n>\n\nReviewed-by: Hirokazu Honda \n\n> > ---\n> > test/controls/control_list.cpp | 5 +++--\n> > 1 file changed, 3 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/test/controls/control_list.cpp b/test/controls/control_list.cpp\n> > index b5a49dc17000..2b321ddd6fa4 100644\n> > --- a/test/controls/control_list.cpp\n> > +++ b/test/controls/control_list.cpp\n> > @@ -108,9 +108,10 @@ protected:\n> > list.set(controls::Brightness, 0.0f);\n> > list.set(controls::Contrast, 1.5f);\n> >\n> > - if (!list.contains(controls::Contrast) ||\n> > + if (!list.contains(controls::Brightness) ||\n> > !list.contains(controls::Contrast)) {\n> > - cout << \"List should contain Contrast control\" << endl;\n> > + cout << \"List should contain Brightness and Contrast controls\"\n> > + << endl;\n> > return TestFail;\n> > }\n> >\n> > --\n> > 2.31.1\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8BBA7BDB15\n\tfor ;\n\tThu, 22 Apr 2021 03:24:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A39868850;\n\tThu, 22 Apr 2021 05:24:55 +0200 (CEST)","from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com\n\t[IPv6:2a00:1450:4864:20::62e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2FC1260514\n\tfor ;\n\tThu, 22 Apr 2021 05:24:54 +0200 (CEST)","by mail-ej1-x62e.google.com with SMTP id sd23so57893066ejb.12\n\tfor ;\n\tWed, 21 Apr 2021 20:24:54 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"iXpXef6y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=BMwrAVjH7D7RCeYfYkydiP1i05mUziypU216xwju/8w=;\n\tb=iXpXef6yUKPl8uUSkqb32+Xu8uYu54qC4bWLgtbQAjdaecc84xqooR5waXZ554udeR\n\tXxP/PZTc02BEj39doG/q9bEx+hdOYoG6/aLeLfkUKxXWXG+idmMLB4bZbH5QJC2LTROX\n\tdBOlfZz7ADZbXg6kLLhAVof6lqxPDrpRdrEu4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=BMwrAVjH7D7RCeYfYkydiP1i05mUziypU216xwju/8w=;\n\tb=rA6Lv0n3CMXZm+1lLe0ikwq2voDzPEdNm3EnXVnwVam2NTbkywj/dNeQnS3N+CUkBL\n\ts87FBJambYT0axzXFIPdwZqizmyt2XvbM0hij/o1E5V0qvOrE5ZbOaHXGquqxnl9v5Gu\n\tMwdN/PCCIMKwFMouaQggYcoNV+kNnTFQvXe20zvPlAFIbMocdO3CE062Lr3ze+rt7D7W\n\t1y90N66zRkABP/aGUlkPZmKQ1XCAlC8+v6wqPk9jqmv8d2ognIf3pIpckBHtwXlccn9d\n\t1gsUHwVVaNf5iDbFke6taotTuFSMDtf9+H7usH1PxO5sRwmGnWUhVYIoN+a8jLKgXVfu\n\tsXww==","X-Gm-Message-State":"AOAM530jT/POc3yWKsqMVJQz1mG4tZ1qThsl7MeEbsthx41hrIXcVX8V\n\tlS4onKcgzMJmoHj2FkUwUaCROOSQWmiUj021fCrlCg==","X-Google-Smtp-Source":"ABdhPJxxe3gY1fvdBgqU+h+P7MqOzEcutf1ZGUxKL213gBvCTvl26ZCCZ6zePAPMxxIxEgyAfqTbeUNwdhpZ3QLVN8Q=","X-Received":"by 2002:a17:907:1b06:: with SMTP id\n\tmp6mr1080628ejc.292.1619061893848; \n\tWed, 21 Apr 2021 20:24:53 -0700 (PDT)","MIME-Version":"1.0","References":"<20210421160319.42251-1-jacopo@jmondi.org>\n\t<20210421160319.42251-3-jacopo@jmondi.org>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Thu, 22 Apr 2021 12:24:43 +0900","Message-ID":"","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","Subject":"Re: [libcamera-devel] [PATCH v3 02/16] test: control_list: Check\n\tfor Brightness presence","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16556,"web_url":"https://patchwork.libcamera.org/comment/16556/","msgid":"","date":"2021-04-26T04:22:21","subject":"Re: [libcamera-devel] [PATCH v3 02/16] test: control_list: Check\n\tfor Brightness presence","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Apr 21, 2021 at 06:03:05PM +0200, Jacopo Mondi wrote:\n> The current test verifies that after adding a new control to a list\n> already populated with one control the new one is present.\n> \n> However the test wrongly tests for its presence twice instead of\n> making sure the existing control is still there.\n> \n> Fix this by checking for the presence of both controls after the\n> update, and fix the error message accordingly.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/controls/control_list.cpp | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/test/controls/control_list.cpp b/test/controls/control_list.cpp\n> index b5a49dc17000..2b321ddd6fa4 100644\n> --- a/test/controls/control_list.cpp\n> +++ b/test/controls/control_list.cpp\n> @@ -108,9 +108,10 @@ protected:\n> \t\tlist.set(controls::Brightness, 0.0f);\n> \t\tlist.set(controls::Contrast, 1.5f);\n> \n> -\t\tif (!list.contains(controls::Contrast) ||\n> +\t\tif (!list.contains(controls::Brightness) ||\n> \t\t !list.contains(controls::Contrast)) {\n> -\t\t\tcout << \"List should contain Contrast control\" << endl;\n> +\t\t\tcout << \"List should contain Brightness and Contrast controls\"\n> +\t\t\t << endl;\n> \t\t\treturn TestFail;\n> \t\t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A629BDC91\n\tfor ;\n\tMon, 26 Apr 2021 04:22:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E8E506887A;\n\tMon, 26 Apr 2021 06:22:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C778B605BD\n\tfor ;\n\tMon, 26 Apr 2021 06:22:26 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 408324FB;\n\tMon, 26 Apr 2021 06:22:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"q1gn16W8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619410946;\n\tbh=qPrjmM+4hY2O4OEnnMIylFiCHileimzBSZGyH20Cu9k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=q1gn16W84Da79QsVhtw99NBaiAts368IxEUgm+2EFo+ZkEI284FduS0nZ0HymC81F\n\ta4QeI1iNneG5HdQFwp0l/tKYJ4i6UEt1QQXgJO+zz0oieuVZDVnnntAhleaqIns2Um\n\t5MvnRIHnryqflvol/xQMejGfBUanLYsZoDRySr+M=","Date":"Mon, 26 Apr 2021 07:22:21 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210421160319.42251-1-jacopo@jmondi.org>\n\t<20210421160319.42251-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210421160319.42251-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 02/16] test: control_list: Check\n\tfor Brightness presence","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]