{"id":12034,"url":"https://patchwork.libcamera.org/api/patches/12034/?format=json","web_url":"https://patchwork.libcamera.org/patch/12034/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210421160319.42251-3-jacopo@jmondi.org>","date":"2021-04-21T16:03:05","name":"[libcamera-devel,v3,02/16] test: control_list: Check for Brightness presence","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"78f4c7e8056230b9ec3aee3355b00ec9746de28b","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/12034/mbox/","series":[{"id":1957,"url":"https://patchwork.libcamera.org/api/series/1957/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1957","date":"2021-04-21T16:03:03","name":"Support SensorTimestamp metadata","version":3,"mbox":"https://patchwork.libcamera.org/series/1957/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12034/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12034/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 98A02BDB17\n\tfor ;\n\tWed, 21 Apr 2021 16:02:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 45BD16885E;\n\tWed, 21 Apr 2021 18:02:48 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC85C68835\n\tfor ;\n\tWed, 21 Apr 2021 18:02:43 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 5F852240002;\n\tWed, 21 Apr 2021 16:02:43 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 21 Apr 2021 18:03:05 +0200","Message-Id":"<20210421160319.42251-3-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210421160319.42251-1-jacopo@jmondi.org>","References":"<20210421160319.42251-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 02/16] test: control_list: Check for\n\tBrightness presence","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The current test verifies that after adding a new control to a list\nalready populated with one control the new one is present.\n\nHowever the test wrongly tests for its presence twice instead of\nmaking sure the existing control is still there.\n\nFix this by checking for the presence of both controls after the\nupdate, and fix the error message accordingly.\n\nSigned-off-by: Jacopo Mondi \n---\n test/controls/control_list.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/test/controls/control_list.cpp b/test/controls/control_list.cpp\nindex b5a49dc17000..2b321ddd6fa4 100644\n--- a/test/controls/control_list.cpp\n+++ b/test/controls/control_list.cpp\n@@ -108,9 +108,10 @@ protected:\n \t\tlist.set(controls::Brightness, 0.0f);\n \t\tlist.set(controls::Contrast, 1.5f);\n \n-\t\tif (!list.contains(controls::Contrast) ||\n+\t\tif (!list.contains(controls::Brightness) ||\n \t\t !list.contains(controls::Contrast)) {\n-\t\t\tcout << \"List should contain Contrast control\" << endl;\n+\t\t\tcout << \"List should contain Brightness and Contrast controls\"\n+\t\t\t << endl;\n \t\t\treturn TestFail;\n \t\t}\n \n","prefixes":["libcamera-devel","v3","02/16"]}