{"id":12029,"url":"https://patchwork.libcamera.org/api/patches/12029/?format=json","web_url":"https://patchwork.libcamera.org/patch/12029/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210421093857.391409-2-hiroh@chromium.org>","date":"2021-04-21T09:38:56","name":"[libcamera-devel,v3,2/3] libcamera: V4L2Device: Use std::vector for v4l2_ext_control in setControls()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4f43ca926bcf322572917d4440e1b45c3be9cc24","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12029/mbox/","series":[{"id":1955,"url":"https://patchwork.libcamera.org/api/series/1955/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1955","date":"2021-04-21T09:38:55","name":"[libcamera-devel,v3,1/3] libcamera: V4L2Device: Use std::vector for v4l2_ext_control in getControls()","version":3,"mbox":"https://patchwork.libcamera.org/series/1955/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12029/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12029/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7BD29BDB16\n\tfor ;\n\tWed, 21 Apr 2021 09:39:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 309F168850;\n\tWed, 21 Apr 2021 11:39:08 +0200 (CEST)","from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com\n\t[IPv6:2607:f8b0:4864:20::52e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1CB6168806\n\tfor ;\n\tWed, 21 Apr 2021 11:39:06 +0200 (CEST)","by mail-pg1-x52e.google.com with SMTP id p12so29254118pgj.10\n\tfor ;\n\tWed, 21 Apr 2021 02:39:06 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:7aaa:cbeb:5d87:4ab6])\n\tby smtp.gmail.com with ESMTPSA id\n\to11sm1305939pfu.188.2021.04.21.02.39.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 21 Apr 2021 02:39:03 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"DBmkc4NO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=QzpyMhEWD4Se7JJJMNT72kEmw6TYzjVAGx4q3TYswMg=;\n\tb=DBmkc4NOKJEuB9q6eqW4QBF8qfMfAqT6ZYS/O/8QUOtlBkMbNl2dqTqIeL0oIOwkvn\n\tOztHW1/DJ+g941ngxothWrQcI2Emz21cWxVivbfX8aI/QtcBfoZBk32GEBuQyxgr+1kh\n\t+13IPKKY4r3KTGOWKzSOHJHdM5hfXEa0lUo8M=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=QzpyMhEWD4Se7JJJMNT72kEmw6TYzjVAGx4q3TYswMg=;\n\tb=ibW4JTMfvY4Gtd89llqSrvvrVTF1JsEcpxIKexJ2I1R0DWTQwVa0tpYMqvd6NPoDXG\n\t/YvR/vuPSEiTvblDhmi1vDvm5o2yKONI5lbnlBIypvqIQ09plDHdS2/PGPZXbEHo6v1O\n\ttn/tkPctZ3dsVVMCsdrDWrqBE5X7TBlEysj7kceRi7ctCbKrFuUYQHpBOurn5zxDCrN1\n\tnz7B1HZ9wsHxdRpFB9Fkhk5mubKa+D9Em+Va0VJaUe3UYuFvYGNpLYsDyIqcjQJZxl2l\n\tnQCwtQq/S+htoXIxlet/lLQY4OlCLN6k+2p6SxRntf4p00PswW53dNGXdED7gsDpsTMD\n\tj1Pg==","X-Gm-Message-State":"AOAM531Mz3QaU21Xy7M+nYkIF4UNK6vQK8C3ok6aCjjPFQIUx1GeORuV\n\tuZIp0DsjzIMqeQlszc99qDnO9hGGW8ECIQ==","X-Google-Smtp-Source":"ABdhPJwXx1B7P9SVcFPh/Z+19x+ewooZxfxIISVQ49pDNWhpYC7MuTA30rH64JjBk6axvSYKlituUw==","X-Received":"by 2002:a63:e541:: with SMTP id z1mr21733965pgj.59.1618997944266;\n\tWed, 21 Apr 2021 02:39:04 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 21 Apr 2021 18:38:56 +0900","Message-Id":"<20210421093857.391409-2-hiroh@chromium.org>","X-Mailer":"git-send-email 2.31.1.368.gbe11c130af-goog","In-Reply-To":"<20210421093857.391409-1-hiroh@chromium.org>","References":"<20210421093857.391409-1-hiroh@chromium.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 2/3] libcamera: V4L2Device: Use\n\tstd::vector for v4l2_ext_control in setControls()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The original code uses Variable-Length-Array, which is not\nofficially supported in C++. This replaces the array with\nstd::vector.\n\nSigned-off-by: Hirokazu Honda \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/v4l2_device.cpp | 39 ++++++++++++++++-------------------\n 1 file changed, 18 insertions(+), 21 deletions(-)","diff":"diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex c95c5e2a..109269b2 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -279,30 +279,28 @@ ControlList V4L2Device::getControls(const std::vector &ids)\n */\n int V4L2Device::setControls(ControlList *ctrls)\n {\n-\tunsigned int count = ctrls->size();\n-\tif (count == 0)\n+\tif (ctrls->empty())\n \t\treturn 0;\n \n-\tstruct v4l2_ext_control v4l2Ctrls[count];\n-\tmemset(v4l2Ctrls, 0, sizeof(v4l2Ctrls));\n+\tstd::vector v4l2Ctrls(ctrls->size());\n+\tmemset(v4l2Ctrls.data(), 0, sizeof(v4l2_ext_control) * ctrls->size());\n \n-\tunsigned int i = 0;\n-\tfor (auto &ctrl : *ctrls) {\n-\t\tunsigned int id = ctrl.first;\n+\tfor (auto [ctrl, i] = std::pair(ctrls->begin(), 0u); i < ctrls->size(); ctrl++, i++) {\n+\t\tconst unsigned int id = ctrl->first;\n \t\tconst auto iter = controls_.find(id);\n \t\tif (iter == controls_.end()) {\n \t\t\tLOG(V4L2, Error)\n \t\t\t\t<< \"Control \" << utils::hex(id) << \" not found\";\n \t\t\treturn -EINVAL;\n \t\t}\n-\n-\t\tv4l2Ctrls[i].id = id;\n+\t\tv4l2_ext_control &v4l2Ctrl = v4l2Ctrls[i];\n+\t\tv4l2Ctrl.id = id;\n \n \t\t/* Set the v4l2_ext_control value for the write operation. */\n-\t\tControlValue &value = ctrl.second;\n+\t\tControlValue &value = ctrl->second;\n \t\tswitch (iter->first->type()) {\n \t\tcase ControlTypeInteger64:\n-\t\t\tv4l2Ctrls[i].value64 = value.get();\n+\t\t\tv4l2Ctrl.value64 = value.get();\n \t\t\tbreak;\n \n \t\tcase ControlTypeByte: {\n@@ -314,32 +312,30 @@ int V4L2Device::setControls(ControlList *ctrls)\n \t\t\t}\n \n \t\t\tSpan data = value.data();\n-\t\t\tv4l2Ctrls[i].p_u8 = data.data();\n-\t\t\tv4l2Ctrls[i].size = data.size();\n+\t\t\tv4l2Ctrl.p_u8 = data.data();\n+\t\t\tv4l2Ctrl.size = data.size();\n \n \t\t\tbreak;\n \t\t}\n \n \t\tdefault:\n \t\t\t/* \\todo To be changed to support strings. */\n-\t\t\tv4l2Ctrls[i].value = value.get();\n+\t\t\tv4l2Ctrl.value = value.get();\n \t\t\tbreak;\n \t\t}\n-\n-\t\ti++;\n \t}\n \n \tstruct v4l2_ext_controls v4l2ExtCtrls = {};\n \tv4l2ExtCtrls.which = V4L2_CTRL_WHICH_CUR_VAL;\n-\tv4l2ExtCtrls.controls = v4l2Ctrls;\n-\tv4l2ExtCtrls.count = count;\n+\tv4l2ExtCtrls.controls = v4l2Ctrls.data();\n+\tv4l2ExtCtrls.count = v4l2Ctrls.size();\n \n \tint ret = ioctl(VIDIOC_S_EXT_CTRLS, &v4l2ExtCtrls);\n \tif (ret) {\n \t\tunsigned int errorIdx = v4l2ExtCtrls.error_idx;\n \n \t\t/* Generic validation error. */\n-\t\tif (errorIdx == 0 || errorIdx >= count) {\n+\t\tif (errorIdx == 0 || errorIdx >= v4l2Ctrls.size()) {\n \t\t\tLOG(V4L2, Error) << \"Unable to set controls: \"\n \t\t\t\t\t << strerror(-ret);\n \t\t\treturn -EINVAL;\n@@ -348,11 +344,12 @@ int V4L2Device::setControls(ControlList *ctrls)\n \t\t/* A specific control failed. */\n \t\tLOG(V4L2, Error) << \"Unable to set control \" << errorIdx\n \t\t\t\t << \": \" << strerror(-ret);\n-\t\tcount = errorIdx - 1;\n+\n+\t\tv4l2Ctrls.resize(errorIdx);\n \t\tret = errorIdx;\n \t}\n \n-\tupdateControls(ctrls, v4l2Ctrls, count);\n+\tupdateControls(ctrls, v4l2Ctrls.data(), v4l2Ctrls.size());\n \n \treturn ret;\n }\n","prefixes":["libcamera-devel","v3","2/3"]}