[{"id":16608,"web_url":"https://patchwork.libcamera.org/comment/16608/","msgid":"","date":"2021-04-27T04:07:04","subject":"Re: [libcamera-devel] [PATCH v2 6/7] libcamera: pipeline: ipu3:\n\tReport available sensor test pattern mode","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the patch.\n\nOn Wed, Apr 21, 2021 at 01:23:45PM +0900, Hirokazu Honda wrote:\n> PipelineHandlerIPU3 gets available test pattern modes of the\n> sensor device and reports them to a client.\n> \n> Signed-off-by: Hirokazu Honda \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 51446fcf..76903d31 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -891,6 +891,18 @@ int PipelineHandlerIPU3::initControls(IPU3CameraData *data)\n> \tControlInfoMap::Map controls = IPU3Controls;\n> \tconst ControlInfoMap &sensorControls = sensor->controls();\n> \n> +\tif (!sensorInfo.availableTestPatternModes.empty()) {\n> +\t\tstd::vector values(\n> +\t\t\tsensorInfo.availableTestPatternModes.size());\n> +\t\tfor (size_t i = 0; i < values.size(); ++i) {\n> +\t\t\tvalues[i] = ControlValue(\n> +\t\t\t\tsensorInfo.availableTestPatternModes[i]);\n> +\t\t}\n\nHow about this ?\n\t\tstd::vector values;\n\t\tvalues.reserve(sensorInfo.availableTestPatternModes.size());\n\n\t\tfor (int32_t pattern : sensorInfo.availableTestPatternModes)\n\t\t\tvalues.emplace_back(pattern);\n\n(or similar, I haven't compile-tested it)\n\n> +\n> +\t\tcontrols[&controls::draft::TestPatternMode] =\n> +\t\t\tControlInfo(libcamera::Span(values));\n> +\t}\n> +\n> \t/*\n> \t * Compute exposure time limits.\n> \t *","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 15CB2BDCA1\n\tfor ;\n\tTue, 27 Apr 2021 04:07:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 70AB568878;\n\tTue, 27 Apr 2021 06:07:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6E0960512\n\tfor ;\n\tTue, 27 Apr 2021 06:07:10 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 26CCDE9;\n\tTue, 27 Apr 2021 06:07:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"u/k7GoDk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619496430;\n\tbh=YL+0PinQmAYUFwhFxlnIc3zPkOn9gVZkeaMhZY0a46c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=u/k7GoDk4CfQrm2Nqz5BY5RTspNAqYwBuEgOaio7AixbpaJUgWeJAm9QEJoqTus7T\n\tQhBXamLQrHWCe3yMOLsCqdHuiw40j1AMiVcJ12FouzTc1pwfdzn18F5Zbt9rl83Pgc\n\tzJIYnYeYwVhIP0SA43mZMMkzj5PWeuqgydsCYGRE=","Date":"Tue, 27 Apr 2021 07:07:04 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210421042346.312854-1-hiroh@chromium.org>\n\t<20210421042346.312854-7-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210421042346.312854-7-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v2 6/7] libcamera: pipeline: ipu3:\n\tReport available sensor test pattern mode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]