[{"id":16390,"web_url":"https://patchwork.libcamera.org/comment/16390/","msgid":"","date":"2021-04-20T17:22:44","subject":"Re: [libcamera-devel] [PATCH v4 3/6] libcamera: pipeline: rkisp1:\n\tFail RkISP1FrameInfo can't be found","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Kieran,\n\nThanks for the patch !\n\nOn 20/04/2021 15:07, Kieran Bingham wrote:\n> The RkISP1FrameInfo structure associated data sent to the IPA and is\n> essential for handling events.\n\nSo, this is not a IPU3 series only after all :-).\n\n> If it can not be found, this is a fatal error which must be fixed.\n> \n> Signed-off-by: Kieran Bingham \nReviewed-by: Jean-Michel Hautbois \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++---\n> 1 file changed, 6 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 549f4a4e61a8..c75666391222 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -267,7 +267,8 @@ RkISP1FrameInfo *RkISP1Frames::find(unsigned int frame)\n> \tif (itInfo != frameInfo_.end())\n> \t\treturn itInfo->second;\n> \n> -\tLOG(RkISP1, Error) << \"Can't locate info from frame\";\n> +\tLOG(RkISP1, Fatal) << \"Can't locate info from frame\";\n> +\n> \treturn nullptr;\n> }\n> \n> @@ -283,7 +284,8 @@ RkISP1FrameInfo *RkISP1Frames::find(FrameBuffer *buffer)\n> \t\t\treturn info;\n> \t}\n> \n> -\tLOG(RkISP1, Error) << \"Can't locate info from buffer\";\n> +\tLOG(RkISP1, Fatal) << \"Can't locate info from buffer\";\n> +\n> \treturn nullptr;\n> }\n> \n> @@ -296,7 +298,8 @@ RkISP1FrameInfo *RkISP1Frames::find(Request *request)\n> \t\t\treturn info;\n> \t}\n> \n> -\tLOG(RkISP1, Error) << \"Can't locate info from request\";\n> +\tLOG(RkISP1, Fatal) << \"Can't locate info from request\";\n> +\n> \treturn nullptr;\n> }\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07EF6BDB16\n\tfor ;\n\tTue, 20 Apr 2021 17:22:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7A84F68844;\n\tTue, 20 Apr 2021 19:22:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 246B360516\n\tfor ;\n\tTue, 20 Apr 2021 19:22:45 +0200 (CEST)","from [IPv6:2a01:e0a:169:7140:6781:d49:79ac:cf13] (unknown\n\t[IPv6:2a01:e0a:169:7140:6781:d49:79ac:cf13])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B14E7411;\n\tTue, 20 Apr 2021 19:22:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MNcU9x8h\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618939364;\n\tbh=qikdr3GSekUoCaETOxNGZkVTqC7C+IWqeY5NcF1XVGE=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=MNcU9x8hwmL4Gsv99V0ZGc0Cq1PWhwtQrSljfXihqbY8oNujfR9wwxte3CtwtCyDx\n\tUmeaoe6PenPNq7ltg85xbQ7NhIjsWvWqJ5/fZKzzLlDnlrcAhGLMbs994HTMDnYNvn\n\tj5sK3p6Gt4BV5RAdHpPAj/iXtyfyFYZQKQpV9jps=","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20210420130741.236848-1-kieran.bingham@ideasonboard.com>\n\t<20210420130741.236848-4-kieran.bingham@ideasonboard.com>","From":"Jean-Michel Hautbois ","Message-ID":"","Date":"Tue, 20 Apr 2021 19:22:44 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"<20210420130741.236848-4-kieran.bingham@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v4 3/6] libcamera: pipeline: rkisp1:\n\tFail RkISP1FrameInfo can't be found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16416,"web_url":"https://patchwork.libcamera.org/comment/16416/","msgid":"","date":"2021-04-20T22:20:13","subject":"Re: [libcamera-devel] [PATCH v4 3/6] libcamera: pipeline: rkisp1:\n\tFail RkISP1FrameInfo can't be found","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Apr 20, 2021 at 02:07:38PM +0100, Kieran Bingham wrote:\n> The RkISP1FrameInfo structure associated data sent to the IPA and is\n> essential for handling events.\n> \n> If it can not be found, this is a fatal error which must be fixed.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++---\n> 1 file changed, 6 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 549f4a4e61a8..c75666391222 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -267,7 +267,8 @@ RkISP1FrameInfo *RkISP1Frames::find(unsigned int frame)\n> \tif (itInfo != frameInfo_.end())\n> \t\treturn itInfo->second;\n> \n> -\tLOG(RkISP1, Error) << \"Can't locate info from frame\";\n> +\tLOG(RkISP1, Fatal) << \"Can't locate info from frame\";\n> +\n> \treturn nullptr;\n> }\n> \n> @@ -283,7 +284,8 @@ RkISP1FrameInfo *RkISP1Frames::find(FrameBuffer *buffer)\n> \t\t\treturn info;\n> \t}\n> \n> -\tLOG(RkISP1, Error) << \"Can't locate info from buffer\";\n> +\tLOG(RkISP1, Fatal) << \"Can't locate info from buffer\";\n> +\n> \treturn nullptr;\n> }\n> \n> @@ -296,7 +298,8 @@ RkISP1FrameInfo *RkISP1Frames::find(Request *request)\n> \t\t\treturn info;\n> \t}\n> \n> -\tLOG(RkISP1, Error) << \"Can't locate info from request\";\n> +\tLOG(RkISP1, Fatal) << \"Can't locate info from request\";\n> +\n> \treturn nullptr;\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 695ADBDB15\n\tfor ;\n\tTue, 20 Apr 2021 22:20:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 25D0768843;\n\tWed, 21 Apr 2021 00:20:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82176602C8\n\tfor ;\n\tWed, 21 Apr 2021 00:20:18 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 06A2A45E;\n\tWed, 21 Apr 2021 00:20:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LLIMMljo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618957218;\n\tbh=DyCN3Y4T/ueOgOr3Hf39QLMQIlYysPaBS6iwA002UeM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LLIMMljoW1+XRob/QHR9lvpolBYGH4OeLjnXvQi9lhyRjaYamdffMo8jHfyrqZPLg\n\t6nsPu0BnCWpy/KsUgdvcYc0h6Yoy8LLI0z773XBR9reIxUSAinKBiOynYI040FlEoa\n\tfzexOUqjnDeeW8LYUdCsgAfCplTXl4PUMMq/WrFg=","Date":"Wed, 21 Apr 2021 01:20:13 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210420130741.236848-1-kieran.bingham@ideasonboard.com>\n\t<20210420130741.236848-4-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210420130741.236848-4-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 3/6] libcamera: pipeline: rkisp1:\n\tFail RkISP1FrameInfo can't be found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16426,"web_url":"https://patchwork.libcamera.org/comment/16426/","msgid":"","date":"2021-04-21T04:51:45","subject":"Re: [libcamera-devel] [PATCH v4 3/6] libcamera: pipeline: rkisp1:\n\tFail RkISP1FrameInfo can't be found","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Kieran, Thank you for the patch.\n\nOn Wed, Apr 21, 2021 at 7:20 AM Laurent Pinchart\n wrote:\n>\n> Hi Kieran,\n>\n> Thank you for the patch.\n>\n> On Tue, Apr 20, 2021 at 02:07:38PM +0100, Kieran Bingham wrote:\n> > The RkISP1FrameInfo structure associated data sent to the IPA and is\n> > essential for handling events.\n> >\n> > If it can not be found, this is a fatal error which must be fixed.\n> >\n> > Signed-off-by: Kieran Bingham \n>\n> Reviewed-by: Laurent Pinchart \n>\n\nReviewed-by: Hirokazu Honda \n\n> > ---\n> > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++---\n> > 1 file changed, 6 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > index 549f4a4e61a8..c75666391222 100644\n> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > @@ -267,7 +267,8 @@ RkISP1FrameInfo *RkISP1Frames::find(unsigned int frame)\n> > if (itInfo != frameInfo_.end())\n> > return itInfo->second;\n> >\n> > - LOG(RkISP1, Error) << \"Can't locate info from frame\";\n> > + LOG(RkISP1, Fatal) << \"Can't locate info from frame\";\n> > +\n> > return nullptr;\n> > }\n> >\n> > @@ -283,7 +284,8 @@ RkISP1FrameInfo *RkISP1Frames::find(FrameBuffer *buffer)\n> > return info;\n> > }\n> >\n> > - LOG(RkISP1, Error) << \"Can't locate info from buffer\";\n> > + LOG(RkISP1, Fatal) << \"Can't locate info from buffer\";\n> > +\n> > return nullptr;\n> > }\n> >\n> > @@ -296,7 +298,8 @@ RkISP1FrameInfo *RkISP1Frames::find(Request *request)\n> > return info;\n> > }\n> >\n> > - LOG(RkISP1, Error) << \"Can't locate info from request\";\n> > + LOG(RkISP1, Fatal) << \"Can't locate info from request\";\n> > +\n> > return nullptr;\n> > }\n> >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3EC20BDB15\n\tfor ;\n\tWed, 21 Apr 2021 04:51:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F413F68840;\n\tWed, 21 Apr 2021 06:51:57 +0200 (CEST)","from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com\n\t[IPv6:2a00:1450:4864:20::52e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7947A602C3\n\tfor ;\n\tWed, 21 Apr 2021 06:51:56 +0200 (CEST)","by mail-ed1-x52e.google.com with SMTP id i3so22022872edt.1\n\tfor ;\n\tTue, 20 Apr 2021 21:51:56 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Xk/7eZBZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=bT+MOVcsuB11BAAu/DmeW8Zpa0xl4Qy6fDCm+iLCM/c=;\n\tb=Xk/7eZBZm5OId6NcTMEy24ssD0xx4PJw8ZD52Eh68Aw3yWf54gu+50pxw50Cxuzpc/\n\tYpY2fzKD1374Bx04rvsA2ntJBfKtZwlbQ/Xal9EoD3+7hPD6pb31DM3rglD2TiqSppFw\n\tmA7rxEvuAxuN6Jyk6gSmXn/8J9NUbWvAVqJ7I=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=bT+MOVcsuB11BAAu/DmeW8Zpa0xl4Qy6fDCm+iLCM/c=;\n\tb=kBUq1de0J6zivO4EZFpyzbZW2HiuhOLQs6wM09CLIOvpD9Jhx9pjQEjTHaLiJS96Fr\n\treH7TlN1M014KTZaB5cbqxnbYRp1m8xPSEW59uDs7nF1yHTXWP5wnHtEUiNs6I6/Xd9H\n\tqWWJyJ9isu7XVrvX2fmtTQOfB1UWyd/AoJsTfcQH0nAmRRc/EASsrtpEq8zA/lr7/bpb\n\tR/mqA7WAUVUvOlGl2p2iI2uGrbSrFBI8ca3V9NTD4bRfJCma1tQpDSo+ePJNHi6vXcPB\n\t5G9v2uqjXJ5uD0PgtAVJZ2haLXWsyGNo70TTVjPv32Z9P63wwQRRCH8yw7ZAmw03QQt8\n\t33bg==","X-Gm-Message-State":"AOAM531IMg8yIdFbKeLBNBDFGLTXEI/D+6i/CSyDku+gbmJXm8xgVvvM\n\taQChaxwP2bylPmmaU7l/pdweQAHtuK6QS+eUXftdeQ==","X-Google-Smtp-Source":"ABdhPJx55PRiKIJvcgqobwL7ANJPgwG8SMJy1xKBZ9n1icZRxc6gg6kU7yHoUw3Nstxib4zW5HlCVKX0e/QMvsRvJbM=","X-Received":"by 2002:aa7:d48a:: with SMTP id\n\tb10mr30504314edr.202.1618980716249; \n\tTue, 20 Apr 2021 21:51:56 -0700 (PDT)","MIME-Version":"1.0","References":"<20210420130741.236848-1-kieran.bingham@ideasonboard.com>\n\t<20210420130741.236848-4-kieran.bingham@ideasonboard.com>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Wed, 21 Apr 2021 13:51:45 +0900","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v4 3/6] libcamera: pipeline: rkisp1:\n\tFail RkISP1FrameInfo can't be found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]