[{"id":16389,"web_url":"https://patchwork.libcamera.org/comment/16389/","msgid":"<249f5795-2e5b-a2a7-9622-2f19a37fc13a@ideasonboard.com>","date":"2021-04-20T17:20:01","subject":"Re: [libcamera-devel] [PATCH v4 2/6] libcamera: pipeline: ipu3:\n\tframes: Fail if the FrameInfo can't be found","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Kieran,\n\nThanks for the patch !\n\nOn 20/04/2021 15:07, Kieran Bingham wrote:\n> The FrameInfo structure associates the data sent to the IPA\n> and is essential for handling events.\n> \n> If it can not be found, this is a fatal error which must be fixed.\n> \n> Signed-off-by: Kieran Bingham \n> \n> ---\n> v3:\n> - Make all occurrences of failing to find a frame info fatal.\n> ---\n> src/libcamera/pipeline/ipu3/frames.cpp | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp\n> index 03e8131c4829..a1b014eed8d7 100644\n> --- a/src/libcamera/pipeline/ipu3/frames.cpp\n> +++ b/src/libcamera/pipeline/ipu3/frames.cpp\n> @@ -113,7 +113,8 @@ IPU3Frames::Info *IPU3Frames::find(unsigned int id)\n> \tif (itInfo != frameInfo_.end())\n> \t\treturn itInfo->second.get();\n> \n> -\tLOG(IPU3, Error) << \"Can't find tracking informaton for frame \" << id;\n> +\tLOG(IPU3, Fatal) << \"Can't find tracking informaton for frame \" << id;\nsmall typo here: s/informaton/information\n> +\n> \treturn nullptr;\n> }\n> \n> @@ -131,7 +132,8 @@ IPU3Frames::Info *IPU3Frames::find(FrameBuffer *buffer)\n> \t\t\treturn info;\n> \t}\n> \n> -\tLOG(IPU3, Error) << \"Can't find tracking informaton from buffer\";\n> +\tLOG(IPU3, Fatal) << \"Can't find tracking informaton from buffer\";\n> +\nand here :-)\n> \treturn nullptr;\n> }\n> \n> \n\nWith those addressed:\nReviewed-by: Jean-Michel Hautbois ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D769BDB15\n\tfor ;\n\tTue, 20 Apr 2021 17:20:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6905868840;\n\tTue, 20 Apr 2021 19:20:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E0F1160516\n\tfor ;\n\tTue, 20 Apr 2021 19:20:01 +0200 (CEST)","from [IPv6:2a01:e0a:169:7140:6781:d49:79ac:cf13] (unknown\n\t[IPv6:2a01:e0a:169:7140:6781:d49:79ac:cf13])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D8E7411;\n\tTue, 20 Apr 2021 19:20:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TVqHGVqO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618939201;\n\tbh=yVtKoPbvW38CgJBCy6xYJh6zHzY8SiKcWdFuaqRHdgY=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=TVqHGVqO0MIvHMNrn5gHeYqjXle5yeLxELXHkjry2SK+psT13ciSoNQ/U8qmYNs8O\n\tN3PSJjHdsgDGA2MKueGOXApVAJTot7m/CEiVj4PbswE4gtCTpr3847wXOD3EjivCyo\n\tgeD6v27S83iB3Kpg3MLYjzfZwqXwu/Pnq5ysH+2Y=","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20210420130741.236848-1-kieran.bingham@ideasonboard.com>\n\t<20210420130741.236848-3-kieran.bingham@ideasonboard.com>","From":"Jean-Michel Hautbois ","Message-ID":"<249f5795-2e5b-a2a7-9622-2f19a37fc13a@ideasonboard.com>","Date":"Tue, 20 Apr 2021 19:20:01 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"<20210420130741.236848-3-kieran.bingham@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v4 2/6] libcamera: pipeline: ipu3:\n\tframes: Fail if the FrameInfo can't be found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16394,"web_url":"https://patchwork.libcamera.org/comment/16394/","msgid":"","date":"2021-04-20T18:09:46","subject":"Re: [libcamera-devel] [PATCH v4 2/6] libcamera: pipeline: ipu3:\n\tframes: Fail if the FrameInfo can't be found","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi JM,\n\nOn 20/04/2021 18:20, Jean-Michel Hautbois wrote:\n> Hi Kieran,\n> \n> Thanks for the patch !\n> \n> On 20/04/2021 15:07, Kieran Bingham wrote:\n>> The FrameInfo structure associates the data sent to the IPA\n>> and is essential for handling events.\n>>\n>> If it can not be found, this is a fatal error which must be fixed.\n>>\n>> Signed-off-by: Kieran Bingham \n>>\n>> ---\n>> v3:\n>> - Make all occurrences of failing to find a frame info fatal.\n>> ---\n>> src/libcamera/pipeline/ipu3/frames.cpp | 6 ++++--\n>> 1 file changed, 4 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp\n>> index 03e8131c4829..a1b014eed8d7 100644\n>> --- a/src/libcamera/pipeline/ipu3/frames.cpp\n>> +++ b/src/libcamera/pipeline/ipu3/frames.cpp\n>> @@ -113,7 +113,8 @@ IPU3Frames::Info *IPU3Frames::find(unsigned int id)\n>> \tif (itInfo != frameInfo_.end())\n>> \t\treturn itInfo->second.get();\n>> \n>> -\tLOG(IPU3, Error) << \"Can't find tracking informaton for frame \" << id;\n>> +\tLOG(IPU3, Fatal) << \"Can't find tracking informaton for frame \" << id;\n> small typo here: s/informaton/information\n>> +\n>> \treturn nullptr;\n>> }\n>> \n>> @@ -131,7 +132,8 @@ IPU3Frames::Info *IPU3Frames::find(FrameBuffer *buffer)\n>> \t\t\treturn info;\n>> \t}\n>> \n>> -\tLOG(IPU3, Error) << \"Can't find tracking informaton from buffer\";\n>> +\tLOG(IPU3, Fatal) << \"Can't find tracking informaton from buffer\";\n>> +\n> and here :-)\n\naha, good spot. Can't believe I missed that.\nNot actually related to the change in this patch - but worth fixing up\nat the same time, so I've updated the patch to include it.\n\nThanks\n\n\n>> \treturn nullptr;\n>> }\n>> \n>>\n> \n> With those addressed:\n> Reviewed-by: Jean-Michel Hautbois \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 40A37BDB15\n\tfor ;\n\tTue, 20 Apr 2021 18:09:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B5A968840;\n\tTue, 20 Apr 2021 20:09:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D8C860516\n\tfor ;\n\tTue, 20 Apr 2021 20:09:50 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 18DD4411;\n\tTue, 20 Apr 2021 20:09:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"K5Tt2E5G\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618942190;\n\tbh=Z3fCJ05TZvjm7ySGPpo1/paaR/IBaC3qo1JpluVHxLk=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=K5Tt2E5G+hXPc5e9Xsubv6zASM6RQ3wUyqM0So2+Ag6SjKoW9ec47glzW8uqpY6cZ\n\tBy7Iledxf5OFsG+8nY3tihkmsxLBrQlmqZVTlZfHJS07cG4/n0ldei+V0JsnT0mYA4\n\tgyi8uxXhjrPGaIX0IEeD5MqTJphzr9QqivrUybEg=","To":"Jean-Michel Hautbois ,\n\tlibcamera devel ","References":"<20210420130741.236848-1-kieran.bingham@ideasonboard.com>\n\t<20210420130741.236848-3-kieran.bingham@ideasonboard.com>\n\t<249f5795-2e5b-a2a7-9622-2f19a37fc13a@ideasonboard.com>","From":"Kieran Bingham ","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 20 Apr 2021 19:09:46 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"<249f5795-2e5b-a2a7-9622-2f19a37fc13a@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v4 2/6] libcamera: pipeline: ipu3:\n\tframes: Fail if the FrameInfo can't be found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16415,"web_url":"https://patchwork.libcamera.org/comment/16415/","msgid":"","date":"2021-04-20T22:19:44","subject":"Re: [libcamera-devel] [PATCH v4 2/6] libcamera: pipeline: ipu3:\n\tframes: Fail if the FrameInfo can't be found","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Apr 20, 2021 at 02:07:37PM +0100, Kieran Bingham wrote:\n> The FrameInfo structure associates the data sent to the IPA\n> and is essential for handling events.\n> \n> If it can not be found, this is a fatal error which must be fixed.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> v3:\n> - Make all occurrences of failing to find a frame info fatal.\n> ---\n> src/libcamera/pipeline/ipu3/frames.cpp | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp\n> index 03e8131c4829..a1b014eed8d7 100644\n> --- a/src/libcamera/pipeline/ipu3/frames.cpp\n> +++ b/src/libcamera/pipeline/ipu3/frames.cpp\n> @@ -113,7 +113,8 @@ IPU3Frames::Info *IPU3Frames::find(unsigned int id)\n> \tif (itInfo != frameInfo_.end())\n> \t\treturn itInfo->second.get();\n> \n> -\tLOG(IPU3, Error) << \"Can't find tracking informaton for frame \" << id;\n> +\tLOG(IPU3, Fatal) << \"Can't find tracking informaton for frame \" << id;\n> +\n> \treturn nullptr;\n> }\n> \n> @@ -131,7 +132,8 @@ IPU3Frames::Info *IPU3Frames::find(FrameBuffer *buffer)\n> \t\t\treturn info;\n> \t}\n> \n> -\tLOG(IPU3, Error) << \"Can't find tracking informaton from buffer\";\n> +\tLOG(IPU3, Fatal) << \"Can't find tracking informaton from buffer\";\n\nIn addition to the informaton typo, should this read s/from buffer/for\nbuffer/ ?\n\nReviewed-by: Laurent Pinchart \n\n> +\n> \treturn nullptr;\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BCCE8BDB15\n\tfor ;\n\tTue, 20 Apr 2021 22:19:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7BDEC68843;\n\tWed, 21 Apr 2021 00:19:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 09B00602C8\n\tfor ;\n\tWed, 21 Apr 2021 00:19:49 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8707E45E;\n\tWed, 21 Apr 2021 00:19:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"s0kCm0qR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618957188;\n\tbh=gc4+Ee9IDvAknf71piQtAUSKW6/V/fYDCmj/4MnCEOU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=s0kCm0qRPl/OJ8B9VLSUghoF4TDY5hdhi+rECkUTD7CkMRewEb51T8ieXrtYPmZ92\n\tTZV0/zJsS+/iVgefg0RvCtRhcIHzBy08JtoNIdoRn6IwPMeET3D3NeOx4pj+2jyQwz\n\tehKVkZ4X2CN+TnuhMia9YrV0taFV9CPm6EEGCp8w=","Date":"Wed, 21 Apr 2021 01:19:44 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210420130741.236848-1-kieran.bingham@ideasonboard.com>\n\t<20210420130741.236848-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210420130741.236848-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 2/6] libcamera: pipeline: ipu3:\n\tframes: Fail if the FrameInfo can't be found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16425,"web_url":"https://patchwork.libcamera.org/comment/16425/","msgid":"","date":"2021-04-21T04:50:29","subject":"Re: [libcamera-devel] [PATCH v4 2/6] libcamera: pipeline: ipu3:\n\tframes: Fail if the FrameInfo can't be found","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Kieran, Thanks for the patch,\n\nOn Wed, Apr 21, 2021 at 7:19 AM Laurent Pinchart\n wrote:\n>\n> Hi Kieran,\n>\n> Thank you for the patch.\n>\n> On Tue, Apr 20, 2021 at 02:07:37PM +0100, Kieran Bingham wrote:\n> > The FrameInfo structure associates the data sent to the IPA\n> > and is essential for handling events.\n> >\n> > If it can not be found, this is a fatal error which must be fixed.\n> >\n> > Signed-off-by: Kieran Bingham \n> > ---\n> > v3:\n> > - Make all occurrences of failing to find a frame info fatal.\n> > ---\n> > src/libcamera/pipeline/ipu3/frames.cpp | 6 ++++--\n> > 1 file changed, 4 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp\n> > index 03e8131c4829..a1b014eed8d7 100644\n> > --- a/src/libcamera/pipeline/ipu3/frames.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/frames.cpp\n> > @@ -113,7 +113,8 @@ IPU3Frames::Info *IPU3Frames::find(unsigned int id)\n> > if (itInfo != frameInfo_.end())\n> > return itInfo->second.get();\n> >\n> > - LOG(IPU3, Error) << \"Can't find tracking informaton for frame \" << id;\n> > + LOG(IPU3, Fatal) << \"Can't find tracking informaton for frame \" << id;\n> > +\n> > return nullptr;\n> > }\n> >\n> > @@ -131,7 +132,8 @@ IPU3Frames::Info *IPU3Frames::find(FrameBuffer *buffer)\n> > return info;\n> > }\n> >\n> > - LOG(IPU3, Error) << \"Can't find tracking informaton from buffer\";\n> > + LOG(IPU3, Fatal) << \"Can't find tracking informaton from buffer\";\n>\n> In addition to the informaton typo, should this read s/from buffer/for\n> buffer/ ?\n>\n> Reviewed-by: Laurent Pinchart \n>\n> > +\n> > return nullptr;\n> > }\n> >\n>\n\nGiven the fixes,\nReviewed-by: Hirokazu Honda \n\n> --\n> Regards,\n>\n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0EE14BDB16\n\tfor ;\n\tWed, 21 Apr 2021 04:50:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F5AD602C8;\n\tWed, 21 Apr 2021 06:50:41 +0200 (CEST)","from mail-ej1-x631.google.com (mail-ej1-x631.google.com\n\t[IPv6:2a00:1450:4864:20::631])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 28399602C3\n\tfor ;\n\tWed, 21 Apr 2021 06:50:40 +0200 (CEST)","by mail-ej1-x631.google.com with SMTP id sd23so52896594ejb.12\n\tfor ;\n\tTue, 20 Apr 2021 21:50:40 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"L7u32miw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=0FTL3nJqpLAgLAI3hi7ChdpqZy5JRpiOiY3ecqN9cZs=;\n\tb=L7u32miw2agabPA2qUzzsNKR6p9iW2TzfN79NToj5xcggqaOJPtSYPUq1ZYU5NcaKZ\n\toQVFqwdqMNKfhG40sTVvpnmc/Suk0oBxG679Jxrp5Ex/iER19SypVyFMBIqp0Ik6+lpz\n\tmOrEPr8hty6gsnJRVWuZXE1VneQ0P0XW0kqok=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=0FTL3nJqpLAgLAI3hi7ChdpqZy5JRpiOiY3ecqN9cZs=;\n\tb=MntMS130LeAAQuC2WyP9eAp39v+rP2GTPtQb31GsSqSwKRls0kT8dQCU82qoSzOtYH\n\tKBrZSA/jVmPtddONiwNLwBuQM6fOZyh2b1ZmO76Xj3o4APqwF8SfhoxLLTYUAcmfqeJn\n\talpDXj4WDVFm6VMDcdbg5dRm17WNlYdnmszarmRNNPGEGuTXmjpEjfPg5xw7BfEzpiNR\n\tB5IxGuPQ6dLQymWIZDAlc3aq9LXjlYVDW00bO6Y2Xf8yvMMxSGL3UM1uSAHGIokfxVWt\n\tr6ABlMAQAWIp21vJCIpgAaxNND7ymhmQJy9HtwMGrB3N6RHiLnRt0XMDVxL3ou5IlrxA\n\tpm9Q==","X-Gm-Message-State":"AOAM533thF08b2q2EiVhQjKgs2cpn80RxsK65aboT7lsIaKQBJDQJVQg\n\t48JYcaFHiWe3cVVp74wLYwQ2z8qCrvp/k/Fz0Dydig==","X-Google-Smtp-Source":"ABdhPJzHl2NytmvW/G0orwpg4LxErap8kzGGrkvJ322tgWGKO2RQuAWnlagvlSUnPZlK/IW5PU26x3dQaCm8owrHjnM=","X-Received":"by 2002:a17:906:b890:: with SMTP id\n\thb16mr30882917ejb.221.1618980639827; \n\tTue, 20 Apr 2021 21:50:39 -0700 (PDT)","MIME-Version":"1.0","References":"<20210420130741.236848-1-kieran.bingham@ideasonboard.com>\n\t<20210420130741.236848-3-kieran.bingham@ideasonboard.com>\n\t","In-Reply-To":"","From":"Hirokazu Honda ","Date":"Wed, 21 Apr 2021 13:50:29 +0900","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v4 2/6] libcamera: pipeline: ipu3:\n\tframes: Fail if the FrameInfo can't be found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16433,"web_url":"https://patchwork.libcamera.org/comment/16433/","msgid":"","date":"2021-04-21T08:56:57","subject":"Re: [libcamera-devel] [PATCH v4 2/6] libcamera: pipeline: ipu3:\n\tframes: Fail if the FrameInfo can't be found","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 20/04/2021 23:19, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Tue, Apr 20, 2021 at 02:07:37PM +0100, Kieran Bingham wrote:\n>> The FrameInfo structure associates the data sent to the IPA\n>> and is essential for handling events.\n>>\n>> If it can not be found, this is a fatal error which must be fixed.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> v3:\n>> - Make all occurrences of failing to find a frame info fatal.\n>> ---\n>> src/libcamera/pipeline/ipu3/frames.cpp | 6 ++++--\n>> 1 file changed, 4 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp\n>> index 03e8131c4829..a1b014eed8d7 100644\n>> --- a/src/libcamera/pipeline/ipu3/frames.cpp\n>> +++ b/src/libcamera/pipeline/ipu3/frames.cpp\n>> @@ -113,7 +113,8 @@ IPU3Frames::Info *IPU3Frames::find(unsigned int id)\n>> \tif (itInfo != frameInfo_.end())\n>> \t\treturn itInfo->second.get();\n>> \n>> -\tLOG(IPU3, Error) << \"Can't find tracking informaton for frame \" << id;\n>> +\tLOG(IPU3, Fatal) << \"Can't find tracking informaton for frame \" << id;\n>> +\n>> \treturn nullptr;\n>> }\n>> \n>> @@ -131,7 +132,8 @@ IPU3Frames::Info *IPU3Frames::find(FrameBuffer *buffer)\n>> \t\t\treturn info;\n>> \t}\n>> \n>> -\tLOG(IPU3, Error) << \"Can't find tracking informaton from buffer\";\n>> +\tLOG(IPU3, Fatal) << \"Can't find tracking informaton from buffer\";\n> \n> In addition to the informaton typo, should this read s/from buffer/for\n> buffer/ ?\n> \n\nBoth make sense, and both are true, even though they are slightly different.\n\nCan't find tracking information 'for' the buffer\n - I can't identify which tracking state is used for this buffer\n\nCan't find tracking information 'from' buffer\n - Using this buffer, I was unable to find any tracking information\n\n\nI won't bother changing this now, as I hope in the (near?) future to be\nable to drop these anyway, and have the tracking information obtained\nfrom the Request, which itself would be obtained from the buffer (via\nBuffer->request())\n\nThen we can turn 'searching/lookups' into simply following two pointers,\nby having a private cookie in the now extensible Request.\n\nWith that - it won't be possible to 'not find' the entry.\n(Of course we will still have to guarantee that it is correct).\n\n> Reviewed-by: Laurent Pinchart \n> \n>> +\n>> \treturn nullptr;\n>> }\n>> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CFFC7BDB15\n\tfor ;\n\tWed, 21 Apr 2021 08:57:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8876968848;\n\tWed, 21 Apr 2021 10:57:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2087602C8\n\tfor ;\n\tWed, 21 Apr 2021 10:56:59 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B8793EE;\n\tWed, 21 Apr 2021 10:56:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hR2Tljl8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618995419;\n\tbh=xvLFY4eQrBYiUavTtEUUEe3yY8LehKwRoM/U+NMVDLg=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=hR2Tljl87lTSxDal38EoGVM6mihvWDCuTVg6WH6JXZntdTyHa81OSre0KDRWkITXs\n\tnK8VsjVlXW3KS9hQ8wYP87x+ct1GkARhPAlItQHhYOivu6u0czLMdx+hMUfKDE5KmV\n\tdAvSmSqM9lS+aUs6TeTO/T9xCfQmW03vH2QDm1rU=","To":"Laurent Pinchart ","References":"<20210420130741.236848-1-kieran.bingham@ideasonboard.com>\n\t<20210420130741.236848-3-kieran.bingham@ideasonboard.com>\n\t","From":"Kieran Bingham ","Organization":"Ideas on Board","Message-ID":"","Date":"Wed, 21 Apr 2021 09:56:57 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v4 2/6] libcamera: pipeline: ipu3:\n\tframes: Fail if the FrameInfo can't be found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]