{"id":12012,"url":"https://patchwork.libcamera.org/api/patches/12012/?format=json","web_url":"https://patchwork.libcamera.org/patch/12012/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210420130741.236848-3-kieran.bingham@ideasonboard.com>","date":"2021-04-20T13:07:37","name":"[libcamera-devel,v4,2/6] libcamera: pipeline: ipu3: frames: Fail if the FrameInfo can't be found","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"90b6a2c46bb7f9e321d24c4a5755565521e98c97","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12012/mbox/","series":[{"id":1952,"url":"https://patchwork.libcamera.org/api/series/1952/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1952","date":"2021-04-20T13:07:35","name":"IPU3 Debug Improvements","version":4,"mbox":"https://patchwork.libcamera.org/series/1952/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12012/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12012/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 66F0DBDB16\n\tfor ;\n\tTue, 20 Apr 2021 13:07:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D4EE468840;\n\tTue, 20 Apr 2021 15:07:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E0A06883E\n\tfor ;\n\tTue, 20 Apr 2021 15:07:46 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 211DC89B;\n\tTue, 20 Apr 2021 15:07:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"grORsmnd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618924066;\n\tbh=PJagYQs1QPFKkU8d8OPlYToJNuQFN8DkwVdmIBn5Qr8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=grORsmndLMA2GVTP5GjMtsNVYujmqBuU00qm9whsDKFNiUrc0eiUG0lQ448oePZ0S\n\tRCssbJt3U+er6CnYSzIBggEbRxKI7bI2/1EKthK/VvCLUF8lCLwHxz+VD+fmF7U4yu\n\tNNcS1iHltNvZHmxIH4wflojJZ0pH49lHFHR++o3s=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Tue, 20 Apr 2021 14:07:37 +0100","Message-Id":"<20210420130741.236848-3-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210420130741.236848-1-kieran.bingham@ideasonboard.com>","References":"<20210420130741.236848-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 2/6] libcamera: pipeline: ipu3: frames:\n\tFail if the FrameInfo can't be found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The FrameInfo structure associates the data sent to the IPA\nand is essential for handling events.\n\nIf it can not be found, this is a fatal error which must be fixed.\n\nSigned-off-by: Kieran Bingham \n\n---\nv3:\n - Make all occurrences of failing to find a frame info fatal.\n---\n src/libcamera/pipeline/ipu3/frames.cpp | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp\nindex 03e8131c4829..a1b014eed8d7 100644\n--- a/src/libcamera/pipeline/ipu3/frames.cpp\n+++ b/src/libcamera/pipeline/ipu3/frames.cpp\n@@ -113,7 +113,8 @@ IPU3Frames::Info *IPU3Frames::find(unsigned int id)\n \tif (itInfo != frameInfo_.end())\n \t\treturn itInfo->second.get();\n \n-\tLOG(IPU3, Error) << \"Can't find tracking informaton for frame \" << id;\n+\tLOG(IPU3, Fatal) << \"Can't find tracking informaton for frame \" << id;\n+\n \treturn nullptr;\n }\n \n@@ -131,7 +132,8 @@ IPU3Frames::Info *IPU3Frames::find(FrameBuffer *buffer)\n \t\t\treturn info;\n \t}\n \n-\tLOG(IPU3, Error) << \"Can't find tracking informaton from buffer\";\n+\tLOG(IPU3, Fatal) << \"Can't find tracking informaton from buffer\";\n+\n \treturn nullptr;\n }\n \n","prefixes":["libcamera-devel","v4","2/6"]}