[{"id":16408,"web_url":"https://patchwork.libcamera.org/comment/16408/","msgid":"","date":"2021-04-20T21:50:32","subject":"Re: [libcamera-devel] [PATCH 07/13] libcamera: vimc: Report sensor\n\ttimestamp","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, Apr 19, 2021 at 03:14:27PM +0200, Jacopo Mondi wrote:\n> Report the sensor's timestamp in the Request metadata using the\n> completed buffer timestamp.\n> \n> The buffer's timestamp reports the video capture buffer processing time,\n> and it does not theoretically matches the 'start of exposure'\n> definition.\n> \n> Being VIMC a testing platform and the test driver completes the buffers\n\ns/Being VIMC/VIMC being/\n\n> for each media entity connected in the pipeline one after the other, the\n> current solution is acceptable for the pipeline.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/vimc/vimc.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index 8f5f4ba30953..ce83dcaab8ea 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -523,6 +523,10 @@ void VimcCameraData::bufferReady(FrameBuffer *buffer)\n> {\n> \tRequest *request = buffer->request();\n> \n> +\t/* Record the sensor's timestamp in the request metadata. */\n> +\trequest->metadata().set(controls::SensorTimestamp,\n> +\t\t\t\tbuffer->metadata().timestamp);\n> +\n> \tpipe_->completeBuffer(request, buffer);\n> \tpipe_->completeRequest(request);\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B439BDB15\n\tfor ;\n\tTue, 20 Apr 2021 21:50:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 61EF068842;\n\tTue, 20 Apr 2021 23:50:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A3FFA60516\n\tfor ;\n\tTue, 20 Apr 2021 23:50:36 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 35EF2411;\n\tTue, 20 Apr 2021 23:50:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rHuqrW/J\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618955436;\n\tbh=IsNJNotQ/IPrySdf3dzBO1KwBYJrd6u45s2v2YXUf/4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rHuqrW/Jvb85qyhwHhRInMdYdv20zRE72Nfw6ZcZ8pZqzskfORSZxLtFMv+o/CDBw\n\tL+1xt4sJpMeg1YR6CbfF73NXx/YDpGTugelOHyLvlAk/ZGnuidJTbdijvJ58CVojhu\n\tY4Z/AUBSZLIsNjKXKHKS4kxG8CVNLhgRlzd29OS0=","Date":"Wed, 21 Apr 2021 00:50:32 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210419131433.22920-1-jacopo@jmondi.org>\n\t<20210419131433.22920-8-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210419131433.22920-8-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 07/13] libcamera: vimc: Report sensor\n\ttimestamp","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]