[{"id":16628,"web_url":"https://patchwork.libcamera.org/comment/16628/","msgid":"","date":"2021-04-27T06:52:42","subject":"Re: [libcamera-devel] [PATCH v2] ipa: cam_helper.hpp: Correct a\n\twrong choice of term","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Sebastian,\n\nThank you for the patch.\n\nOn Sun, Apr 18, 2021 at 05:27:12PM +0000, Sebastian Fricke wrote:\n> Sensors provide embedded data buffers and not metadata buffers,\n> replace the incorrect term with the correct one.\n> \n> Signed-off-by: Sebastian Fricke \n> Reviewed-by: David Plowman \n\nI still think embedded data is a type of metadata, but mentioning\nembedded data explicitly is good.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/cam_helper.hpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp\n> index eaf73019..c3ed5362 100644\n> --- a/src/ipa/raspberrypi/cam_helper.hpp\n> +++ b/src/ipa/raspberrypi/cam_helper.hpp\n> @@ -35,7 +35,7 @@ namespace RPiController {\n> //\n> // A method to query if the sensor outputs embedded data that can be parsed.\n> //\n> -// A parser to parse the metadata buffers provided by some sensors (for\n> +// A parser to parse the embedded data buffers provided by some sensors (for\n> // example, the imx219 does; the ov5647 doesn't). This allows us to know for\n> // sure the exposure and gain of the frame we're looking at. CamHelper\n> // provides methods for converting analogue gains to and from the sensor's","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34F68BDE19\n\tfor ;\n\tTue, 27 Apr 2021 06:52:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4F6E688B1;\n\tTue, 27 Apr 2021 08:52:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AAD9760512\n\tfor ;\n\tTue, 27 Apr 2021 08:52:48 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3E3EBE9;\n\tTue, 27 Apr 2021 08:52:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GTHcSfJ0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619506368;\n\tbh=62diDDJFdTub18/vTJ68BIM7tnhf5EWqidkA84MRZmA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GTHcSfJ08P0bzERSEjsxTSimbATKNXqco/Qi2Sbz5PIFNkFzIREtdwp7Xw9o5pzoD\n\tmVAVKeSWUqKQI0U35snHvBEVjF2TCfXwKeUiqCRI3DSZRRmXNV4Bk3NCYzWxXOcT4F\n\tTAKs2vu0JWZAQ4bABNCfgozPyMTZcv39bLPjvVao=","Date":"Tue, 27 Apr 2021 09:52:42 +0300","From":"Laurent Pinchart ","To":"Sebastian Fricke ","Message-ID":"","References":"<20210418172712.61536-1-sebastian.fricke@posteo.net>\n\t<20210418172712.61536-3-sebastian.fricke@posteo.net>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210418172712.61536-3-sebastian.fricke@posteo.net>","Subject":"Re: [libcamera-devel] [PATCH v2] ipa: cam_helper.hpp: Correct a\n\twrong choice of term","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]