[{"id":16335,"web_url":"https://patchwork.libcamera.org/comment/16335/","msgid":"","date":"2021-04-18T19:39:42","subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: raspberrypi: Fix enumeration\n\tnumbers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Sebastian,\n\nThank you for the patch.\n\nOn Sun, Apr 18, 2021 at 05:27:11PM +0000, Sebastian Fricke wrote:\n> The README.md tries to list possibilities for the user with an\n> enumeration but it always uses the number 1 for each point. Fix it.\n\nhttps://www.markdownguide.org/basic-syntax/#ordered-lists\n\n> Signed-off-by: Sebastian Fricke \n> ---\n> src/ipa/raspberrypi/README.md | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/README.md b/src/ipa/raspberrypi/README.md\n> index 26534af0..cfddfc4c 100644\n> --- a/src/ipa/raspberrypi/README.md\n> +++ b/src/ipa/raspberrypi/README.md\n> @@ -9,11 +9,11 @@ included for all existing Raspberry Pi camera modules.\n> _libcamera_ for the Raspberry Pi allows users to:\n> \n> 1. Use their existing Raspberry Pi cameras.\n> -1. Change the tuning of the image processing for their Raspberry Pi cameras.\n> -1. Alter or amend the control algorithms (such as AGC/AEC, AWB or any others)\n> +2. Change the tuning of the image processing for their Raspberry Pi cameras.\n> +3. Alter or amend the control algorithms (such as AGC/AEC, AWB or any others)\n> that control the sensor and ISP.\n> -1. Implement their own custom control algorithms.\n> -1. Supply new tunings and/or algorithms for completely new sensors.\n> +4. Implement their own custom control algorithms.\n> +5. Supply new tunings and/or algorithms for completely new sensors.\n> \n> ## How to install and run _libcamera_ on the Raspberry Pi\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8888DBD814\n\tfor ;\n\tSun, 18 Apr 2021 19:39:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C8D0C605AE;\n\tSun, 18 Apr 2021 21:39:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5126A602CA\n\tfor ;\n\tSun, 18 Apr 2021 21:39:46 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CDEFE4AB;\n\tSun, 18 Apr 2021 21:39:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sGDikWhN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618774786;\n\tbh=HcDl6UBGDfAmlUE0IzjG7mCo4fRYxGEEbTDP4+EhO9w=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sGDikWhNYjlVDKoBnJIa/0hWyDk1+VZItPoA7h7/0pVH6WCWYI7CDEyo6D2zprt6m\n\twe2vdioYfSgXHZU+KFSzBe/SzojhQsRltxATuTx5rRKc8NCW6o8tKagKgPvT7OJxsX\n\t9bhQAdxjy5v8cafLShyG9Ltt/7f/0YwvxEcnfe08=","Date":"Sun, 18 Apr 2021 22:39:42 +0300","From":"Laurent Pinchart ","To":"Sebastian Fricke ","Message-ID":"","References":"<20210418172712.61536-1-sebastian.fricke@posteo.net>\n\t<20210418172712.61536-2-sebastian.fricke@posteo.net>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210418172712.61536-2-sebastian.fricke@posteo.net>","Subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: raspberrypi: Fix enumeration\n\tnumbers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16337,"web_url":"https://patchwork.libcamera.org/comment/16337/","msgid":"<20210419040946.ubumhfthrqtb3k3q@basti-TUXEDO-Book-XA1510>","date":"2021-04-19T04:09:46","subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: raspberrypi: Fix enumeration\n\tnumbers","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"content":"On 18.04.2021 22:39, Laurent Pinchart wrote:\n>Hi Sebastian,\n>\n>Thank you for the patch.\n>\n>On Sun, Apr 18, 2021 at 05:27:11PM +0000, Sebastian Fricke wrote:\n>> The README.md tries to list possibilities for the user with an\n>> enumeration but it always uses the number 1 for each point. Fix it.\n>\n>https://www.markdownguide.org/basic-syntax/#ordered-lists\n\nOkay thank you good to know, I will keep that in mind.\n\nGreetings,\nSebastian\n\n>\n>> Signed-off-by: Sebastian Fricke \n>> ---\n>> src/ipa/raspberrypi/README.md | 8 ++++----\n>> 1 file changed, 4 insertions(+), 4 deletions(-)\n>>\n>> diff --git a/src/ipa/raspberrypi/README.md b/src/ipa/raspberrypi/README.md\n>> index 26534af0..cfddfc4c 100644\n>> --- a/src/ipa/raspberrypi/README.md\n>> +++ b/src/ipa/raspberrypi/README.md\n>> @@ -9,11 +9,11 @@ included for all existing Raspberry Pi camera modules.\n>> _libcamera_ for the Raspberry Pi allows users to:\n>>\n>> 1. Use their existing Raspberry Pi cameras.\n>> -1. Change the tuning of the image processing for their Raspberry Pi cameras.\n>> -1. Alter or amend the control algorithms (such as AGC/AEC, AWB or any others)\n>> +2. Change the tuning of the image processing for their Raspberry Pi cameras.\n>> +3. Alter or amend the control algorithms (such as AGC/AEC, AWB or any others)\n>> that control the sensor and ISP.\n>> -1. Implement their own custom control algorithms.\n>> -1. Supply new tunings and/or algorithms for completely new sensors.\n>> +4. Implement their own custom control algorithms.\n>> +5. Supply new tunings and/or algorithms for completely new sensors.\n>>\n>> ## How to install and run _libcamera_ on the Raspberry Pi\n>>\n>\n>-- \n>Regards,\n>\n>Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 994ACBD814\n\tfor ;\n\tMon, 19 Apr 2021 04:09:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 084A86880B;\n\tMon, 19 Apr 2021 06:09:50 +0200 (CEST)","from mout01.posteo.de (mout01.posteo.de [185.67.36.65])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1119460516\n\tfor ;\n\tMon, 19 Apr 2021 06:09:48 +0200 (CEST)","from submission (posteo.de [89.146.220.130]) \n\tby mout01.posteo.de (Postfix) with ESMTPS id 608CC240029\n\tfor ;\n\tMon, 19 Apr 2021 06:09:47 +0200 (CEST)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4FNtcp5st4z9rxF;\n\tMon, 19 Apr 2021 06:09:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"G4ZEEzwE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1618805387; bh=lSqT19pQ9r0/yLCBYC9lVjo/a5MNDIHzcC9NDgc2MtQ=;\n\th=Date:From:To:Cc:Subject:From;\n\tb=G4ZEEzwEeqnrfMp5imY5g8HF4tZ9RTIlFQx375FsO+KFvr5gqtI8sLOn0XCxbh6Ew\n\t0Oo0GFaQsMUs3V2F4cJscNN3DIIayoFRZfMxCNhES1g1AJsYrpleFpPfPTbLNrkpyJ\n\t5f6gFk4I0TbDPlctUOYWQ4CL/ehp2+IQ7S6YW91c6IRPwl0OVJb0T+bhjQk+UQyr42\n\t5EA1hBBV2z2tHRIh92Qck4l2fYQ7J7NM5DA7arrFxb0Kbz5CxoWAUJAgShUBnap4BK\n\t3gDZiACP9eaUmYSRMuxxykuGy+RPFzxeHfuwlcoZdqFwL9pMGJVi2vJY3MrtyKp7XT\n\tqOGv4viGqFJdQ==","Date":"Mon, 19 Apr 2021 04:09:46 +0000","From":"Sebastian Fricke ","To":"Laurent Pinchart ","Message-ID":"<20210419040946.ubumhfthrqtb3k3q@basti-TUXEDO-Book-XA1510>","References":"<20210418172712.61536-1-sebastian.fricke@posteo.net>\n\t<20210418172712.61536-2-sebastian.fricke@posteo.net>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: raspberrypi: Fix enumeration\n\tnumbers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]