[{"id":16627,"web_url":"https://patchwork.libcamera.org/comment/16627/","msgid":"","date":"2021-04-27T06:51:50","subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: cam_helper_imx219: Rework\n\tcomment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Sebastian,\n\nThank you for the patch.\n\nOn Sun, Apr 18, 2021 at 05:27:10PM +0000, Sebastian Fricke wrote:\n> Fix two typos and improve the sentence.\n> \n> Signed-off-by: Sebastian Fricke \n> ---\n> src/ipa/raspberrypi/cam_helper_imx219.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/cam_helper_imx219.cpp b/src/ipa/raspberrypi/cam_helper_imx219.cpp\n> index 0e454d0d..ecd56455 100644\n> --- a/src/ipa/raspberrypi/cam_helper_imx219.cpp\n> +++ b/src/ipa/raspberrypi/cam_helper_imx219.cpp\n> @@ -11,8 +11,8 @@\n> #include \n> \n> /*\n> - * We have observed the imx219 embedded data stream randomly return junk\n> - * reister values. Do not rely on embedded data until this has been resolved.\n> + * We have observed that the imx219 embedded data stream randomly returns junk\n> + * register values. Do not rely on embedded data until this has been resolved.\n\nI'll remove the extra space after the period when applying.\n\nReviewed-by: Laurent Pinchart \n\n> */\n> #define ENABLE_EMBEDDED_DATA 0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ACB72BDE19\n\tfor ;\n\tTue, 27 Apr 2021 06:51:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1B804688AF;\n\tTue, 27 Apr 2021 08:51:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3072D60512\n\tfor ;\n\tTue, 27 Apr 2021 08:51:57 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B0457E9;\n\tTue, 27 Apr 2021 08:51:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MScSsZhC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619506316;\n\tbh=255jiyDbhrPt63rHO4NOzDxHdBiNuhBbix6YbV/tXmk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MScSsZhC4qI3USpnYj7sNYo7rMf23e6yh8VtjEm5EmxyF/16GNZ2YykKrFD+O99Pb\n\tJPbAdjcNvYO0Byn3SLe2HlqP6HrHkDIwHXnXNbWqGADUsE1kzFRdo4m1uOWl8mTXw8\n\tVxIBGdAd7BAFkSjpzXixkTQdO0wN+4AF62WKq/m8=","Date":"Tue, 27 Apr 2021 09:51:50 +0300","From":"Laurent Pinchart ","To":"Sebastian Fricke ","Message-ID":"","References":"<20210418172712.61536-1-sebastian.fricke@posteo.net>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210418172712.61536-1-sebastian.fricke@posteo.net>","Subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: cam_helper_imx219: Rework\n\tcomment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]