[{"id":16345,"web_url":"https://patchwork.libcamera.org/comment/16345/","msgid":"","date":"2021-04-19T10:56:19","subject":"Re: [libcamera-devel] [PATCH] libcamera: Drop argument from\n\tLIBCAMERA_DECLARE_PRIVATE","submitter":{"id":72,"url":"https://patchwork.libcamera.org/api/people/72/","name":"Han-lin Chen","email":"hanlinchen@google.com"},"content":"Hi Jacopo,\n\nOn Sun, Apr 18, 2021 at 10:55 PM Jacopo Mondi wrote:\n>\n> The LIBCAMERA_DECLARE_PRIVATE() macro, used by the library classes\n> that inherits from libcamera::Extensible in order to implement the\n> PIMPL pattern, expands to:\n>\n> public: \\\n> class Private; \\\n> friend class Private;\n>\n> The 'klass' argument is not used and it might confuse developers as\n> it might hint that the class that defines the pattern's implementation\n> can be freely named, while it is actually hardcoded to 'Private'.\n>\n> Drop the argument from the macro definition.\n>\n> Signed-off-by: Jacopo Mondi \n> ---\n> include/libcamera/camera.h | 2 +-\n> include/libcamera/camera_manager.h | 2 +-\n> include/libcamera/class.h | 4 ++--\n> src/android/camera_buffer.h | 2 +-\n> 4 files changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\n> index 326b14d0ca01..d71641805c0a 100644\n> --- a/include/libcamera/camera.h\n> +++ b/include/libcamera/camera.h\n> @@ -74,7 +74,7 @@ protected:\n> class Camera final : public Object, public std::enable_shared_from_this,\n> public Extensible\n> {\n> - LIBCAMERA_DECLARE_PRIVATE(Camera)\n> + LIBCAMERA_DECLARE_PRIVATE()\n>\n> public:\n> static std::shared_ptr create(PipelineHandler *pipe,\n> diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h\n> index 35a59f0df4ca..c2f0b786da8e 100644\n> --- a/include/libcamera/camera_manager.h\n> +++ b/include/libcamera/camera_manager.h\n> @@ -22,7 +22,7 @@ class Camera;\n>\n> class CameraManager : public Object, public Extensible\n> {\n> - LIBCAMERA_DECLARE_PRIVATE(CameraManager)\n> + LIBCAMERA_DECLARE_PRIVATE()\n> public:\n> CameraManager();\n> ~CameraManager();\n> diff --git a/include/libcamera/class.h b/include/libcamera/class.h\n> index 920624d8e726..466114ecfaf4 100644\n> --- a/include/libcamera/class.h\n> +++ b/include/libcamera/class.h\n> @@ -30,7 +30,7 @@ namespace libcamera {\n> #endif\n>\n> #ifndef __DOXYGEN__\n> -#define LIBCAMERA_DECLARE_PRIVATE(klass) \\\n> +#define LIBCAMERA_DECLARE_PRIVATE() \\\n> public: \\\n> class Private; \\\n> friend class Private;\n> @@ -46,7 +46,7 @@ public: \\\n> _o();\n>\n> #else\n> -#define LIBCAMERA_DECLARE_PRIVATE(klass)\n> +#define LIBCAMERA_DECLARE_PRIVATE()\n> #define LIBCAMERA_DECLARE_PUBLIC(klass)\n> #define LIBCAMERA_D_PTR(klass)\n> #define LIBCAMERA_O_PTR(klass)\n> diff --git a/src/android/camera_buffer.h b/src/android/camera_buffer.h\n> index 7e8970b49f49..c88124b2b3f3 100644\n> --- a/src/android/camera_buffer.h\n> +++ b/src/android/camera_buffer.h\n> @@ -14,7 +14,7 @@\n>\n> class CameraBuffer final : public libcamera::Extensible\n> {\n> - LIBCAMERA_DECLARE_PRIVATE(CameraBuffer)\n> + LIBCAMERA_DECLARE_PRIVATE()\n>\n> public:\n> CameraBuffer(buffer_handle_t camera3Buffer, int flags);\n> --\n> 2.31.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n\nIndeed \"Private\" is intended to be an incomplete type, and we don't\nhave much to do with it.\nThanks for the patch.\nReviewed-by: Hanlin Chen \n\n--\nCheers.\nHanlin Chen","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 89442BD812\n\tfor ;\n\tMon, 19 Apr 2021 10:56:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E7F7768820;\n\tMon, 19 Apr 2021 12:56:32 +0200 (CEST)","from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 230BA6880C\n\tfor ;\n\tMon, 19 Apr 2021 12:56:31 +0200 (CEST)","by mail-wm1-x335.google.com with SMTP id k128so17912948wmk.4\n\tfor ;\n\tMon, 19 Apr 2021 03:56:31 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"PEDD6MW0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=8/Mbx4qz2LbNxO6Jlh+wBDgftlnVGFfSreI7tVhp3PY=;\n\tb=PEDD6MW0TJ3gOJsDfbVTqYWnmIa6D7chTSCKSXlqRl+X+QS1uTwm+EaXpo0apLYJw3\n\tap44WPlDU4rmrwzl4afem1twh+F9OePWYIeKiZmcj4vMnBFrlBDO0J+0qFypPjXq5F5u\n\tyw8QcgeVQbmL7SB3+1aEQ+QxogfK1XSpXBZyisDtP5nv80gKCff20OVlRi4ww9Ayb8EE\n\tXgnV759iG4lOhHKm1oBGouW6ZUrrGDHuIXD6bdHtAmqJKgJLMwABXZJ418vdsT8yVg84\n\tkb7Jm/0G9lSb133WJLp3HwoojF2ZDLNVSgyy8JizOeKp3KK0dX5uUww+qYtH/QwzWcyz\n\t9kKw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=8/Mbx4qz2LbNxO6Jlh+wBDgftlnVGFfSreI7tVhp3PY=;\n\tb=I1/hGCoJ6sfuO4HPGwW9smvybrSxG2v5kWXlC0KZhvOSG69+nHpMaplkf9SV4RKnaE\n\tnZWOGjEKazynDRuz6TOqsJiDthFbgDE9fQhM1PYecaeKJ9EZNoF7JwxG5NCHnhdIBGj7\n\tTfDvL6kYzV/YI3AXLM9kWb7g+x1dVdait4JDmr5utGCF/5okgfzRvlaNWtWkpn2Si5r+\n\t01hX0yyEzHgtA8B/c7L2SKuzAF8NOyT3c7wXatMjp4Kr2hHkCXEjFNKZVU2pKGhn6mCP\n\tIzMaowTF7cG+6gZAg8tzAhv32QvOZwCUoZ9QvOInCvpKDPIH2HziR6LaGfTKSEebI3Dq\n\tJ8Bw==","X-Gm-Message-State":"AOAM533KWDAf6kpOWvQ7VBaEOkZrtRK+rFua8Rikw0HV+j3T9XSSlBSb\n\tGTGm+wPLspCV4LT0ttkX82p+4+wR+Fk4ZsXZc6GSAA==","X-Google-Smtp-Source":"ABdhPJxyroqQPZl/Hs69vWjildXgWW+9RdXDUCUmQJQ3wyh6KGYSFDrof37Xm0FmB0rBf8Q5z7DhucV7VsNRPwm2uLw=","X-Received":"by 2002:a05:600c:21c2:: with SMTP id\n\tx2mr20740965wmj.161.1618829790596; \n\tMon, 19 Apr 2021 03:56:30 -0700 (PDT)","MIME-Version":"1.0","References":"<20210418145545.29250-1-jacopo@jmondi.org>","In-Reply-To":"<20210418145545.29250-1-jacopo@jmondi.org>","From":"Han-lin Chen ","Date":"Mon, 19 Apr 2021 18:56:19 +0800","Message-ID":"","To":"Jacopo Mondi ","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Drop argument from\n\tLIBCAMERA_DECLARE_PRIVATE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16371,"web_url":"https://patchwork.libcamera.org/comment/16371/","msgid":"","date":"2021-04-20T00:41:00","subject":"Re: [libcamera-devel] [PATCH] libcamera: Drop argument from\n\tLIBCAMERA_DECLARE_PRIVATE","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Sun, Apr 18, 2021 at 04:55:45PM +0200, Jacopo Mondi wrote:\n> The LIBCAMERA_DECLARE_PRIVATE() macro, used by the library classes\n> that inherits from libcamera::Extensible in order to implement the\n> PIMPL pattern, expands to:\n> \n> public:\t\t\t\t\t\t\t\t\t\\\n> \tclass Private;\t\t\t\t\t\t\t\\\n> \tfriend class Private;\n> \n> The 'klass' argument is not used and it might confuse developers as\n> it might hint that the class that defines the pattern's implementation\n> can be freely named, while it is actually hardcoded to 'Private'.\n> \n> Drop the argument from the macro definition.\n\nI've intentionally kept the argument (I think this has actually been\ndiscussed before) for symmetry with LIBCAMERA_DECLARE_PUBLIC(), and\nperhaps, unconciously, wondering if it would be needed later. Those are\npretty weak reasons, and it could indeed be confusing for developers. I\ndon't mind much either way, but if you'd like to merge this patch,\nyou've forgotten to update the documentation of the macro in class.cpp.\nDid doxygen remain silent ?\n\n> Signed-off-by: Jacopo Mondi \n> ---\n> include/libcamera/camera.h | 2 +-\n> include/libcamera/camera_manager.h | 2 +-\n> include/libcamera/class.h | 4 ++--\n> src/android/camera_buffer.h | 2 +-\n> 4 files changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\n> index 326b14d0ca01..d71641805c0a 100644\n> --- a/include/libcamera/camera.h\n> +++ b/include/libcamera/camera.h\n> @@ -74,7 +74,7 @@ protected:\n> class Camera final : public Object, public std::enable_shared_from_this,\n> \t\t public Extensible\n> {\n> -\tLIBCAMERA_DECLARE_PRIVATE(Camera)\n> +\tLIBCAMERA_DECLARE_PRIVATE()\n> \n> public:\n> \tstatic std::shared_ptr create(PipelineHandler *pipe,\n> diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h\n> index 35a59f0df4ca..c2f0b786da8e 100644\n> --- a/include/libcamera/camera_manager.h\n> +++ b/include/libcamera/camera_manager.h\n> @@ -22,7 +22,7 @@ class Camera;\n> \n> class CameraManager : public Object, public Extensible\n> {\n> -\tLIBCAMERA_DECLARE_PRIVATE(CameraManager)\n> +\tLIBCAMERA_DECLARE_PRIVATE()\n> public:\n> \tCameraManager();\n> \t~CameraManager();\n> diff --git a/include/libcamera/class.h b/include/libcamera/class.h\n> index 920624d8e726..466114ecfaf4 100644\n> --- a/include/libcamera/class.h\n> +++ b/include/libcamera/class.h\n> @@ -30,7 +30,7 @@ namespace libcamera {\n> #endif\n> \n> #ifndef __DOXYGEN__\n> -#define LIBCAMERA_DECLARE_PRIVATE(klass)\t\t\t\t\\\n> +#define LIBCAMERA_DECLARE_PRIVATE()\t\t\t\t\t\\\n> public:\t\t\t\t\t\t\t\t\t\\\n> \tclass Private;\t\t\t\t\t\t\t\\\n> \tfriend class Private;\n> @@ -46,7 +46,7 @@ public:\t\t\t\t\t\t\t\t\t\\\n> \t_o();\n> \n> #else\n> -#define LIBCAMERA_DECLARE_PRIVATE(klass)\n> +#define LIBCAMERA_DECLARE_PRIVATE()\n> #define LIBCAMERA_DECLARE_PUBLIC(klass)\n> #define LIBCAMERA_D_PTR(klass)\n> #define LIBCAMERA_O_PTR(klass)\n> diff --git a/src/android/camera_buffer.h b/src/android/camera_buffer.h\n> index 7e8970b49f49..c88124b2b3f3 100644\n> --- a/src/android/camera_buffer.h\n> +++ b/src/android/camera_buffer.h\n> @@ -14,7 +14,7 @@\n> \n> class CameraBuffer final : public libcamera::Extensible\n> {\n> -\tLIBCAMERA_DECLARE_PRIVATE(CameraBuffer)\n> +\tLIBCAMERA_DECLARE_PRIVATE()\n> \n> public:\n> \tCameraBuffer(buffer_handle_t camera3Buffer, int flags);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 959D1BD816\n\tfor ;\n\tTue, 20 Apr 2021 00:41:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 101FB68834;\n\tTue, 20 Apr 2021 02:41:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9AFDC602CA\n\tfor ;\n\tTue, 20 Apr 2021 02:41:04 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 069E2470;\n\tTue, 20 Apr 2021 02:41:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kXXqMK3Y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618879264;\n\tbh=ToiZX7/0OPCT7GW6c9afYjZEfI+SLLINihzStznhZgU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kXXqMK3Ypm+/STeHeFLKyKWKMhAI0jxDBxKM5tvmb8xK9VTqtlEfqT4gDPGH0VDAd\n\tLv8GtobPCLoEWWF2tZ0K/f2+bPD11DLvm4QQtHl/Hz9r2eZryGZE7VoJ4wWsj79QdQ\n\tfdwRcUbTW2zI+Cv3RGWrnNs8UU/0RyH9k3upmIec=","Date":"Tue, 20 Apr 2021 03:41:00 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210418145545.29250-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210418145545.29250-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Drop argument from\n\tLIBCAMERA_DECLARE_PRIVATE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16381,"web_url":"https://patchwork.libcamera.org/comment/16381/","msgid":"<20210420074137.65bbmttjbhwquvr2@uno.localdomain>","date":"2021-04-20T07:41:37","subject":"Re: [libcamera-devel] [PATCH] libcamera: Drop argument from\n\tLIBCAMERA_DECLARE_PRIVATE","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Tue, Apr 20, 2021 at 03:41:00AM +0300, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Sun, Apr 18, 2021 at 04:55:45PM +0200, Jacopo Mondi wrote:\n> > The LIBCAMERA_DECLARE_PRIVATE() macro, used by the library classes\n> > that inherits from libcamera::Extensible in order to implement the\n> > PIMPL pattern, expands to:\n> >\n> > public:\t\t\t\t\t\t\t\t\t\\\n> > \tclass Private;\t\t\t\t\t\t\t\\\n> > \tfriend class Private;\n> >\n> > The 'klass' argument is not used and it might confuse developers as\n> > it might hint that the class that defines the pattern's implementation\n> > can be freely named, while it is actually hardcoded to 'Private'.\n> >\n> > Drop the argument from the macro definition.\n>\n> I've intentionally kept the argument (I think this has actually been\n> discussed before) for symmetry with LIBCAMERA_DECLARE_PUBLIC(), and\n\nI might have some memories about that now that you've mentioned it, yes...\n\n> perhaps, unconciously, wondering if it would be needed later. Those are\n> pretty weak reasons, and it could indeed be confusing for developers. I\n> don't mind much either way, but if you'd like to merge this patch,\n> you've forgotten to update the documentation of the macro in class.cpp.\n> Did doxygen remain silent ?\n\nYou know, it does not :/\n\nThe documentation reports\n\n * ... It shall be used at\n * the very top of the class definition, with the public class name passed as\n * the \\a klass parameter.\n\nI think it's a bit confusing, yes...\n\nThanks\n j\n\n>\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > include/libcamera/camera.h | 2 +-\n> > include/libcamera/camera_manager.h | 2 +-\n> > include/libcamera/class.h | 4 ++--\n> > src/android/camera_buffer.h | 2 +-\n> > 4 files changed, 5 insertions(+), 5 deletions(-)\n> >\n> > diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\n> > index 326b14d0ca01..d71641805c0a 100644\n> > --- a/include/libcamera/camera.h\n> > +++ b/include/libcamera/camera.h\n> > @@ -74,7 +74,7 @@ protected:\n> > class Camera final : public Object, public std::enable_shared_from_this,\n> > \t\t public Extensible\n> > {\n> > -\tLIBCAMERA_DECLARE_PRIVATE(Camera)\n> > +\tLIBCAMERA_DECLARE_PRIVATE()\n> >\n> > public:\n> > \tstatic std::shared_ptr create(PipelineHandler *pipe,\n> > diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h\n> > index 35a59f0df4ca..c2f0b786da8e 100644\n> > --- a/include/libcamera/camera_manager.h\n> > +++ b/include/libcamera/camera_manager.h\n> > @@ -22,7 +22,7 @@ class Camera;\n> >\n> > class CameraManager : public Object, public Extensible\n> > {\n> > -\tLIBCAMERA_DECLARE_PRIVATE(CameraManager)\n> > +\tLIBCAMERA_DECLARE_PRIVATE()\n> > public:\n> > \tCameraManager();\n> > \t~CameraManager();\n> > diff --git a/include/libcamera/class.h b/include/libcamera/class.h\n> > index 920624d8e726..466114ecfaf4 100644\n> > --- a/include/libcamera/class.h\n> > +++ b/include/libcamera/class.h\n> > @@ -30,7 +30,7 @@ namespace libcamera {\n> > #endif\n> >\n> > #ifndef __DOXYGEN__\n> > -#define LIBCAMERA_DECLARE_PRIVATE(klass)\t\t\t\t\\\n> > +#define LIBCAMERA_DECLARE_PRIVATE()\t\t\t\t\t\\\n> > public:\t\t\t\t\t\t\t\t\t\\\n> > \tclass Private;\t\t\t\t\t\t\t\\\n> > \tfriend class Private;\n> > @@ -46,7 +46,7 @@ public:\t\t\t\t\t\t\t\t\t\\\n> > \t_o();\n> >\n> > #else\n> > -#define LIBCAMERA_DECLARE_PRIVATE(klass)\n> > +#define LIBCAMERA_DECLARE_PRIVATE()\n> > #define LIBCAMERA_DECLARE_PUBLIC(klass)\n> > #define LIBCAMERA_D_PTR(klass)\n> > #define LIBCAMERA_O_PTR(klass)\n> > diff --git a/src/android/camera_buffer.h b/src/android/camera_buffer.h\n> > index 7e8970b49f49..c88124b2b3f3 100644\n> > --- a/src/android/camera_buffer.h\n> > +++ b/src/android/camera_buffer.h\n> > @@ -14,7 +14,7 @@\n> >\n> > class CameraBuffer final : public libcamera::Extensible\n> > {\n> > -\tLIBCAMERA_DECLARE_PRIVATE(CameraBuffer)\n> > +\tLIBCAMERA_DECLARE_PRIVATE()\n> >\n> > public:\n> > \tCameraBuffer(buffer_handle_t camera3Buffer, int flags);\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92550BDB15\n\tfor ;\n\tTue, 20 Apr 2021 07:40:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 098666883A;\n\tTue, 20 Apr 2021 09:40:58 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7270D60364\n\tfor ;\n\tTue, 20 Apr 2021 09:40:56 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id C309D1BF20F;\n\tTue, 20 Apr 2021 07:40:55 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Tue, 20 Apr 2021 09:41:37 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210420074137.65bbmttjbhwquvr2@uno.localdomain>","References":"<20210418145545.29250-1-jacopo@jmondi.org>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Drop argument from\n\tLIBCAMERA_DECLARE_PRIVATE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]