[{"id":16322,"web_url":"https://patchwork.libcamera.org/comment/16322/","msgid":"<ab2fbbdc-d26d-e86f-60f9-2405c8db185c@ideasonboard.com>","date":"2021-04-16T19:37:12","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Check for\n\tfailures when loading IPA","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Kieran,\n\nThanks for the patch !\n\nOn 16/04/2021 18:03, Kieran Bingham wrote:\n> The ipa_->init() method can fail if the IPA can't load correctly.\n> This should be caught by the pipeline handler to prevent continuing\n> with an invalid IPA.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n> ---\n>  src/libcamera/pipeline/ipu3/ipu3.cpp | 6 +++++-\n>  1 file changed, 5 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 519cad4f8148..51446fcf5bc1 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -1145,7 +1145,11 @@ int IPU3CameraData::loadIPA()\n>  \tipa_->queueFrameAction.connect(this, &IPU3CameraData::queueFrameAction);\n>  \n>  \tCameraSensor *sensor = cio2_.sensor();\n> -\tipa_->init(IPASettings{ \"\", sensor->model() });\n> +\tint ret = ipa_->init(IPASettings{ \"\", sensor->model() });\n> +\tif (ret) {\n> +\t\tLOG(IPU3, Error) << \"Failed to initialise the IPU3 IPA\";\n> +\t\treturn ret;\n> +\t}\n>  \n>  \treturn 0;\n>  }\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8DB65BD237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 16 Apr 2021 19:37:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D17306880C;\n\tFri, 16 Apr 2021 21:37:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 624BC68806\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Apr 2021 21:37:13 +0200 (CEST)","from [IPv6:2a01:e0a:169:7140:5b63:445c:7960:347a] (unknown\n\t[IPv6:2a01:e0a:169:7140:5b63:445c:7960:347a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 029FA5A5;\n\tFri, 16 Apr 2021 21:37:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JwKGCNHH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618601833;\n\tbh=R6Y9OPy7d57mJ9aRYJtXpkoNFojnTw1vH4wGlyOyWk8=;\n\th=To:References:From:Subject:Date:In-Reply-To:From;\n\tb=JwKGCNHHrwcHen6y5/x4S3xOFMybbrixiAMyK6Pbeg1uXT5A91NZA1hpOVwP5w3UL\n\tTU2K0gOTKTIWZhoY8yBWss0nvyEZfVkJv7nImRzFjOoaExUq6yGlfkFmook1W0rEWr\n\tkskfOo/bhaYcV9VZHPOVDkgo8EcpdSBspZnTeq1k=","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tlibcamera devel <libcamera-devel@lists.libcamera.org>","References":"<20210416160320.68125-1-kieran.bingham@ideasonboard.com>","From":"Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>","Message-ID":"<ab2fbbdc-d26d-e86f-60f9-2405c8db185c@ideasonboard.com>","Date":"Fri, 16 Apr 2021 21:37:12 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"<20210416160320.68125-1-kieran.bingham@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Check for\n\tfailures when loading IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":16325,"web_url":"https://patchwork.libcamera.org/comment/16325/","msgid":"<YHn2xqv2y+taTck6@oden.dyn.berto.se>","date":"2021-04-16T20:42:46","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Check for\n\tfailures when loading IPA","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2021-04-16 17:03:20 +0100, Kieran Bingham wrote:\n> The ipa_->init() method can fail if the IPA can't load correctly.\n> This should be caught by the pipeline handler to prevent continuing\n> with an invalid IPA.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n>  src/libcamera/pipeline/ipu3/ipu3.cpp | 6 +++++-\n>  1 file changed, 5 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 519cad4f8148..51446fcf5bc1 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -1145,7 +1145,11 @@ int IPU3CameraData::loadIPA()\n>  \tipa_->queueFrameAction.connect(this, &IPU3CameraData::queueFrameAction);\n>  \n>  \tCameraSensor *sensor = cio2_.sensor();\n> -\tipa_->init(IPASettings{ \"\", sensor->model() });\n> +\tint ret = ipa_->init(IPASettings{ \"\", sensor->model() });\n> +\tif (ret) {\n> +\t\tLOG(IPU3, Error) << \"Failed to initialise the IPU3 IPA\";\n> +\t\treturn ret;\n> +\t}\n>  \n>  \treturn 0;\n>  }\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 734A6BD237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 16 Apr 2021 20:42:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C91D56880A;\n\tFri, 16 Apr 2021 22:42:50 +0200 (CEST)","from mail-lj1-x230.google.com (mail-lj1-x230.google.com\n\t[IPv6:2a00:1450:4864:20::230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7BE6D68806\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Apr 2021 22:42:49 +0200 (CEST)","by mail-lj1-x230.google.com with SMTP id u20so32444415lja.13\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Apr 2021 13:42:49 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\te21sm1021077ljn.131.2021.04.16.13.42.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 16 Apr 2021 13:42:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"ahNOOjuZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=pUfyI0Kdc0AIcQw+goVDex5trlcJXHmP9/o3Fi4CZKc=;\n\tb=ahNOOjuZK76eu1X2EwWxIJZ8JnqHdRfxS0op84EooU/aDrslSWYH0hEpDBB68xyMeE\n\taKx64OffTUzJPTNCUYCIb/T/qPOTjqdAi9h7XG9YMtyon4fMRKa/aKU1lh+NDkvI/HeJ\n\tp1cj6l34l28aT/VxcvRt4Xi6ms+GEfswFe7eqDRfbntDd/QpguWkFO+q9iKLB3eIif74\n\tANI4gJOYMxKJtxHlhwzhj4/AEyYqnL4lKomylQQtQN4j1tkugXNFrB7xgAK2dYzB3O3W\n\t06ZfZ4+iQvdnEaVTGD9Ae0AkxMPq+3bHZJF2sGKEO/OFEeWKq681+SCRb5kbn8w52FNJ\n\tFxQQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=pUfyI0Kdc0AIcQw+goVDex5trlcJXHmP9/o3Fi4CZKc=;\n\tb=b1iM5zUP4SUh0llOsH3bhCb9f+psdC6oZvoEMPHu3E1gHyGRLv3D/NwtEXeWcSlARS\n\tNIvngDmhfSULwoi64lK+Qw9swPtp1RsNeu7R3jxdTu31Mw0+gDv8RJ1xhAGTKQ+SddNj\n\tTlU07Zki/9K7XeRehsPCS+0CqJHPaFnAyQ/rS35QmFLAmPgrKHZq3+qdiUGyjTqh+OME\n\ttIHRVpdtiRizqynDtxMZjthH5h/EQbKEdSBuVkD7uOEeRay7MvRosJ2fzhsfErHsyFxQ\n\to3WEK352ovKTs+tHJK1IAtqitVM+D5iVqPouWmzRbnGDv2ZhiZsVEh+I0igfYLGRVK9H\n\t352g==","X-Gm-Message-State":"AOAM530mgqXCx99pCX2ZH1jWrFnOy5Qx0W94hPvRE/0IIZ0YeTHpjmqp\n\tUl7pOJgwLshD5UQqBJ4yoJF/7A==","X-Google-Smtp-Source":"ABdhPJwhBJYPi2HTsaF+9qnHW+arLNg2FWHJn7CnwdsjB4nprwu1Z/9jXXMngusMObVDmpI+a0NN3A==","X-Received":"by 2002:a05:651c:c4:: with SMTP id\n\t4mr3602390ljr.415.1618605768750; \n\tFri, 16 Apr 2021 13:42:48 -0700 (PDT)","Date":"Fri, 16 Apr 2021 22:42:46 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<YHn2xqv2y+taTck6@oden.dyn.berto.se>","References":"<20210416160320.68125-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210416160320.68125-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Check for\n\tfailures when loading IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":16328,"web_url":"https://patchwork.libcamera.org/comment/16328/","msgid":"<YHoLr90mV9DOO2Gy@pendragon.ideasonboard.com>","date":"2021-04-16T22:11:59","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Check for\n\tfailures when loading IPA","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Apr 16, 2021 at 05:03:20PM +0100, Kieran Bingham wrote:\n> The ipa_->init() method can fail if the IPA can't load correctly.\n> This should be caught by the pipeline handler to prevent continuing\n> with an invalid IPA.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/libcamera/pipeline/ipu3/ipu3.cpp | 6 +++++-\n>  1 file changed, 5 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 519cad4f8148..51446fcf5bc1 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -1145,7 +1145,11 @@ int IPU3CameraData::loadIPA()\n>  \tipa_->queueFrameAction.connect(this, &IPU3CameraData::queueFrameAction);\n>  \n>  \tCameraSensor *sensor = cio2_.sensor();\n> -\tipa_->init(IPASettings{ \"\", sensor->model() });\n> +\tint ret = ipa_->init(IPASettings{ \"\", sensor->model() });\n> +\tif (ret) {\n> +\t\tLOG(IPU3, Error) << \"Failed to initialise the IPU3 IPA\";\n> +\t\treturn ret;\n> +\t}\n>  \n>  \treturn 0;\n>  }","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD070BD235\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 16 Apr 2021 22:12:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 43A846880C;\n\tSat, 17 Apr 2021 00:12:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BC81687F3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 17 Apr 2021 00:12:01 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1046351E;\n\tSat, 17 Apr 2021 00:12:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"a8c/D58g\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618611121;\n\tbh=1YShAePvb0DOwmfZkjqmvzA9HQOfz81PDBnLsRd2//c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=a8c/D58gEyuM4ywM9lHGSUmqHhz3oYeSPaPGoQweTur5JBo8p/TnF6lzh2OONtJzL\n\tNxY+jawcRBpZO6iHZeOJJZbyFdt6jCcuvqQdFYVhTocGqLliBbK23nvEf6vtQ/LeAZ\n\t8YuKXILNI9sa20EfgS7Ay+1Liie9pbfDxc6X6EO4=","Date":"Sat, 17 Apr 2021 01:11:59 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<YHoLr90mV9DOO2Gy@pendragon.ideasonboard.com>","References":"<20210416160320.68125-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210416160320.68125-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Check for\n\tfailures when loading IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":16338,"web_url":"https://patchwork.libcamera.org/comment/16338/","msgid":"<CAO5uPHOemd-xspvPdwH+pxZy9HgUwwnMRCZ4quhPxYysorpoxA@mail.gmail.com>","date":"2021-04-19T04:36:44","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Check for\n\tfailures when loading IPA","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Kieran, thanks for the patch.\n\nOn Sat, Apr 17, 2021 at 7:12 AM Laurent Pinchart\n<laurent.pinchart@ideasonboard.com> wrote:\n>\n> Hi Kieran,\n>\n> Thank you for the patch.\n>\n> On Fri, Apr 16, 2021 at 05:03:20PM +0100, Kieran Bingham wrote:\n> > The ipa_->init() method can fail if the IPA can't load correctly.\n> > This should be caught by the pipeline handler to prevent continuing\n> > with an invalid IPA.\n> >\n> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>\nReviewed-by: Hirokazu Honda <hiroh@chromium.org>\n> > ---\n> >  src/libcamera/pipeline/ipu3/ipu3.cpp | 6 +++++-\n> >  1 file changed, 5 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index 519cad4f8148..51446fcf5bc1 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -1145,7 +1145,11 @@ int IPU3CameraData::loadIPA()\n> >       ipa_->queueFrameAction.connect(this, &IPU3CameraData::queueFrameAction);\n> >\n> >       CameraSensor *sensor = cio2_.sensor();\n> > -     ipa_->init(IPASettings{ \"\", sensor->model() });\n> > +     int ret = ipa_->init(IPASettings{ \"\", sensor->model() });\n> > +     if (ret) {\n> > +             LOG(IPU3, Error) << \"Failed to initialise the IPU3 IPA\";\n> > +             return ret;\n> > +     }\n> >\n> >       return 0;\n> >  }\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51D71BD812\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 19 Apr 2021 04:36:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B52D3605AE;\n\tMon, 19 Apr 2021 06:36:56 +0200 (CEST)","from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com\n\t[IPv6:2a00:1450:4864:20::52d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9636A60516\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 19 Apr 2021 06:36:55 +0200 (CEST)","by mail-ed1-x52d.google.com with SMTP id x4so39039126edd.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Apr 2021 21:36:55 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Tte7ZteO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=0LUvMjH7ryEoYIj7hGiD/FL7exyYsXxQV4Ov7AmOC4Q=;\n\tb=Tte7ZteOuHFwBRnGRqn+/NaE3foG054H6W75FykywhNbfBbTVIJ857BRd4sFLhDxea\n\tctC7FDFJpxMa2hOV/q9HtMnwB3A4dg9imoFgYz3jobmhNhPpLmyh024K8jMp5iJYqxZ7\n\tpkCKeAmuSVn/cJ65P8cbRFq2DtQ6R+RQ5V+ik=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=0LUvMjH7ryEoYIj7hGiD/FL7exyYsXxQV4Ov7AmOC4Q=;\n\tb=GNB8DVKQ6oe3rA1TXkq3F8xTUrJMzdqAW+VUYj5mgd/dXVh2nhQOGEMwL09jB5cI82\n\t5t9iO5XQOHvE3LcAOLFYPLqgEL7zJ2D8+FxcQZRzLFpcEu68gr8nIk8aLC2upcqHAnWE\n\tKTrIPja1uZlxMlpQKHjIpXwmyJdJM8XzUf7NNcbArJfXQO12eh53QUnUqlWiOsAmBwj6\n\tjzleiPSBzVYrXTu0lkxYHXDnMH8ZVg7TwKDAHdBoPI6v2PHnBp1wfnxO1Gv4Hg2UKFOM\n\tlm3eNhWoCWqj74ulsKpfK/KAfMIHCLY3q7kED3nmS8tjRxgmlvWnSYTl1+hnBM0JNVt0\n\tyndQ==","X-Gm-Message-State":"AOAM5333ZjRcIhBH1lCe5fJCQH1gLLnZS1Qyr3btAY2RV1uiqfSRKEJ6\n\tpG5KW/JlcVIsLrTsuaegLoaSsjqUqjaZxiq3melEcDDYvVY=","X-Google-Smtp-Source":"ABdhPJzaz1OuehMaG9QrKOlgDr3eTNlz/ceBL5OrANpH8pyuiL8OMg9RfjJDtr3R7h2HY+gHMVTHm52pc2ICDsFlfbk=","X-Received":"by 2002:aa7:c7da:: with SMTP id\n\to26mr23215414eds.244.1618807015325; \n\tSun, 18 Apr 2021 21:36:55 -0700 (PDT)","MIME-Version":"1.0","References":"<20210416160320.68125-1-kieran.bingham@ideasonboard.com>\n\t<YHoLr90mV9DOO2Gy@pendragon.ideasonboard.com>","In-Reply-To":"<YHoLr90mV9DOO2Gy@pendragon.ideasonboard.com>","From":"Hirokazu Honda <hiroh@chromium.org>","Date":"Mon, 19 Apr 2021 13:36:44 +0900","Message-ID":"<CAO5uPHOemd-xspvPdwH+pxZy9HgUwwnMRCZ4quhPxYysorpoxA@mail.gmail.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Check for\n\tfailures when loading IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]