[{"id":16318,"web_url":"https://patchwork.libcamera.org/comment/16318/","msgid":"","date":"2021-04-16T15:41:21","subject":"Re: [libcamera-devel] [PATCH v4 2/2] android: CameraDevice:\n\tValidate buffer_handle by CameraBuffer::isValidBuffer()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the patch.\n\nOn Fri, Apr 16, 2021 at 10:43:47PM +0900, Hirokazu Honda wrote:\n> This adds a validation to buffer_handle provided in\n> CameraDevice::processCaptureRequest() by using\n> CameraBuffer::isValidBuffer().\n> \n> Signed-off-by: Hirokazu Honda \n> Reviewed-by: Jacopo Mondi \n\nI think you can squash this with the previous patch.\n\nI wonder, however, what errors you expect this to catch. When can we\nreceive an invalid buffer handle from the camera service ?\n\n> ---\n> src/android/camera_device.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 89044efa..7247c12c 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -293,6 +293,11 @@ bool isValidRequest(camera3_capture_request_t *camera3Request)\n> \t\t\t\t<< \") in buffer \" << i;\n> \t\t\treturn false;\n> \t\t}\n> +\n> +\t\tif (!CameraBuffer::isValidBuffer(handle)) {\n> +\t\t\tLOG(HAL, Error) << \"Buffer \" << i << \" is invalid\";\n> +\t\t\treturn false;\n> +\t\t}\n> \t}\n> \n> \treturn true;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 25F9FBD236\n\tfor ;\n\tFri, 16 Apr 2021 15:41:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E11B6880C;\n\tFri, 16 Apr 2021 17:41:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7BE7C68806\n\tfor ;\n\tFri, 16 Apr 2021 17:41:23 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CF9845A5;\n\tFri, 16 Apr 2021 17:41:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"v/AlPcSa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618587683;\n\tbh=SjJCV+yc4yhRlmvUGqwEMgwHenNpEs4/fB8bKniFyK4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=v/AlPcSaILTB9D5yfJzcYUPLUFtBPQ6jw0KUsPt//ADjTxZEAzmr3B5sx2tYts3J5\n\taCnosR29cMVTsx7cil7BLON20g7/RmUfwj3B201tYlSfqm8Nju5NpbKdwnO5eisrYq\n\t6PdljDPFi3BLiX9jeHurq8PY6qsplBcaFnvZaX+c=","Date":"Fri, 16 Apr 2021 18:41:21 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210416134347.2881373-1-hiroh@chromium.org>\n\t<20210416134347.2881373-2-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210416134347.2881373-2-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v4 2/2] android: CameraDevice:\n\tValidate buffer_handle by CameraBuffer::isValidBuffer()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]