[{"id":16299,"web_url":"https://patchwork.libcamera.org/comment/16299/","msgid":"<20210415135651.dj4ouvodezxneqmo@uno.localdomain>","date":"2021-04-15T13:56:51","subject":"Re: [libcamera-devel] [PATCH v6 5/5] android: soraka: Add camera\n\tHAL configuration","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Hiro, Tomasz, Han-lin\n\nOn Thu, Apr 15, 2021 at 03:52:13PM +0200, Jacopo Mondi wrote:\n> Add camera HAL configuration file for IPU3 Soraka.\n>\n\nI've sent this patch for discussion, but I'm wondering if libcamera is\nthe right place where to store the HAL configuration file.\n\nIn my opinion they would be better placed in the device overlay, like\nit happens today, in example, with the Intel HAL .xml configuration\nfiles.\n\nWhat do you think ? We should find a way to install this file in\n/etc/libcamera/ before merging the series, otherwise we'll break the\nHAL support in ChromiumOS.\n\nThanks\n j\n\n> Reviewed-by: Laurent Pinchart \n> Reviewed-by: Hirokazu Honda \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/data/soraka/camera_hal.yaml | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> create mode 100644 src/android/data/soraka/camera_hal.yaml\n>\n> diff --git a/src/android/data/soraka/camera_hal.yaml b/src/android/data/soraka/camera_hal.yaml\n> new file mode 100644\n> index 000000000000..2e9964035098\n> --- /dev/null\n> +++ b/src/android/data/soraka/camera_hal.yaml\n> @@ -0,0 +1,8 @@\n> +cameras:\n> + \"\\\\_SB_.PCI0.I2C4.CAM1\":\n> + location: front\n> + rotation: 0\n> +\n> + \"\\\\_SB_.PCI0.I2C2.CAM0\":\n> + location: back\n> + rotation: 0\n> --\n> 2.31.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86E6DBD224\n\tfor ;\n\tThu, 15 Apr 2021 13:56:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 054A7687F3;\n\tThu, 15 Apr 2021 15:56:15 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BEAB605AE\n\tfor ;\n\tThu, 15 Apr 2021 15:56:13 +0200 (CEST)","from uno.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 8CD5E1C000B;\n\tThu, 15 Apr 2021 13:56:12 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","Date":"Thu, 15 Apr 2021 15:56:51 +0200","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20210415135651.dj4ouvodezxneqmo@uno.localdomain>","References":"<20210415135213.94511-1-jacopo@jmondi.org>\n\t<20210415135213.94511-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210415135213.94511-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v6 5/5] android: soraka: Add camera\n\tHAL configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Tomasz Figa ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16303,"web_url":"https://patchwork.libcamera.org/comment/16303/","msgid":"","date":"2021-04-15T16:08:47","subject":"Re: [libcamera-devel] [PATCH v6 5/5] android: soraka: Add camera\n\tHAL configuration","submitter":{"id":48,"url":"https://patchwork.libcamera.org/api/people/48/","name":"Tomasz Figa","email":"tfiga@google.com"},"content":"On Thu, Apr 15, 2021 at 10:56 PM Jacopo Mondi wrote:\n>\n> Hi Hiro, Tomasz, Han-lin\n>\n> On Thu, Apr 15, 2021 at 03:52:13PM +0200, Jacopo Mondi wrote:\n> > Add camera HAL configuration file for IPU3 Soraka.\n> >\n>\n> I've sent this patch for discussion, but I'm wondering if libcamera is\n> the right place where to store the HAL configuration file.\n>\n> In my opinion they would be better placed in the device overlay, like\n> it happens today, in example, with the Intel HAL .xml configuration\n> files.\n>\n> What do you think ?\n\nHow about non-Chrome OS users of the device? I think we should have a\nrepository of default configuration files for supported devices, which\nwould be used if there is no custom configuration provided.\n\nBest regards,\nTomasz\n\n> We should find a way to install this file in\n> /etc/libcamera/ before merging the series, otherwise we'll break the\n> HAL support in ChromiumOS.\n>\n> Thanks\n> j\n>\n> > Reviewed-by: Laurent Pinchart \n> > Reviewed-by: Hirokazu Honda \n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/android/data/soraka/camera_hal.yaml | 8 ++++++++\n> > 1 file changed, 8 insertions(+)\n> > create mode 100644 src/android/data/soraka/camera_hal.yaml\n> >\n> > diff --git a/src/android/data/soraka/camera_hal.yaml b/src/android/data/soraka/camera_hal.yaml\n> > new file mode 100644\n> > index 000000000000..2e9964035098\n> > --- /dev/null\n> > +++ b/src/android/data/soraka/camera_hal.yaml\n> > @@ -0,0 +1,8 @@\n> > +cameras:\n> > + \"\\\\_SB_.PCI0.I2C4.CAM1\":\n> > + location: front\n> > + rotation: 0\n> > +\n> > + \"\\\\_SB_.PCI0.I2C2.CAM0\":\n> > + location: back\n> > + rotation: 0\n> > --\n> > 2.31.1\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51EEDBD224\n\tfor ;\n\tThu, 15 Apr 2021 16:09:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A1D16880C;\n\tThu, 15 Apr 2021 18:09:00 +0200 (CEST)","from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 093D1605AE\n\tfor ;\n\tThu, 15 Apr 2021 18:08:59 +0200 (CEST)","by mail-wr1-x432.google.com with SMTP id e7so14871664wrs.11\n\tfor ;\n\tThu, 15 Apr 2021 09:08:59 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"aduUvrnj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=Us8AUiSC8prCOn4930JdoRuS8zld83YdlJhzJo+IwZM=;\n\tb=aduUvrnjrOHnkYe2+w6h6eHu2nkLBIDku2jUPD0wOElq8ibaJyhUSVBuHDX2kik0FW\n\tnLJdH/4dcvj2Skf6l4YAQCsna/W9LOtzGFC78QwKm9SqyIZM9ky42tBnzwD12gKBNW5I\n\tzmDRnn48A7U6Hed9peuESs6E2LmvGe2T9+GiJh8+3LBnD4zCXYJ8l+vlc7XRypeMqPOr\n\tj13TEGbhmMyDra6fZz4nvmrva2LEiXPMOZnvpPU0MD36u8Q+YhgX1I+VNXIGJ7w5dV7V\n\tKy2n+Hbd9ZBAksxag8ls34qCb2ahsMmV+YPhhuNoz0fMxypTMUbR2I3uVzLA25HbcDTF\n\thjKw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Us8AUiSC8prCOn4930JdoRuS8zld83YdlJhzJo+IwZM=;\n\tb=mvYmII+W+NJaypcPVNM/PW5GgMX8+SHCxohdi+192cA3Ygg/PKtl5yT0mbvN22bbph\n\t8Qe81hRMy/0teLtTF99wzE156vmnh1ZsZfyMs1hWL+mwRN747kcCzha7NhFCMnZ+7vJQ\n\tsEWOY5EJ8cRtfvCZNuJR+Ov9PB79RmyUWffRYB9GFKSMgFrE1BMp+TwR35Cx61/evfx7\n\tSE953Vyh+eQUJqk5Ol6CQxE279mzp3KE3ua/fO+nGE9XFY2VrS0MH8zfjmvN73nH8H7+\n\tlQomeoLUdCn2YZQh5I7qqATzPosxHz8cSNO9HpDns/Svv9EwfV2UPMM1Dql99zlqNmdz\n\tl1iw==","X-Gm-Message-State":"AOAM532tO2o7NvJISX/aY83vE4nA4gA5w/ovZJ0E8JxpvtAO3ptvxltc\n\ttBlu1e+nXfM0EQEbi1LdVOWa8M8j/Sv2mWqTESkExw==","X-Google-Smtp-Source":"ABdhPJzW4lcc1l3ksZaAGgoIjTZ9T2SLAzpYzZIj9H6NWiFMV2oG/V6B4E+AQF+fSRei7iXMK55RamvVGcLfmh2I/tY=","X-Received":"by 2002:adf:fcce:: with SMTP id f14mr662521wrs.103.1618502938643;\n\tThu, 15 Apr 2021 09:08:58 -0700 (PDT)","MIME-Version":"1.0","References":"<20210415135213.94511-1-jacopo@jmondi.org>\n\t<20210415135213.94511-6-jacopo@jmondi.org>\n\t<20210415135651.dj4ouvodezxneqmo@uno.localdomain>","In-Reply-To":"<20210415135651.dj4ouvodezxneqmo@uno.localdomain>","From":"Tomasz Figa ","Date":"Fri, 16 Apr 2021 01:08:47 +0900","Message-ID":"","To":"Jacopo Mondi ","Subject":"Re: [libcamera-devel] [PATCH v6 5/5] android: soraka: Add camera\n\tHAL configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16305,"web_url":"https://patchwork.libcamera.org/comment/16305/","msgid":"<32233ca3-1012-b055-ff98-9b484208872f@ideasonboard.com>","date":"2021-04-15T18:54:27","subject":"Re: [libcamera-devel] [PATCH v6 5/5] android: soraka: Add camera\n\tHAL configuration","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 15/04/2021 17:08, Tomasz Figa wrote:\n> On Thu, Apr 15, 2021 at 10:56 PM Jacopo Mondi wrote:\n>>\n>> Hi Hiro, Tomasz, Han-lin\n>>\n>> On Thu, Apr 15, 2021 at 03:52:13PM +0200, Jacopo Mondi wrote:\n>>> Add camera HAL configuration file for IPU3 Soraka.\n>>>\n>>\n>> I've sent this patch for discussion, but I'm wondering if libcamera is\n>> the right place where to store the HAL configuration file.\n>>\n>> In my opinion they would be better placed in the device overlay, like\n>> it happens today, in example, with the Intel HAL .xml configuration\n>> files.\n>>\n>> What do you think ?\n> \n> How about non-Chrome OS users of the device? I think we should have a\n> repository of default configuration files for supported devices, which\n> would be used if there is no custom configuration provided.\n\nIs there a generic way to detect what platform we are running on?\nThen we could select /etc/libcamera/$PLATFORM.yaml or such?\n\n--\nKieran\n\n\n\n> Best regards,\n> Tomasz\n> \n>> We should find a way to install this file in\n>> /etc/libcamera/ before merging the series, otherwise we'll break the\n>> HAL support in ChromiumOS.\n>>\n>> Thanks\n>> j\n>>\n>>> Reviewed-by: Laurent Pinchart \n>>> Reviewed-by: Hirokazu Honda \n>>> Signed-off-by: Jacopo Mondi \n>>> ---\n>>> src/android/data/soraka/camera_hal.yaml | 8 ++++++++\n>>> 1 file changed, 8 insertions(+)\n>>> create mode 100644 src/android/data/soraka/camera_hal.yaml\n>>>\n>>> diff --git a/src/android/data/soraka/camera_hal.yaml b/src/android/data/soraka/camera_hal.yaml\n>>> new file mode 100644\n>>> index 000000000000..2e9964035098\n>>> --- /dev/null\n>>> +++ b/src/android/data/soraka/camera_hal.yaml\n>>> @@ -0,0 +1,8 @@\n>>> +cameras:\n>>> + \"\\\\_SB_.PCI0.I2C4.CAM1\":\n>>> + location: front\n>>> + rotation: 0\n>>> +\n>>> + \"\\\\_SB_.PCI0.I2C2.CAM0\":\n>>> + location: back\n>>> + rotation: 0\n>>> --\n>>> 2.31.1\n>>>\n>>> _______________________________________________\n>>> libcamera-devel mailing list\n>>> libcamera-devel@lists.libcamera.org\n>>> https://lists.libcamera.org/listinfo/libcamera-devel\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF0FBBD231\n\tfor ;\n\tThu, 15 Apr 2021 18:54:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A63E6880C;\n\tThu, 15 Apr 2021 20:54:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 96D55605AE\n\tfor ;\n\tThu, 15 Apr 2021 20:54:31 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 067C389A;\n\tThu, 15 Apr 2021 20:54:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oGmde/sS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618512871;\n\tbh=m1RoBXrp97PEu1U8vWohHmuyyvGQUPjAeOEA/9tAe3s=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=oGmde/sSn5LLi0oj9Rrce2q0JkdwsSaMfIzqcDGScsEmWiwk5EvoQuwQYW1x7xEsD\n\t9xkk0n0pI561VR7yqgx1FQ/x5aLrSLyOnKoVzpyXFpDbB0Nfc6tCJujFolDpTPpBnG\n\tU6WPZA1sSt2qRLkezUzQFPRmyssAkHSTMBsAelas=","To":"Tomasz Figa , Jacopo Mondi ","References":"<20210415135213.94511-1-jacopo@jmondi.org>\n\t<20210415135213.94511-6-jacopo@jmondi.org>\n\t<20210415135651.dj4ouvodezxneqmo@uno.localdomain>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<32233ca3-1012-b055-ff98-9b484208872f@ideasonboard.com>","Date":"Thu, 15 Apr 2021 19:54:27 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v6 5/5] android: soraka: Add camera\n\tHAL configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16306,"web_url":"https://patchwork.libcamera.org/comment/16306/","msgid":"","date":"2021-04-15T19:05:40","subject":"Re: [libcamera-devel] [PATCH v6 5/5] android: soraka: Add camera\n\tHAL configuration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomasz,\n\nOn Fri, Apr 16, 2021 at 01:08:47AM +0900, Tomasz Figa wrote:\n> On Thu, Apr 15, 2021 at 10:56 PM Jacopo Mondi wrote:\n> > On Thu, Apr 15, 2021 at 03:52:13PM +0200, Jacopo Mondi wrote:\n> > > Add camera HAL configuration file for IPU3 Soraka.\n> >\n> > I've sent this patch for discussion, but I'm wondering if libcamera is\n> > the right place where to store the HAL configuration file.\n> >\n> > In my opinion they would be better placed in the device overlay, like\n> > it happens today, in example, with the Intel HAL .xml configuration\n> > files.\n> >\n> > What do you think ?\n> \n> How about non-Chrome OS users of the device? I think we should have a\n> repository of default configuration files for supported devices, which\n> would be used if there is no custom configuration provided.\n\nI don't really foresee system integrators actively contributing to such\na repository, so this effort may be doomed from the very beginning :-S\nWe could have some sort of community-driven repository, but even in that\ncase, how would we get the right configuration file installed\nautomatically ?\n\nDistributing the configuration files as part of the system integration\nseems better for Chrome OS. It may be a bit painful until the\nconfiguration file format stabilizes though, so I'm not completely\nopposed to carrying those files in the libcamera tree in the short term,\nbut we need to figure out a long term solution.\n\nEven if we carry those files in the libcamera source tree for now, how\ndo we ensure that the correct file gets installed in Chrome OS ?\n\n> > We should find a way to install this file in\n> > /etc/libcamera/ before merging the series, otherwise we'll break the\n> > HAL support in ChromiumOS.\n> >\n> > > Reviewed-by: Laurent Pinchart \n> > > Reviewed-by: Hirokazu Honda \n> > > Signed-off-by: Jacopo Mondi \n> > > ---\n> > > src/android/data/soraka/camera_hal.yaml | 8 ++++++++\n> > > 1 file changed, 8 insertions(+)\n> > > create mode 100644 src/android/data/soraka/camera_hal.yaml\n> > >\n> > > diff --git a/src/android/data/soraka/camera_hal.yaml b/src/android/data/soraka/camera_hal.yaml\n> > > new file mode 100644\n> > > index 000000000000..2e9964035098\n> > > --- /dev/null\n> > > +++ b/src/android/data/soraka/camera_hal.yaml\n> > > @@ -0,0 +1,8 @@\n> > > +cameras:\n> > > + \"\\\\_SB_.PCI0.I2C4.CAM1\":\n> > > + location: front\n> > > + rotation: 0\n> > > +\n> > > + \"\\\\_SB_.PCI0.I2C2.CAM0\":\n> > > + location: back\n> > > + rotation: 0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 124DCBD22F\n\tfor ;\n\tThu, 15 Apr 2021 19:05:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 827B2687F3;\n\tThu, 15 Apr 2021 21:05:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 086C7605AE\n\tfor ;\n\tThu, 15 Apr 2021 21:05:43 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C68E89A;\n\tThu, 15 Apr 2021 21:05:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZCUB61Rn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618513542;\n\tbh=6+Zh+dsSh9te7FNnbuYTutPR/lt4UT+ai7LN/FWsYuA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZCUB61RneZWc5vqGMnGYbl2vT+fV+InJOfzVAnlJ4kQuRFAWR0n/Nrcah6E6WIhFb\n\tpRkUmrQcGQDrblLN3KPFqnXQXASXQIn/MsAwTPYa5hb/wy5AUkoelJxdcFOLFl3sY9\n\t/JP8oYdQPRLzpbuUamH2/pWrKzBfBc370uQgS3Ws=","Date":"Thu, 15 Apr 2021 22:05:40 +0300","From":"Laurent Pinchart ","To":"Tomasz Figa ","Message-ID":"","References":"<20210415135213.94511-1-jacopo@jmondi.org>\n\t<20210415135213.94511-6-jacopo@jmondi.org>\n\t<20210415135651.dj4ouvodezxneqmo@uno.localdomain>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v6 5/5] android: soraka: Add camera\n\tHAL configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16308,"web_url":"https://patchwork.libcamera.org/comment/16308/","msgid":"<20210416082152.n74hlbuynda6c6fk@uno.localdomain>","date":"2021-04-16T08:21:52","subject":"Re: [libcamera-devel] [PATCH v6 5/5] android: soraka: Add camera\n\tHAL configuration","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hello,\n\nOn Thu, Apr 15, 2021 at 10:05:40PM +0300, Laurent Pinchart wrote:\n> Hi Tomasz,\n>\n> On Fri, Apr 16, 2021 at 01:08:47AM +0900, Tomasz Figa wrote:\n> > On Thu, Apr 15, 2021 at 10:56 PM Jacopo Mondi wrote:\n> > > On Thu, Apr 15, 2021 at 03:52:13PM +0200, Jacopo Mondi wrote:\n> > > > Add camera HAL configuration file for IPU3 Soraka.\n> > >\n> > > I've sent this patch for discussion, but I'm wondering if libcamera is\n> > > the right place where to store the HAL configuration file.\n> > >\n> > > In my opinion they would be better placed in the device overlay, like\n> > > it happens today, in example, with the Intel HAL .xml configuration\n> > > files.\n> > >\n> > > What do you think ?\n> >\n> > How about non-Chrome OS users of the device? I think we should have a\n> > repository of default configuration files for supported devices, which\n> > would be used if there is no custom configuration provided.\n\nRemember the configuration file is a requirement only for the\nconsumers of the Camera HAL. libcamera does not generically require\nthat.\n\n>\n> I don't really foresee system integrators actively contributing to such\n> a repository, so this effort may be doomed from the very beginning :-S\n> We could have some sort of community-driven repository, but even in that\n> case, how would we get the right configuration file installed\n> automatically ?\n>\n\nI think the last question is the most relevant one. We can keep a\nrepository somewhere of known configuration file, but which one has to\nbe selected and installed it's not something that should be handled\nby the libcamera build system, as I assume we don't want to add\ndevice-specific steps to the build process. I would rather expect that\nsystem integrators that use libcamera have instead the target device\nas a very well defined concept in their build infrastructure, and they\ncan easily support installing the right configuration file depending\non the target.\n\nAlthough, I understand someone trying to integrate the camera HAL in\ntheir device might find the configuration file presence being a hard\nrequirement a bit harsh, and might want some examples and a\ndocumentation of the expected formats (or better a schema) in the code\nbase to build on top.\n\n> Distributing the configuration files as part of the system integration\n> seems better for Chrome OS. It may be a bit painful until the\n> configuration file format stabilizes though, so I'm not completely\n> opposed to carrying those files in the libcamera tree in the short term,\n> but we need to figure out a long term solution.\n>\n> Even if we carry those files in the libcamera source tree for now, how\n> do we ensure that the correct file gets installed in Chrome OS ?\n>\n> > > We should find a way to install this file in\n> > > /etc/libcamera/ before merging the series, otherwise we'll break the\n> > > HAL support in ChromiumOS.\n> > >\n> > > > Reviewed-by: Laurent Pinchart \n> > > > Reviewed-by: Hirokazu Honda \n> > > > Signed-off-by: Jacopo Mondi \n> > > > ---\n> > > > src/android/data/soraka/camera_hal.yaml | 8 ++++++++\n> > > > 1 file changed, 8 insertions(+)\n> > > > create mode 100644 src/android/data/soraka/camera_hal.yaml\n> > > >\n> > > > diff --git a/src/android/data/soraka/camera_hal.yaml b/src/android/data/soraka/camera_hal.yaml\n> > > > new file mode 100644\n> > > > index 000000000000..2e9964035098\n> > > > --- /dev/null\n> > > > +++ b/src/android/data/soraka/camera_hal.yaml\n> > > > @@ -0,0 +1,8 @@\n> > > > +cameras:\n> > > > + \"\\\\_SB_.PCI0.I2C4.CAM1\":\n> > > > + location: front\n> > > > + rotation: 0\n> > > > +\n> > > > + \"\\\\_SB_.PCI0.I2C2.CAM0\":\n> > > > + location: back\n> > > > + rotation: 0\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D07DBD233\n\tfor ;\n\tFri, 16 Apr 2021 08:21:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B13CA6880C;\n\tFri, 16 Apr 2021 10:21:15 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9193D605AE\n\tfor ;\n\tFri, 16 Apr 2021 10:21:14 +0200 (CEST)","from uno.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id AF1F91C0012;\n\tFri, 16 Apr 2021 08:21:13 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","Date":"Fri, 16 Apr 2021 10:21:52 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210416082152.n74hlbuynda6c6fk@uno.localdomain>","References":"<20210415135213.94511-1-jacopo@jmondi.org>\n\t<20210415135213.94511-6-jacopo@jmondi.org>\n\t<20210415135651.dj4ouvodezxneqmo@uno.localdomain>\n\t\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v6 5/5] android: soraka: Add camera\n\tHAL configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Tomasz Figa ,\n\tlibcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16382,"web_url":"https://patchwork.libcamera.org/comment/16382/","msgid":"<20210420094812.cpee2tl6mhged4fq@uno.localdomain>","date":"2021-04-20T09:48:12","subject":"Re: [libcamera-devel] [PATCH v6 5/5] android: soraka: Add camera\n\tHAL configuration","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hello,\n\nOn Fri, Apr 16, 2021 at 10:21:52AM +0200, Jacopo Mondi wrote:\n> Hello,\n>\n> On Thu, Apr 15, 2021 at 10:05:40PM +0300, Laurent Pinchart wrote:\n> > Hi Tomasz,\n> >\n> > On Fri, Apr 16, 2021 at 01:08:47AM +0900, Tomasz Figa wrote:\n> > > On Thu, Apr 15, 2021 at 10:56 PM Jacopo Mondi wrote:\n> > > > On Thu, Apr 15, 2021 at 03:52:13PM +0200, Jacopo Mondi wrote:\n> > > > > Add camera HAL configuration file for IPU3 Soraka.\n> > > >\n> > > > I've sent this patch for discussion, but I'm wondering if libcamera is\n> > > > the right place where to store the HAL configuration file.\n> > > >\n> > > > In my opinion they would be better placed in the device overlay, like\n> > > > it happens today, in example, with the Intel HAL .xml configuration\n> > > > files.\n> > > >\n> > > > What do you think ?\n> > >\n> > > How about non-Chrome OS users of the device? I think we should have a\n> > > repository of default configuration files for supported devices, which\n> > > would be used if there is no custom configuration provided.\n>\n> Remember the configuration file is a requirement only for the\n> consumers of the Camera HAL. libcamera does not generically require\n> that.\n>\n> >\n> > I don't really foresee system integrators actively contributing to such\n> > a repository, so this effort may be doomed from the very beginning :-S\n> > We could have some sort of community-driven repository, but even in that\n> > case, how would we get the right configuration file installed\n> > automatically ?\n> >\n>\n> I think the last question is the most relevant one. We can keep a\n> repository somewhere of known configuration file, but which one has to\n> be selected and installed it's not something that should be handled\n> by the libcamera build system, as I assume we don't want to add\n> device-specific steps to the build process. I would rather expect that\n> system integrators that use libcamera have instead the target device\n> as a very well defined concept in their build infrastructure, and they\n> can easily support installing the right configuration file depending\n> on the target.\n>\n> Although, I understand someone trying to integrate the camera HAL in\n> their device might find the configuration file presence being a hard\n> requirement a bit harsh, and might want some examples and a\n> documentation of the expected formats (or better a schema) in the code\n> base to build on top.\n>\n> > Distributing the configuration files as part of the system integration\n> > seems better for Chrome OS. It may be a bit painful until the\n> > configuration file format stabilizes though, so I'm not completely\n> > opposed to carrying those files in the libcamera tree in the short term,\n> > but we need to figure out a long term solution.\n> >\n> > Even if we carry those files in the libcamera source tree for now, how\n> > do we ensure that the correct file gets installed in Chrome OS ?\n\nI feel this is the last topic we need to solve to have the\nconfiguration file series merged...\n\nThe question is: where do we collect and how to deploy the\nconfiguration files ?\n\nNot to re-state what said above, I don't mean to be pushy just to\nsummarize the situation a bit:\n\n- configuration file is only used by the HAL\n- libcamera does not have device-specific installation step\n- vendors will likely not contribute much to any repository of\n configuration file, but rather prepare them ad-hoc for each device\n- an example configuration file in the libcamera repository might be\n helpfull\n\nAll in all, I feel the distribution of configuration file is better\nhandled at the operating system level, and not directly by libcamera,\nlike it is done nowadays for the .xml tuning files for the\nIntel/Rockchip HALs.\n\nIf we have an agreement on this, what is the plan to support\nconfiguration files integration in ChromiumOS ?\n\nThanks\n j\n\n\n> >\n> > > > We should find a way to install this file in\n> > > > /etc/libcamera/ before merging the series, otherwise we'll break the\n> > > > HAL support in ChromiumOS.\n> > > >\n> > > > > Reviewed-by: Laurent Pinchart \n> > > > > Reviewed-by: Hirokazu Honda \n> > > > > Signed-off-by: Jacopo Mondi \n> > > > > ---\n> > > > > src/android/data/soraka/camera_hal.yaml | 8 ++++++++\n> > > > > 1 file changed, 8 insertions(+)\n> > > > > create mode 100644 src/android/data/soraka/camera_hal.yaml\n> > > > >\n> > > > > diff --git a/src/android/data/soraka/camera_hal.yaml b/src/android/data/soraka/camera_hal.yaml\n> > > > > new file mode 100644\n> > > > > index 000000000000..2e9964035098\n> > > > > --- /dev/null\n> > > > > +++ b/src/android/data/soraka/camera_hal.yaml\n> > > > > @@ -0,0 +1,8 @@\n> > > > > +cameras:\n> > > > > + \"\\\\_SB_.PCI0.I2C4.CAM1\":\n> > > > > + location: front\n> > > > > + rotation: 0\n> > > > > +\n> > > > > + \"\\\\_SB_.PCI0.I2C2.CAM0\":\n> > > > > + location: back\n> > > > > + rotation: 0\n> >\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77418BDB15\n\tfor ;\n\tTue, 20 Apr 2021 09:47:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DBE6868840;\n\tTue, 20 Apr 2021 11:47:33 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D16F56883C\n\tfor ;\n\tTue, 20 Apr 2021 11:47:32 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 9C385C000A;\n\tTue, 20 Apr 2021 09:47:31 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Tue, 20 Apr 2021 11:48:12 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ,\n\tTomasz Figa ","Message-ID":"<20210420094812.cpee2tl6mhged4fq@uno.localdomain>","References":"<20210415135213.94511-1-jacopo@jmondi.org>\n\t<20210415135213.94511-6-jacopo@jmondi.org>\n\t<20210415135651.dj4ouvodezxneqmo@uno.localdomain>\n\t\n\t\n\t<20210416082152.n74hlbuynda6c6fk@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210416082152.n74hlbuynda6c6fk@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v6 5/5] android: soraka: Add camera\n\tHAL configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16387,"web_url":"https://patchwork.libcamera.org/comment/16387/","msgid":"","date":"2021-04-20T12:10:02","subject":"Re: [libcamera-devel] [PATCH v6 5/5] android: soraka: Add camera\n\tHAL configuration","submitter":{"id":72,"url":"https://patchwork.libcamera.org/api/people/72/","name":"Han-lin Chen","email":"hanlinchen@google.com"},"content":"Hi,\n\nOn Tue, Apr 20, 2021 at 5:47 PM Jacopo Mondi wrote:\n>\n> Hello,\n>\n> On Fri, Apr 16, 2021 at 10:21:52AM +0200, Jacopo Mondi wrote:\n> > Hello,\n> >\n> > On Thu, Apr 15, 2021 at 10:05:40PM +0300, Laurent Pinchart wrote:\n> > > Hi Tomasz,\n> > >\n> > > On Fri, Apr 16, 2021 at 01:08:47AM +0900, Tomasz Figa wrote:\n> > > > On Thu, Apr 15, 2021 at 10:56 PM Jacopo Mondi wrote:\n> > > > > On Thu, Apr 15, 2021 at 03:52:13PM +0200, Jacopo Mondi wrote:\n> > > > > > Add camera HAL configuration file for IPU3 Soraka.\n> > > > >\n> > > > > I've sent this patch for discussion, but I'm wondering if libcamera is\n> > > > > the right place where to store the HAL configuration file.\n> > > > >\n> > > > > In my opinion they would be better placed in the device overlay, like\n> > > > > it happens today, in example, with the Intel HAL .xml configuration\n> > > > > files.\n> > > > >\n> > > > > What do you think ?\n> > > >\n> > > > How about non-Chrome OS users of the device? I think we should have a\n> > > > repository of default configuration files for supported devices, which\n> > > > would be used if there is no custom configuration provided.\n> >\n> > Remember the configuration file is a requirement only for the\n> > consumers of the Camera HAL. libcamera does not generically require\n> > that.\n> >\n> > >\n> > > I don't really foresee system integrators actively contributing to such\n> > > a repository, so this effort may be doomed from the very beginning :-S\n> > > We could have some sort of community-driven repository, but even in that\n> > > case, how would we get the right configuration file installed\n> > > automatically ?\n> > >\n> >\n> > I think the last question is the most relevant one. We can keep a\n> > repository somewhere of known configuration file, but which one has to\n> > be selected and installed it's not something that should be handled\n> > by the libcamera build system, as I assume we don't want to add\n> > device-specific steps to the build process. I would rather expect that\n> > system integrators that use libcamera have instead the target device\n> > as a very well defined concept in their build infrastructure, and they\n> > can easily support installing the right configuration file depending\n> > on the target.\n> >\n> > Although, I understand someone trying to integrate the camera HAL in\n> > their device might find the configuration file presence being a hard\n> > requirement a bit harsh, and might want some examples and a\n> > documentation of the expected formats (or better a schema) in the code\n> > base to build on top.\n> >\n> > > Distributing the configuration files as part of the system integration\n> > > seems better for Chrome OS. It may be a bit painful until the\n> > > configuration file format stabilizes though, so I'm not completely\n> > > opposed to carrying those files in the libcamera tree in the short term,\n> > > but we need to figure out a long term solution.\n> > >\n> > > Even if we carry those files in the libcamera source tree for now, how\n> > > do we ensure that the correct file gets installed in Chrome OS ?\n>\n> I feel this is the last topic we need to solve to have the\n> configuration file series merged...\n>\n> The question is: where do we collect and how to deploy the\n> configuration files ?\n>\n> Not to re-state what said above, I don't mean to be pushy just to\n> summarize the situation a bit:\n>\n> - configuration file is only used by the HAL\n> - libcamera does not have device-specific installation step\n> - vendors will likely not contribute much to any repository of\n> configuration file, but rather prepare them ad-hoc for each device\n> - an example configuration file in the libcamera repository might be\n> helpfull\n>\n> All in all, I feel the distribution of configuration file is better\n> handled at the operating system level, and not directly by libcamera,\n> like it is done nowadays for the .xml tuning files for the\n> Intel/Rockchip HALs.\n>\n> If we have an agreement on this, what is the plan to support\n> configuration files integration in ChromiumOS ?\n>\n> Thanks\n> j\n\nOn ChromeOS, typically the configuration file is submitted to the\ndevice overlay as the xml files of Intel/Rockchip.\nWe are free to submit an ebuild together with the configure file to\noverlay-${board}, and it will only be installed to the image of the\nspecific board only.\nFor each new device we have to do the same thing. Overlay has an\ninheritance relationship which could be helpful when we have a group\nof devices to have the same configuration files. I can help with this\npart.\n\nFor other platforms I have no idea. If we are going to have\nconfiguration for tuning in the future, the problem may not limit only\nto Android/ChromeOS.\n\n>\n>\n> > >\n> > > > > We should find a way to install this file in\n> > > > > /etc/libcamera/ before merging the series, otherwise we'll break the\n> > > > > HAL support in ChromiumOS.\n> > > > >\n> > > > > > Reviewed-by: Laurent Pinchart \n> > > > > > Reviewed-by: Hirokazu Honda \n> > > > > > Signed-off-by: Jacopo Mondi \n> > > > > > ---\n> > > > > > src/android/data/soraka/camera_hal.yaml | 8 ++++++++\n> > > > > > 1 file changed, 8 insertions(+)\n> > > > > > create mode 100644 src/android/data/soraka/camera_hal.yaml\n> > > > > >\n> > > > > > diff --git a/src/android/data/soraka/camera_hal.yaml b/src/android/data/soraka/camera_hal.yaml\n> > > > > > new file mode 100644\n> > > > > > index 000000000000..2e9964035098\n> > > > > > --- /dev/null\n> > > > > > +++ b/src/android/data/soraka/camera_hal.yaml\n> > > > > > @@ -0,0 +1,8 @@\n> > > > > > +cameras:\n> > > > > > + \"\\\\_SB_.PCI0.I2C4.CAM1\":\n> > > > > > + location: front\n> > > > > > + rotation: 0\n> > > > > > +\n> > > > > > + \"\\\\_SB_.PCI0.I2C2.CAM0\":\n> > > > > > + location: back\n> > > > > > + rotation: 0\n> > >\n> > > --\n> > > Regards,\n> > >\n> > > Laurent Pinchart\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CBF6DBDB15\n\tfor ;\n\tTue, 20 Apr 2021 12:10:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2789E68840;\n\tTue, 20 Apr 2021 14:10:15 +0200 (CEST)","from mail-wr1-x433.google.com (mail-wr1-x433.google.com\n\t[IPv6:2a00:1450:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6FB8760516\n\tfor ;\n\tTue, 20 Apr 2021 14:10:13 +0200 (CEST)","by mail-wr1-x433.google.com with SMTP id k26so20930725wrc.8\n\tfor ;\n\tTue, 20 Apr 2021 05:10:13 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"dEGJTVu+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=sqBmyoiZzDDyin1SlAErhSgQF7a2mnXOJmkHQaXSDw4=;\n\tb=dEGJTVu+orfi/9OswDy0jj6Qzn710SndaMixmTXwL3PrVrljBxV/2e17J/emtvai3E\n\t80gij7v4XYhr25blGiWkgbLtrMWupqBG+yoEpUuGNy6EzsYtggtoDWg8B9k1qAa0VNNv\n\tFVknPcKPRLBzl8t1u5aVvybry4NuJXWshKNlm47yeJiVCuDgFV5Ae+NlPNsX/kx/7CHF\n\tc0LptoOSa4sfZvy5Yc/XhZX4LHx1SgKOQgTGdZdWF28YIRpIggarE/TFBw37KCzPwa1o\n\tT4PnDVXHhgs/XRD+wxyei1XCmzX9/x6/Qly/Ryq5qJsGu6I+WXDA17KrsM9JLWAEIDPy\n\taXvg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=sqBmyoiZzDDyin1SlAErhSgQF7a2mnXOJmkHQaXSDw4=;\n\tb=diRZ4TAbxYclsaGN3v8rUOWPXq7MhbfQ5akGAg9r7CAiM7XnxSADfrkz+iSKgipy6N\n\taV5nSA7gst6o3guUQ2A3MrG9oYPfo/FgR7iZHuy96mw6dSzIJARah22k3dlmpoSxEGiB\n\tCE9L2goZEndBUMdtdxRzzP8oSxU4HyURaudYcyZLOOziGmXo2h2RuQHP/31CN48NAz+r\n\t+F2+Q0rU4k9MlCtrrM4wIaAnDtOPL1svZGVr5dF4zRaEw8eqXrdOT26K3XCgC/SJmTx7\n\tMleJvA+b9vtTJ16VThk2jsYrC6b/lBORGi3eY/I23EawWj0EvfMpUIT1KDU2UO1xmEAT\n\tXwJA==","X-Gm-Message-State":"AOAM532TCzAnncasDiUj+8Yg2lD5dqC+cCYavjm9lyAiVQi9uviNfqa6\n\tE67wU16fA3eNNm6MhLbSnpPYw8lQCpe3D8gPhEgPKQ==","X-Google-Smtp-Source":"ABdhPJwgUtv/hUzVGP+gBrobDgN3RYHCn7dsyffKxGdVMr2nAcNplyoEcHQ3nymF2pvkwkrVxmuu92wU/E4B7iQa3e8=","X-Received":"by 2002:a5d:6d48:: with SMTP id k8mr20240104wri.93.1618920612897;\n\tTue, 20 Apr 2021 05:10:12 -0700 (PDT)","MIME-Version":"1.0","References":"<20210415135213.94511-1-jacopo@jmondi.org>\n\t<20210415135213.94511-6-jacopo@jmondi.org>\n\t<20210415135651.dj4ouvodezxneqmo@uno.localdomain>\n\t\n\t\n\t<20210416082152.n74hlbuynda6c6fk@uno.localdomain>\n\t<20210420094812.cpee2tl6mhged4fq@uno.localdomain>","In-Reply-To":"<20210420094812.cpee2tl6mhged4fq@uno.localdomain>","From":"Han-lin Chen ","Date":"Tue, 20 Apr 2021 20:10:02 +0800","Message-ID":"","To":"Jacopo Mondi ","Subject":"Re: [libcamera-devel] [PATCH v6 5/5] android: soraka: Add camera\n\tHAL configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Tomasz Figa ,\n\tlibcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16668,"web_url":"https://patchwork.libcamera.org/comment/16668/","msgid":"","date":"2021-04-28T11:35:28","subject":"Re: [libcamera-devel] [PATCH v6 5/5] android: soraka: Add camera\n\tHAL configuration","submitter":{"id":48,"url":"https://patchwork.libcamera.org/api/people/48/","name":"Tomasz Figa","email":"tfiga@google.com"},"content":"On Fri, Apr 16, 2021 at 4:05 AM Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Tomasz,\n>\n> On Fri, Apr 16, 2021 at 01:08:47AM +0900, Tomasz Figa wrote:\n> > On Thu, Apr 15, 2021 at 10:56 PM Jacopo Mondi wrote:\n> > > On Thu, Apr 15, 2021 at 03:52:13PM +0200, Jacopo Mondi wrote:\n> > > > Add camera HAL configuration file for IPU3 Soraka.\n> > >\n> > > I've sent this patch for discussion, but I'm wondering if libcamera is\n> > > the right place where to store the HAL configuration file.\n> > >\n> > > In my opinion they would be better placed in the device overlay, like\n> > > it happens today, in example, with the Intel HAL .xml configuration\n> > > files.\n> > >\n> > > What do you think ?\n> >\n> > How about non-Chrome OS users of the device? I think we should have a\n> > repository of default configuration files for supported devices, which\n> > would be used if there is no custom configuration provided.\n>\n> I don't really foresee system integrators actively contributing to such\n> a repository, so this effort may be doomed from the very beginning :-S\n>\n\nWell, pulseaudio does have similar files for audio mixer configuration [1]\nand libinput for device quirks [2].\n\n[1]\nhttps://cgit.freedesktop.org/pulseaudio/pulseaudio/tree/src/modules/alsa/mixer/profile-sets\n[2] https://gitlab.freedesktop.org/libinput/libinput/-/tree/master/quirks\n\nAnd this doesn't really differ from hardcoding those settings in respective\npipeline handlers as is done today for many aspects.\n\n\n> We could have some sort of community-driven repository, but even in that\n> case, how would we get the right configuration file installed\n> automatically ?\n>\n>\nI think we could just install everything, as the projects I mentioned above\nand choose the right one by some IDs.\n\n\n> Distributing the configuration files as part of the system integration\n> seems better for Chrome OS. It may be a bit painful until the\n> configuration file format stabilizes though, so I'm not completely\n> opposed to carrying those files in the libcamera tree in the short term,\n> but we need to figure out a long term solution.\n>\n> Even if we carry those files in the libcamera source tree for now, how\n> do we ensure that the correct file gets installed in Chrome OS ?\n>\n>\nI think we need some runtime detection.\n\n\n> > > We should find a way to install this file in\n> > > /etc/libcamera/ before merging the series, otherwise we'll break the\n> > > HAL support in ChromiumOS.\n> > >\n> > > > Reviewed-by: Laurent Pinchart \n> > > > Reviewed-by: Hirokazu Honda \n> > > > Signed-off-by: Jacopo Mondi \n> > > > ---\n> > > > src/android/data/soraka/camera_hal.yaml | 8 ++++++++\n> > > > 1 file changed, 8 insertions(+)\n> > > > create mode 100644 src/android/data/soraka/camera_hal.yaml\n> > > >\n> > > > diff --git a/src/android/data/soraka/camera_hal.yaml\n> b/src/android/data/soraka/camera_hal.yaml\n> > > > new file mode 100644\n> > > > index 000000000000..2e9964035098\n> > > > --- /dev/null\n> > > > +++ b/src/android/data/soraka/camera_hal.yaml\n> > > > @@ -0,0 +1,8 @@\n> > > > +cameras:\n> > > > + \"\\\\_SB_.PCI0.I2C4.CAM1\":\n> > > > + location: front\n> > > > + rotation: 0\n> > > > +\n> > > > + \"\\\\_SB_.PCI0.I2C2.CAM0\":\n> > > > + location: back\n> > > > + rotation: 0\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08CB9BDE41\n\tfor ;\n\tWed, 28 Apr 2021 11:35:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E4C2688DC;\n\tWed, 28 Apr 2021 13:35:42 +0200 (CEST)","from mail-wm1-x336.google.com (mail-wm1-x336.google.com\n\t[IPv6:2a00:1450:4864:20::336])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E0D7688C5\n\tfor ;\n\tWed, 28 Apr 2021 13:35:40 +0200 (CEST)","by mail-wm1-x336.google.com with SMTP id\n\tl189-20020a1cbbc60000b0290140319ad207so6582290wmf.2\n\tfor ;\n\tWed, 28 Apr 2021 04:35:40 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"JksjHpxo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=uuJz8QUUFlp3k3DSWa7pKyHjW4QurN/eoSkm7zrYanA=;\n\tb=JksjHpxoFNX3zpm0AaWqkI3HT9yT/O/IPU2ZxpSxdaxRlXTnB+g+4z/WzsPD9U64aj\n\tG6NjB1Yg+zHQzTZFC9aVbF3QLBd1HcrSgguvHFWR7olSr599xMd7TG284dKGU3aJ1sMH\n\t6I9Nv1wRkv4vF0P6kV0dBk13pbRJtR2WicLzEbX848LQLkkHlrar05/VoZigQLU3M0Cj\n\tCRqLFjtpe1UOwFQg6TVX+op22NfO+jopLUnYWLnGJc/D7NkjTkRp4f3eWzVl0Uj+wpiN\n\tNh86bI6KrzTo+dQxH+OQsaZ2iDx2yS/MLkYbe/U+5HboR63FmbZ6+oE0nd+vm8llBUNm\n\tIIAA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=uuJz8QUUFlp3k3DSWa7pKyHjW4QurN/eoSkm7zrYanA=;\n\tb=JGIvexfVXEEaIQ+HBxKEVQxQFiaG8hXjHV+nKk/XMTqR0R35tT715rnQSdUDbY9zaB\n\t/+Pep+wv1MVcxkFfpLrTVd9qeX5GyUNfyEhaU0MhcJAeCg8n6KoZsGcHxkqcyN2JNN4b\n\to/GY907xs7z2Ru2X03M8uAe+SktMk9humpauZxExnHhOQRBKxvq53PqLqLLlKPGiAabw\n\tWGWquxXwpFLiRQDy2Q6fwVoKOrpTlOvjmA9sjNyqFfkOuRrUV7EBfo2p+1LMPFD35zH3\n\tquXplnsMDLS93e+1jK4PPayhlYvftKphNthUPj+ew6J5Ge001+4/3Bh9hz5e9HXL22Kb\n\th41g==","X-Gm-Message-State":"AOAM533NaIl0jLl62cxDoILo/f8du27ku3K+oM7qFVDRxPGZLVsJCLIr\n\tlaetyAWbgX8R9NBKk7fjhTKndFNm8cKUq0KwNyUE2A==","X-Google-Smtp-Source":"ABdhPJwkXtJNq0XUi2YwOPUtULMpP3/rbgetQwFX6PoQCoRxHgdDqaUJ2Xz7PWBHy7f3UU6N47EnoH1imP2oWhOeGQU=","X-Received":"by 2002:a7b:c091:: with SMTP id r17mr3940469wmh.28.1619609740074;\n\tWed, 28 Apr 2021 04:35:40 -0700 (PDT)","MIME-Version":"1.0","References":"<20210415135213.94511-1-jacopo@jmondi.org>\n\t<20210415135213.94511-6-jacopo@jmondi.org>\n\t<20210415135651.dj4ouvodezxneqmo@uno.localdomain>\n\t\n\t","In-Reply-To":"","From":"Tomasz Figa ","Date":"Wed, 28 Apr 2021 20:35:28 +0900","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v6 5/5] android: soraka: Add camera\n\tHAL configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============5608941338691700088==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]