[{"id":16296,"web_url":"https://patchwork.libcamera.org/comment/16296/","msgid":"<20210415104811.cddfvungizdtxzuv@basti-TUXEDO-Book-XA1510>","date":"2021-04-15T10:48:11","subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Fix typo in a\n\tcomment","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"content":"Hey Naushir,\n\nThank you for the patch.\n\nOn 15.04.2021 11:17, Naushir Patuck wrote:\n>s/embedded/bayer/\n>\n>Signed-off-by: Naushir Patuck \nReviewed-by: Sebastian Fricke \n\n>---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n>diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n>index f22e286ed87a..2a917455500f 100644\n>--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n>+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n>@@ -1802,7 +1802,7 @@ bool RPiCameraData::findMatchingBuffers(BayerFrame &bayerFrame, FrameBuffer *&em\n> \t\t\t * pending embedded data buffers.\n> \t\t\t */\n> \t\t\tif (bayerRequeueCount == unicam_[Unicam::Image].getBuffers().size()) {\n>-\t\t\t\t/* The embedded queue must be empty at this point! */\n>+\t\t\t\t/* The bayer queue must be empty at this point! */\n> \t\t\t\tASSERT(bayerQueue_.empty());\n>\n> \t\t\t\tLOG(RPI, Warning) << \"Flushing embedded data stream!\";\n>-- \n>2.25.1\n>\n>_______________________________________________\n>libcamera-devel mailing list\n>libcamera-devel@lists.libcamera.org\n>https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5EE58BD1F6\n\tfor ;\n\tThu, 15 Apr 2021 10:48:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D4471687F3;\n\tThu, 15 Apr 2021 12:48:14 +0200 (CEST)","from mout02.posteo.de (mout02.posteo.de [185.67.36.66])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA0F6605AE\n\tfor ;\n\tThu, 15 Apr 2021 12:48:13 +0200 (CEST)","from submission (posteo.de [89.146.220.130]) \n\tby mout02.posteo.de (Postfix) with ESMTPS id 074D72400FC\n\tfor ;\n\tThu, 15 Apr 2021 12:48:12 +0200 (CEST)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4FLbfN44cxz6tnK;\n\tThu, 15 Apr 2021 12:48:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"pXsrntBI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1618483693; bh=+rgE9gxgIQBZGFl7tvBARGKb10XA3PLKwW+NIyGXVT8=;\n\th=Date:From:To:Cc:Subject:From;\n\tb=pXsrntBIWgLs2es3CV+BtulwB35OKeI6EEtJ1wGccYgJtFY/Na6zCl7hBUUvPtg6Z\n\td6c9Z6If29mbz5egWkQAdySe6Cko6UrP2KhKBFuTCm6vumhxk6yZ4BWUBk1WsRCIOj\n\tX9uOZ2klqPrmsJ+69BjIFrKnv4YtV8Mk9we4FGEETuTtoGQI1GphbgZJ+3/W1M/hV4\n\t2s/Cd/sVGIoF/QfXozfVynZZPMz22/G5CAMSLgdryQlPY8Qlzp2PVuUhNmyovZapBG\n\tD1Bbyz1pQUGMf4wjmtemGoXjE0U/xgs2nafBsIJNzuVeoDheyT2zROiT68GK3/MdM5\n\tSstwwLWuvkdBQ==","Date":"Thu, 15 Apr 2021 12:48:11 +0200","From":"Sebastian Fricke ","To":"Naushir Patuck ","Message-ID":"<20210415104811.cddfvungizdtxzuv@basti-TUXEDO-Book-XA1510>","References":"<20210415101741.1215178-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210415101741.1215178-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Fix typo in a\n\tcomment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16370,"web_url":"https://patchwork.libcamera.org/comment/16370/","msgid":"","date":"2021-04-20T00:36:20","subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Fix typo in a\n\tcomment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Thu, Apr 15, 2021 at 11:17:42AM +0100, Naushir Patuck wrote:\n> s/embedded/bayer/\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index f22e286ed87a..2a917455500f 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1802,7 +1802,7 @@ bool RPiCameraData::findMatchingBuffers(BayerFrame &bayerFrame, FrameBuffer *&em\n> \t\t\t * pending embedded data buffers.\n> \t\t\t */\n> \t\t\tif (bayerRequeueCount == unicam_[Unicam::Image].getBuffers().size()) {\n> -\t\t\t\t/* The embedded queue must be empty at this point! */\n> +\t\t\t\t/* The bayer queue must be empty at this point! */\n> \t\t\t\tASSERT(bayerQueue_.empty());\n> \n> \t\t\t\tLOG(RPI, Warning) << \"Flushing embedded data stream!\";","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DFC1EBD814\n\tfor ;\n\tTue, 20 Apr 2021 00:36:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 59EB068838;\n\tTue, 20 Apr 2021 02:36:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84364602CA\n\tfor ;\n\tTue, 20 Apr 2021 02:36:24 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 02FEF470;\n\tTue, 20 Apr 2021 02:36:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pVzxz13C\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618878984;\n\tbh=3bidT/Lz+9swvQacSJ/C/rdKxK0Uj2jt50iziilIig4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pVzxz13CGbQx5teK9GfmcxqchXoz8pafldKH+sZkZse6a6L/t8IDHq1tYeOSKhipn\n\tKEZJtzyT3UJ/MwyfXpbeBZUmtYHiPvLvxpeYqgjtSU58AGqwgNSRkcDWr1jRa2vGFu\n\t4wquR5x99aIskBhoyAIIAhxEwPEiL4BFzWuDwM9E=","Date":"Tue, 20 Apr 2021 03:36:20 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20210415101741.1215178-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210415101741.1215178-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] pipeline: raspberrypi: Fix typo in a\n\tcomment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]