[{"id":16287,"web_url":"https://patchwork.libcamera.org/comment/16287/","msgid":"","date":"2021-04-14T22:44:24","subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: cam_helper.hpp: Correct a\n\twrong choice of term","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Sebastian,\n\nThank you for the patch.\n\nOn Wed, Apr 14, 2021 at 08:02:58PM +0200, Sebastian Fricke wrote:\n> Sensors provide embedded buffers and not metadata buffers, replace the\n> incorrect term with the correct one.\n> \n> Signed-off-by: Sebastian Fricke \n> ---\n> src/ipa/raspberrypi/cam_helper.hpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp\n> index eaf73019..2ab3d49f 100644\n> --- a/src/ipa/raspberrypi/cam_helper.hpp\n> +++ b/src/ipa/raspberrypi/cam_helper.hpp\n> @@ -35,7 +35,7 @@ namespace RPiController {\n> //\n> // A method to query if the sensor outputs embedded data that can be parsed.\n> //\n> -// A parser to parse the metadata buffers provided by some sensors (for\n> +// A parser to parse the embedded buffers provided by some sensors (for\n\nThe correct term would be \"embedded data\", not just \"embedded\". That's a\nform of metadata though. I don't mind much either way, let's say what\nDavid prefers.\n\n> // example, the imx219 does; the ov5647 doesn't). This allows us to know for\n> // sure the exposure and gain of the frame we're looking at. CamHelper\n> // provides methods for converting analogue gains to and from the sensor's","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 95CFABD224\n\tfor ;\n\tWed, 14 Apr 2021 22:44:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 55A99687D6;\n\tThu, 15 Apr 2021 00:44:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30C0E687D6\n\tfor ;\n\tThu, 15 Apr 2021 00:44:26 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BB0A7510;\n\tThu, 15 Apr 2021 00:44:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pfRUvxVq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618440265;\n\tbh=LGlTGzMurQgz0vLudqhJfNnj5hYJJ+FLea1Hl888cY0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pfRUvxVqfSw9bB13tgQYeV7KMknFo99I7iKUJVHHwWk7vcIplXPKU+oa1Z/ntNBvJ\n\t6VA056U953mjg2ksbNgZBFwk+A70sXnQagAJ0vqbU/vkEF6IZNNVqUmadbsZOAUkuW\n\tVHv98dwwUlYRgaFvXAlnkgVJWZP60FVSuE8EzisQ=","Date":"Thu, 15 Apr 2021 01:44:24 +0300","From":"Laurent Pinchart ","To":"Sebastian Fricke ","Message-ID":"","References":"<20210414180256.10724-1-sebastian.fricke@posteo.net>\n\t<20210414180256.10724-2-sebastian.fricke@posteo.net>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210414180256.10724-2-sebastian.fricke@posteo.net>","Subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: cam_helper.hpp: Correct a\n\twrong choice of term","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16294,"web_url":"https://patchwork.libcamera.org/comment/16294/","msgid":"","date":"2021-04-15T08:04:38","subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: cam_helper.hpp: Correct a\n\twrong choice of term","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Sebastian, Laurent,\n\nThanks for proposing this change.\n\nOn Wed, 14 Apr 2021 at 23:44, Laurent Pinchart\n wrote:\n>\n> Hi Sebastian,\n>\n> Thank you for the patch.\n>\n> On Wed, Apr 14, 2021 at 08:02:58PM +0200, Sebastian Fricke wrote:\n> > Sensors provide embedded buffers and not metadata buffers, replace the\n> > incorrect term with the correct one.\n> >\n> > Signed-off-by: Sebastian Fricke \n> > ---\n> > src/ipa/raspberrypi/cam_helper.hpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp\n> > index eaf73019..2ab3d49f 100644\n> > --- a/src/ipa/raspberrypi/cam_helper.hpp\n> > +++ b/src/ipa/raspberrypi/cam_helper.hpp\n> > @@ -35,7 +35,7 @@ namespace RPiController {\n> > //\n> > // A method to query if the sensor outputs embedded data that can be parsed.\n> > //\n> > -// A parser to parse the metadata buffers provided by some sensors (for\n> > +// A parser to parse the embedded buffers provided by some sensors (for\n>\n> The correct term would be \"embedded data\", not just \"embedded\". That's a\n> form of metadata though. I don't mind much either way, let's say what\n> David prefers.\n\nAt the moment these buffers only ever contain the sensor's register\ndumps, though there's a patch already in the pipeline that allows them\nto be more general, containing different kinds of image statistics or\nthe results of on-sensor image analysis algorithms.\n\nIf we're happy to describe all these as \"embedded data buffers\" then\nthe change sounds good to me. Actually, I quite like using \"embedded\ndata buffers\" to refer to these buffers from the sensor, rather than\n\"metadata buffers\". The term \"metadata\" gets thrown around rather too\nmuch (blaming myself here!) so terminology that immediately tells you\nit's straight from the sensor seems clearer. Assuming then that\n\"embedded data buffers\" makes sense to everyone else:\n\nReviewed-by: David Plowman \n\nThanks!\n\nDavid\n\n>\n> > // example, the imx219 does; the ov5647 doesn't). This allows us to know for\n> > // sure the exposure and gain of the frame we're looking at. CamHelper\n> > // provides methods for converting analogue gains to and from the sensor's\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 760B0BD1F6\n\tfor ;\n\tThu, 15 Apr 2021 08:04:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D847868812;\n\tThu, 15 Apr 2021 10:04:51 +0200 (CEST)","from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com\n\t[IPv6:2607:f8b0:4864:20::32d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50CC66880A\n\tfor ;\n\tThu, 15 Apr 2021 10:04:50 +0200 (CEST)","by mail-ot1-x32d.google.com with SMTP id\n\th19-20020a9d64130000b02902875a567768so10845982otl.0\n\tfor ;\n\tThu, 15 Apr 2021 01:04:50 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"EO+QIUGR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=sNM1CyBSay8IKAQxXS3GI8KH1ieumiz6/e8+hHmskNQ=;\n\tb=EO+QIUGRQqU9RWHRBzEeNWdmWjYomN49A0YYsxcwLcDg1PtJoRwsO6z6hxydniK6jS\n\toSSJGznypOmnWBg9pTt+sen7/XkBUKiUvMQer6i8wPrLym5foib4EWU7PuEWJFnbHNZI\n\txWkKQOGJlrSUUcFBQaPD3cY51JDlfJbd7ToBQ4jxSPqzplK8xbnLKryJm7q/15tUX2Dw\n\t/LyJtFULQycY0Gu0cOzSRkvJLeTLE1CypntGgQeQwwc4kPoSSA0mCoNrNOyT9G6/N7Fm\n\t03kl9RhWXy5/STruxuOX+22kxKi3lY4JeiFDM31MzIgeSaG1RfKeWx9C/ufhkjmxq0B3\n\tQiYQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=sNM1CyBSay8IKAQxXS3GI8KH1ieumiz6/e8+hHmskNQ=;\n\tb=Ok9J2IWtb86kE5pjIZgSVLSDqZe0GzDNvkksGUxuxA225RQelYHlXQHd6AjhGgORDW\n\tsZxidaMb7yscsE1D2TdzxvcwJ50U62qD5wTcb9THlUVbkrQb8oI2/PWgD9ZJpBBWI9hR\n\tl84qz9owf4gRXLejFfoPRz9qGvfRNH6vKizOc5h52572PjS6kVHQyYcuFqLeI1Ecwkbi\n\tKsU2Qh/eiN2fIX/oQbK1M85qkUPJ9OaLrIEli5zwlUi5++dsuW9p3YhPnCN3gq4GBiaG\n\trotG40a+GP3dnifoKKEbdnSg8dGHKns8i7Irlmxi2dwojAZNxlv62tuqAZYobvm7zIlB\n\tzVLA==","X-Gm-Message-State":"AOAM533MyJAS64XMnXWivK7fuYtdhYrP+GPVtDaZacX5Z1ddL4dLh+YY\n\tLEV1tXKUwzsBA1rclfTtGMpPkTh3bx1JBCwfn95E7w==","X-Google-Smtp-Source":"ABdhPJxd+IcGovhtljCZAoz1dbBLQxEJmPwqXJ5lYvlvuF7hE7nLAyH3l7bn0GxfopWDbeN/fg025OmoT2ZE8VQf+Q8=","X-Received":"by 2002:a9d:2f48:: with SMTP id\n\th66mr1665632otb.160.1618473889042; \n\tThu, 15 Apr 2021 01:04:49 -0700 (PDT)","MIME-Version":"1.0","References":"<20210414180256.10724-1-sebastian.fricke@posteo.net>\n\t<20210414180256.10724-2-sebastian.fricke@posteo.net>\n\t","In-Reply-To":"","From":"David Plowman ","Date":"Thu, 15 Apr 2021 09:04:38 +0100","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: cam_helper.hpp: Correct a\n\twrong choice of term","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16295,"web_url":"https://patchwork.libcamera.org/comment/16295/","msgid":"<20210415091435.dczuydpochyl33gn@basti-TUXEDO-Book-XA1510>","date":"2021-04-15T09:14:35","subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: cam_helper.hpp: Correct a\n\twrong choice of term","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"content":"Hey David and Laurent,\n\nOn 15.04.2021 09:04, David Plowman wrote:\n>Hi Sebastian, Laurent,\n>\n>Thanks for proposing this change.\n>\n>On Wed, 14 Apr 2021 at 23:44, Laurent Pinchart\n> wrote:\n>>\n>> Hi Sebastian,\n>>\n>> Thank you for the patch.\n>>\n>> On Wed, Apr 14, 2021 at 08:02:58PM +0200, Sebastian Fricke wrote:\n>> > Sensors provide embedded buffers and not metadata buffers, replace the\n>> > incorrect term with the correct one.\n>> >\n>> > Signed-off-by: Sebastian Fricke \n>> > ---\n>> > src/ipa/raspberrypi/cam_helper.hpp | 2 +-\n>> > 1 file changed, 1 insertion(+), 1 deletion(-)\n>> >\n>> > diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp\n>> > index eaf73019..2ab3d49f 100644\n>> > --- a/src/ipa/raspberrypi/cam_helper.hpp\n>> > +++ b/src/ipa/raspberrypi/cam_helper.hpp\n>> > @@ -35,7 +35,7 @@ namespace RPiController {\n>> > //\n>> > // A method to query if the sensor outputs embedded data that can be parsed.\n>> > //\n>> > -// A parser to parse the metadata buffers provided by some sensors (for\n>> > +// A parser to parse the embedded buffers provided by some sensors (for\n>>\n>> The correct term would be \"embedded data\", not just \"embedded\". That's a\n>> form of metadata though. I don't mind much either way, let's say what\n>> David prefers.\n\n@Laurent\nOkay I think embedded data buffer ist better than embedded buffer.\nDo you change that before applying the patch or would you like to get a\nv2?\n\n>\n>At the moment these buffers only ever contain the sensor's register\n>dumps, though there's a patch already in the pipeline that allows them\n>to be more general, containing different kinds of image statistics or\n>the results of on-sensor image analysis algorithms.\n>\n>If we're happy to describe all these as \"embedded data buffers\" then\n>the change sounds good to me. Actually, I quite like using \"embedded\n>data buffers\" to refer to these buffers from the sensor, rather than\n>\"metadata buffers\". The term \"metadata\" gets thrown around rather too\n>much (blaming myself here!) so terminology that immediately tells you\n>it's straight from the sensor seems clearer. Assuming then that\n>\"embedded data buffers\" makes sense to everyone else:\n\n@David\nThank you for making this clear, I currently read a lot of those\ncomments across the RPi implementation, I will make sure to change\nmetadata buffer references to embedded data buffer references, whenever\nI spot them.\n\n>\n>Reviewed-by: David Plowman \n>\n>Thanks!\n>\n>David\n\nGreetings,\nSebastian\n>\n>>\n>> > // example, the imx219 does; the ov5647 doesn't). This allows us to know for\n>> > // sure the exposure and gain of the frame we're looking at. CamHelper\n>> > // provides methods for converting analogue gains to and from the sensor's\n>>\n>> --\n>> Regards,\n>>\n>> Laurent Pinchart\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01E43BD1F6\n\tfor ;\n\tThu, 15 Apr 2021 09:14:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6B3FF68817;\n\tThu, 15 Apr 2021 11:14:41 +0200 (CEST)","from mout02.posteo.de (mout02.posteo.de [185.67.36.66])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ABF4F6880E\n\tfor ;\n\tThu, 15 Apr 2021 11:14:39 +0200 (CEST)","from submission (posteo.de [89.146.220.130]) \n\tby mout02.posteo.de (Postfix) with ESMTPS id AB03F2400FE\n\tfor ;\n\tThu, 15 Apr 2021 11:14:38 +0200 (CEST)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4FLYZP6Gcfz6tmW;\n\tThu, 15 Apr 2021 11:14:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"HGtWrRR4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1618478078; bh=qQO0CMlYvM7AAZgBIS7Bk2GaiH1iVoO0g5gHCDzzsUg=;\n\th=Date:From:To:Cc:Subject:From;\n\tb=HGtWrRR4rXoQSrcc/eF+q5dO2XVu30IwL/1AMlZV+/65WuHw8PNSsWe9R0KUBgH/n\n\tEqm9lIjLvuwO6MrB69fi22Gxfs0pH7cEubpS6dADzSD0N2y5hXxI3oiyRlSkNPQHut\n\tlhwSAgfp66oTgnu4Obv/+YAbEW/Ug902tcufDtfj5/UnNVxVjkizXSMxK8pfuRCmSK\n\taYb0UVa5dAzRqNJIJ176P/IiI4qiNChSVOIO3bQVY/1RZs1JmJIycHHQdaf1mhvK5b\n\tdkYmWtwE7xeB4J0ikBJr/eU/CdTWuVhwZacXamPxrDhEG8a+bMZIip9xECwjZL/iJ/\n\taFoNDi4/kKTLQ==","Date":"Thu, 15 Apr 2021 11:14:35 +0200","From":"Sebastian Fricke ","To":"David Plowman ","Message-ID":"<20210415091435.dczuydpochyl33gn@basti-TUXEDO-Book-XA1510>","References":"<20210414180256.10724-1-sebastian.fricke@posteo.net>\n\t<20210414180256.10724-2-sebastian.fricke@posteo.net>\n\t\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: cam_helper.hpp: Correct a\n\twrong choice of term","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]