[{"id":16286,"web_url":"https://patchwork.libcamera.org/comment/16286/","msgid":"","date":"2021-04-14T22:43:23","subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: cam_helper.hpp: Remove\n\tduplicate words","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Sebastian,\n\nThank you for the patch.\n\nOn Wed, Apr 14, 2021 at 08:02:56PM +0200, Sebastian Fricke wrote:\n> Signed-off-by: Sebastian Fricke \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/cam_helper.hpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp\n> index 1b2d6eec..eaf73019 100644\n> --- a/src/ipa/raspberrypi/cam_helper.hpp\n> +++ b/src/ipa/raspberrypi/cam_helper.hpp\n> @@ -16,8 +16,8 @@\n> namespace RPiController {\n> \n> // The CamHelper class provides a number of facilities that anyone trying\n> -// trying to drive a camera will need to know, but which are not provided by\n> -// by the standard driver framework. Specifically, it provides:\n> +// to drive a camera will need to know, but which are not provided by the\n> +// standard driver framework. Specifically, it provides:\n> //\n> // A \"CameraMode\" structure to describe extra information about the chosen\n> // mode of the driver. For example, how it is cropped from the full sensor","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78F81BD1F6\n\tfor ;\n\tWed, 14 Apr 2021 22:43:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B8E906880C;\n\tThu, 15 Apr 2021 00:43:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3BFCB687D6\n\tfor ;\n\tThu, 15 Apr 2021 00:43:26 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9EE95510;\n\tThu, 15 Apr 2021 00:43:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Uyo6ucLh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618440205;\n\tbh=/SJ7lmjOxIN+ukMy2ibzkQS9VdhcsNjhMMTvKb98daU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Uyo6ucLhrUcVpF5yksKKYJb7+bXX/aPnXvbAT1nqbY8MabU0iDcJlCpiHoBr7uNJA\n\t3WikAKdct3RgkbYOrb7vvJdzPhdNQevDnVRelgxHlKLuuTAWhm8oxSnPUhhTVeAP6Q\n\tsWG8a4AgHNh61L0dptLSqblBvARrOJH5NoNJwgmo=","Date":"Thu, 15 Apr 2021 01:43:23 +0300","From":"Laurent Pinchart ","To":"Sebastian Fricke ","Message-ID":"","References":"<20210414180256.10724-1-sebastian.fricke@posteo.net>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210414180256.10724-1-sebastian.fricke@posteo.net>","Subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: cam_helper.hpp: Remove\n\tduplicate words","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16298,"web_url":"https://patchwork.libcamera.org/comment/16298/","msgid":"","date":"2021-04-15T11:52:52","subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: cam_helper.hpp: Remove\n\tduplicate words","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Sebastian,\n\nOn Wed, 14 Apr 2021 at 19:03, Sebastian Fricke \nwrote:\n\n> Signed-off-by: Sebastian Fricke \n>\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n>\n src/ipa/raspberrypi/cam_helper.hpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/cam_helper.hpp\n> b/src/ipa/raspberrypi/cam_helper.hpp\n> index 1b2d6eec..eaf73019 100644\n> --- a/src/ipa/raspberrypi/cam_helper.hpp\n> +++ b/src/ipa/raspberrypi/cam_helper.hpp\n> @@ -16,8 +16,8 @@\n> namespace RPiController {\n>\n> // The CamHelper class provides a number of facilities that anyone trying\n> -// trying to drive a camera will need to know, but which are not provided\n> by\n> -// by the standard driver framework. Specifically, it provides:\n> +// to drive a camera will need to know, but which are not provided by the\n> +// standard driver framework. Specifically, it provides:\n> //\n> // A \"CameraMode\" structure to describe extra information about the chosen\n> // mode of the driver. For example, how it is cropped from the full sensor\n> --\n> 2.25.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DDA66BD224\n\tfor ;\n\tThu, 15 Apr 2021 11:53:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E56768813;\n\tThu, 15 Apr 2021 13:53:10 +0200 (CEST)","from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com\n\t[IPv6:2a00:1450:4864:20::12b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6FBD4605AE\n\tfor ;\n\tThu, 15 Apr 2021 13:53:09 +0200 (CEST)","by mail-lf1-x12b.google.com with SMTP id z13so21714455lfd.9\n\tfor ;\n\tThu, 15 Apr 2021 04:53:09 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"HVvhsQME\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=BzpO2/QSdonSaiM9A7Njaj7VJu8t+H+bYQqEy49BCVk=;\n\tb=HVvhsQME4mcWMk+7LN6LwE4QX9IJvXNZwc4W6Z5Rl5XdcsreN9xmeT+fEhAiuOZnho\n\tfYCc0Xwuv7LtPgK9AyBUAK1+D37LGiT7Pai8Cxvpwri+B/0vLDKBHrfjPCgFkowN5JkL\n\tG61VofSCvspA+fnpiUcS03bDCvikZaxmgT43cxky7G7Hj3aAjkP5RdX9jsF5uN6C63ob\n\t71fiPNBhvkvNrZuFVTVDou+x7JFZFgq3kBK/bhFvzh+UDKUhFoEcEeMXxHyfRLwRxbJz\n\tgsmprpvPEAAzc3qfUKxMmR3De2tujYmYy49OhSP24/RfH+g4co/wLmbtM7hqazFYrGcf\n\tSpiQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=BzpO2/QSdonSaiM9A7Njaj7VJu8t+H+bYQqEy49BCVk=;\n\tb=UI4URjY7VrBwO8nHCCUdj+NautshUqkZ7YuohXgEIHxK6c8h0/+nB0ayVfGmhklzQE\n\tVV37uvSVXkA5X44iuhE4Q8Mt6MYklMBQdlRe0LKo7KVq7jHdRhmh+qae3w0i268yHX5c\n\tmbgLT/8Y+Lg2IJx6I8ycIi3/fJfcjBhSbQZN7yss/+9BVxO88GD0xBR+PZRefmwlaD5E\n\t2VFHCImgQOAhBisOr2TB3b6z5c8TNYXdpQCpeMvW1KPe05+ssV3LV4Dlu3PcPTDXoste\n\t63Zge8+uc9iTw2uxqsqdMf/lxERdorgn1ZstU3Z1dRz2c55yaqK+d8bqRF62mITTWjhF\n\tuhEw==","X-Gm-Message-State":"AOAM530ssSUL2vnP8BFxibkDxOqCvpZKlBCu17oioj8zbIFhsNmcn6rK\n\tOn6/nzV1V98O22fXrSEGhSkudAjtIQheBtgdsykvSw==","X-Google-Smtp-Source":"ABdhPJyYCKpSPxUtTzszDFLlmOuhCiS7PMMxb1NLb1CWcLG3oBRrcWN76tiBzyDqNKKcfk82ny8kMi32GQXPqKcLabI=","X-Received":"by 2002:a05:6512:1322:: with SMTP id\n\tx34mr2255683lfu.133.1618487588692; \n\tThu, 15 Apr 2021 04:53:08 -0700 (PDT)","MIME-Version":"1.0","References":"<20210414180256.10724-1-sebastian.fricke@posteo.net>","In-Reply-To":"<20210414180256.10724-1-sebastian.fricke@posteo.net>","From":"Naushir Patuck ","Date":"Thu, 15 Apr 2021 12:52:52 +0100","Message-ID":"","To":"Sebastian Fricke ","Subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: cam_helper.hpp: Remove\n\tduplicate words","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============7221088321853946664==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]