[{"id":16283,"web_url":"https://patchwork.libcamera.org/comment/16283/","msgid":"","date":"2021-04-14T14:19:54","subject":"Re: [libcamera-devel] [PATCH] lc-compliance: simple_capture: Handle\n\tunsupported roles","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 14/04/2021 15:10, Niklas Söderlund wrote:\n> It's valid for a camera to return a nullptr if the requested set of\n> roles can not be satisfied. This is not correctly handled by\n> lc-compliance which instead crashes, fix this.\n> \n> Signed-off-by: Niklas Söderlund \n\nOhhh I bet we haven't considered this in all the places it's used.\n\nBut indeed this is true.\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/lc-compliance/simple_capture.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/lc-compliance/simple_capture.cpp b/src/lc-compliance/simple_capture.cpp\n> index 811a6220009654be..64e862a08e3a8221 100644\n> --- a/src/lc-compliance/simple_capture.cpp\n> +++ b/src/lc-compliance/simple_capture.cpp\n> @@ -23,6 +23,9 @@ Results::Result SimpleCapture::configure(StreamRole role)\n> {\n> \tconfig_ = camera_->generateConfiguration({ role });\n> \n> +\tif (!config_)\n> +\t\treturn { Results::Skip, \"Role not supported by camera\" };\n> +\n> \tif (config_->validate() != CameraConfiguration::Valid) {\n> \t\tconfig_.reset();\n> \t\treturn { Results::Fail, \"Configuration not valid\" };\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B694BD1F6\n\tfor ;\n\tWed, 14 Apr 2021 14:19:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 719786880C;\n\tWed, 14 Apr 2021 16:19:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CDE9368803\n\tfor ;\n\tWed, 14 Apr 2021 16:19:56 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F49F6F2;\n\tWed, 14 Apr 2021 16:19:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HjFIeoOc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618409996;\n\tbh=8gR3O1ArCNvnn8QgyBB5FcW2Dz6qiICIGFuQSg0xglw=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=HjFIeoOcrUzP02gK+lfiqeeH2p8WUwxVZzaepxkN/x8qx6QJI4O2lCZTMPFDAu7Vr\n\tICCwSemS+W1xz8yNchFfzqCEWbnXBno4FZd03CnDMg+pSqkYTrx0bhUsa0LmyTm7D1\n\tseUQ+B9BFAhCh1Y7KFOvE/3HVeULv7GcayuSlHxk=","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210414141014.523762-1-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Wed, 14 Apr 2021 15:19:54 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210414141014.523762-1-niklas.soderlund@ragnatech.se>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] lc-compliance: simple_capture: Handle\n\tunsupported roles","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16284,"web_url":"https://patchwork.libcamera.org/comment/16284/","msgid":"","date":"2021-04-14T14:30:46","subject":"Re: [libcamera-devel] [PATCH] lc-compliance: simple_capture: Handle\n\tunsupported roles","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2021-04-14 15:19:54 +0100, Kieran Bingham wrote:\n> Hi Niklas,\n> \n> On 14/04/2021 15:10, Niklas Söderlund wrote:\n> > It's valid for a camera to return a nullptr if the requested set of\n> > roles can not be satisfied. This is not correctly handled by\n> > lc-compliance which instead crashes, fix this.\n> > \n> > Signed-off-by: Niklas Söderlund \n> \n> Ohhh I bet we haven't considered this in all the places it's used.\n\nYea I think it's bordering on a flaw in our organic API growth. It's not \nsuper clear at a first look what the difference errors signaled between\n\n !conifg\n\nand\n\n config->validate() != CameraConfiguration::Valid\n\nare. I think we somehow should consolidate this in the Camera so that \napplications always get a configuration but if the pipeline can't \nsatisfy the roles it could maybe also be signaled thru \nconfig->validate()?\n\n> \n> But indeed this is true.\n> \n> Reviewed-by: Kieran Bingham \n> \n> > ---\n> > src/lc-compliance/simple_capture.cpp | 3 +++\n> > 1 file changed, 3 insertions(+)\n> > \n> > diff --git a/src/lc-compliance/simple_capture.cpp b/src/lc-compliance/simple_capture.cpp\n> > index 811a6220009654be..64e862a08e3a8221 100644\n> > --- a/src/lc-compliance/simple_capture.cpp\n> > +++ b/src/lc-compliance/simple_capture.cpp\n> > @@ -23,6 +23,9 @@ Results::Result SimpleCapture::configure(StreamRole role)\n> > {\n> > \tconfig_ = camera_->generateConfiguration({ role });\n> > \n> > +\tif (!config_)\n> > +\t\treturn { Results::Skip, \"Role not supported by camera\" };\n> > +\n> > \tif (config_->validate() != CameraConfiguration::Valid) {\n> > \t\tconfig_.reset();\n> > \t\treturn { Results::Fail, \"Configuration not valid\" };\n> > \n> \n> -- \n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34F52BD224\n\tfor ;\n\tWed, 14 Apr 2021 14:30:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A02236880C;\n\tWed, 14 Apr 2021 16:30:50 +0200 (CEST)","from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com\n\t[IPv6:2a00:1450:4864:20::22a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BF9A168803\n\tfor ;\n\tWed, 14 Apr 2021 16:30:48 +0200 (CEST)","by mail-lj1-x22a.google.com with SMTP id a36so12677368ljq.8\n\tfor ;\n\tWed, 14 Apr 2021 07:30:48 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tg9sm2217453lfb.233.2021.04.14.07.30.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 14 Apr 2021 07:30:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"geauV6gT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=EhFQLf/eTRdYL1AdGNSKZN2r4EPujC7GNUFq+DJ+ufI=;\n\tb=geauV6gTfshyuTwBwf5Bf8Ov0pFih8xrN/Y7nZNkhGcilmPzCRJK7I+eXb9aFrRNYR\n\ts0kYM0bNqQvu5vHWKjA6vxc0tRfxM/+t2NHJ3WOTYVPheuOrs3tN5ww4/+DROh2OZYQM\n\tuUzuQvohFu547fJnYGAuTCHXHD7E5uu8+aGb16eMg6X/+XeRoycBg2aLErILbpGBGNjw\n\tyw65moEWqkrm0JNS9EaZoXEavFkQ1jnpx1Gn3YiHwmaFlXUfmM5BtkGdyDd+r2Pxo4Zx\n\tlkjKjVgyDImJ2W3vhsBrLo/auo8peyOrfh2rh4vyR5HnWdEgcOgFbjNhVm+fFcfuElWE\n\tts2w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=EhFQLf/eTRdYL1AdGNSKZN2r4EPujC7GNUFq+DJ+ufI=;\n\tb=Ez7B3vokeOvyRKPlQzvozfSOfRXKwBtv2TTCafyfHPbxm1tQ30Ac34E8ecLxc8iN1n\n\tXLTWinHs10o6x/YiwmGkdlt6JX7QTslKt8JXqROCKZ39bqa5V5dxz9WD7ULXnBKjKWfi\n\t6P+IKH+vu9UEyIbji0fBKTBpTSlwdSCUvW51jUq8oG8EuOYbkPstu6hxhJ6Ux2GlUdM5\n\ttBG24hC9WwUQJpz8Wo9kNOdk6VC4ADeQf6zA8Lqu8fSdY+nFUfTwHN4U+4MAc6Px2yrz\n\tQQwrWrAqa1j1DRca92D9PRLPYGyPaK9LiLgZFwYu19lihlYBJzKq11zwwAA4BK8SZ2Cc\n\tdW1Q==","X-Gm-Message-State":"AOAM532towIDyBf/PVxKr/MC/ysmFcYgUVFDQ+EXDaCm3WYIkBzWB1p3\n\tK7gHLpJjd3G0/CUh0j9xxLIxoSBho86UlQ==","X-Google-Smtp-Source":"ABdhPJyKnEXveYIV6pEagh38xaTLxpTgz22hFg4IRwqszU0ASVp9GWJQKXE6v7qMFp7dYDTcsgchHQ==","X-Received":"by 2002:a2e:9f11:: with SMTP id\n\tu17mr7632149ljk.447.1618410648072; \n\tWed, 14 Apr 2021 07:30:48 -0700 (PDT)","Date":"Wed, 14 Apr 2021 16:30:46 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Message-ID":"","References":"<20210414141014.523762-1-niklas.soderlund@ragnatech.se>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] lc-compliance: simple_capture: Handle\n\tunsupported roles","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16315,"web_url":"https://patchwork.libcamera.org/comment/16315/","msgid":"","date":"2021-04-16T14:11:44","subject":"Re: [libcamera-devel] [PATCH] lc-compliance: simple_capture: Handle\n\tunsupported roles","submitter":{"id":84,"url":"https://patchwork.libcamera.org/api/people/84/","name":"Nícolas F. R. A. Prado","email":"nfraprado@collabora.com"},"content":"Em 2021-04-14 11:10, Niklas Söderlund escreveu:\n\n> It's valid for a camera to return a nullptr if the requested set of\n> roles can not be satisfied. This is not correctly handled by\n> lc-compliance which instead crashes, fix this.\n>\n> Signed-off-by: Niklas Söderlund \n\nGlad to soon have lc-compliance working on rkisp1 without needing any additional\npatches :).\n\nTested-by: Nícolas F. R. A. Prado \n\nThanks,\nNícolas","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB61EBD235\n\tfor ;\n\tFri, 16 Apr 2021 14:15:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 538B06880C;\n\tFri, 16 Apr 2021 16:15:58 +0200 (CEST)","from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 69CD068806\n\tfor ;\n\tFri, 16 Apr 2021 16:15:57 +0200 (CEST)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: nfraprado) with ESMTPSA id 553BE1F43747"],"Mime-Version":"1.0","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\t","From":"=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= ","Date":"Fri, 16 Apr 2021 11:11:44 -0300","Message-Id":"","In-Reply-To":"<20210414141014.523762-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH] lc-compliance: simple_capture: Handle\n\tunsupported roles","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]